Fix #102687: Use Proper Style for Label Length Estimation #111908

Harley Acheson · 2023-09-04T01:44:01+02:00

Harley Acheson commented

2023-09-04 01:44:01 +02:00

When estimating widget sizes, ui_text_icon_width_ex() assumes that all
items are using the "widget" text style, which is incorrect for labels.
This PR uses widget_label style for uiItemL_ and the label portion of
ui_item_with_label.

If go to Edit / Preferences / Themes / Text Style you can change the text sizes of different UI elements. But if you make the "Widget Label" larger than "Widget" we have spots where text can overflow even if there is lots of room:

This is because ui_text_icon_width_ex() assumes that all items are using the "widget" text style. This PR passes a style to this function, using widgetlabel for labels, widget for everything else.

This is a simple fix. It can go in regardless of what we do with text styles. #111712

When estimating widget sizes, ui_text_icon_width_ex() assumes that all items are using the "widget" text style, which is incorrect for labels. This PR uses widget_label style for uiItemL_ and the label portion of ui_item_with_label. --- If go to Edit / Preferences / Themes / Text Style you can change the text sizes of different UI elements. But if you make the "Widget Label" larger than "Widget" we have spots where text can overflow even if there is lots of room: ![image](/attachments/66d3b104-8879-4606-addf-120e18e75244) This is because ui_text_icon_width_ex() assumes that all items are using the "widget" text style. This PR passes a style to this function, using widgetlabel for labels, widget for everything else. ![image](/attachments/b6a8d11d-c705-4f41-9ad8-259b0153a613) This is a simple fix. It can go in regardless of what we do with text styles. #111712

image.png

21 KiB

image.png

22 KiB

❤️ 1

Harley Acheson added 1 commit 2023-09-04 01:44:13 +02:00

bc87055df0 Fix #102687 : Use Proper Style for Label Text Length Estimation

When estimating widget sizes, ui_text_icon_width_ex() assumes that all
items are using the "widget" text style, which is incorrect for labels.
This PR uses widget_label style for uiItemL_ and the label portion of
ui_item_with_label.

Harley Acheson added this to the User Interface project 2023-09-04 01:44:38 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-09-04 01:44:46 +02:00

Pablo Vazquez approved these changes 2023-09-04 01:53:34 +02:00

Pablo Vazquez left a comment

Nice one. Wonder how many more little things like this there are out there.

Thanks!

Nice one. Wonder how many more little things like this there are out there. Thanks!

Harley Acheson merged commit 20427cb3ad into main

2023-09-05 00:59:05 +02:00

Harley Acheson deleted branch WidgetLabelWidth

2023-09-05 00:59:07 +02:00

Harley Acheson referenced this issue from a commit

2023-09-05 00:59:09 +02:00

Fix #102687: Use Proper Style for Label Length Estimation

Stefan Werner referenced this issue from a commit

2023-09-07 15:02:39 +02:00

Fix #102687: Use Proper Style for Label Length Estimation

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #102687: Use Proper Style for Label Length Estimation #111908