Fix #111821: Sculpt Mode: Scene Statistics showing wrong results #111914

Pratik Borhade · 2023-09-04T08:15:05+02:00

Pratik Borhade commented

2023-09-04 08:15:05 +02:00

Caused by 6e20beba22
When in sculpt mode, total selected objects were not calculated. Hence,
anysel was false. To fix this, calculate total objects in sculpt mode
(optionally we can calculate total selected objects) and total visible
objects in viewport.

Caused by 6e20beba22df4b3b1455240d005c744370e06881 When in sculpt mode, total selected objects were not calculated. Hence, `anysel` was false. To fix this, calculate total objects in sculpt mode (optionally we can calculate total selected objects) and total visible objects in viewport.

Pratik Borhade added 1 commit 2023-09-04 08:15:20 +02:00

4be661e099 Fix #111821 : Sculpt Mode: Scene Statistics showing wrong results

Caused by 6e20beba22
When in sculpt mode, total selected objects were not calculated. Due to this
`anysel` was false. To fix this calculate total objects in sculpt mode
(optionally we can calculate total selected objects) and total visible
objects in viewport

Pratik Borhade requested review from Pablo Vazquez 2023-09-04 08:15:31 +02:00

Pratik Borhade requested review from Harley Acheson 2023-09-04 08:15:31 +02:00

Pratik Borhade commented

2023-09-04 08:16:42 +02:00

(optionally we can calculate total selected objects)

Instead of this, I've calculated "objects in sculpt mode". Let me know which number is expected there :)

> (optionally we can calculate total selected objects) Instead of this, I've calculated "objects in sculpt mode". Let me know which number is expected there :)

Pratik Borhade added the

Module

User Interface

label 2023-09-04 08:41:02 +02:00

Harley Acheson commented

2023-09-05 01:07:54 +02:00

@PratikPB2123

This solution might have merit, but... it masks the mistake I made in 6e20beba22. In that PR I tested for 0 objects selected before dealing with sculpt mode, which always (currently) has object totals of zero.

This I why I merged in #111945 as it directly fixes my error without adding any new iterations. With yours we now have to consider whether we need object counts in Sculpt mode. Probably not?

@PratikPB2123 This solution might have merit, but... it masks the mistake I made in 6e20beba22. In that PR I tested for 0 objects selected before dealing with sculpt mode, which always (currently) has object totals of zero. This I why I merged in #111945 as it directly fixes my error without adding any new iterations. With yours we now have to consider whether we need object counts in Sculpt mode. Probably not?

Pratik Borhade commented

2023-09-05 12:11:22 +02:00

we now have to consider whether we need object counts in Sculpt mode. Probably not?

I don't really see any use of object count in sculpt mode :)
So yes, I agree to remove them (as you've done in 66f825135a)

Apart from this, we could think of removing object count from "vertex/weight/texture paint". They only handle active object

> we now have to consider whether we need object counts in Sculpt mode. Probably not? I don't really see any use of object count in sculpt mode :) So yes, I agree to remove them (as you've done in 66f825135a6360e2b24f09d1ad3d21078bade289) Apart from this, we could think of removing object count from "vertex/weight/texture paint". They only handle `active object`

Pratik Borhade closed this pull request

2023-09-07 12:02:53 +02:00

Pratik Borhade deleted branch 111821-sculpt-info-stats

2023-09-07 12:03:03 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #111821: Sculpt Mode: Scene Statistics showing wrong results #111914

Pull request closed