Cleanup: Remove extern "C" from DNA headers #111926

Julian Eisel · 2023-09-04T13:06:43+02:00

Julian Eisel commented

2023-09-04 13:06:43 +02:00

extern "C" did not actually have an effect here since it only impacts
name mangling of functions, not structs (or other class types). Now this
can get in the way when we add C++ blocks with functions , e.g.
templates are not allowed in code with C-linkage.

Most of these were added in ad4b7741db, even though it was known that
this doesn't have any impact. Reason was because developers thought they
would have to add that to all direct and indirect includes to be able to
use a header in C++ (a common misconception). Now with most files
compiled in C++, it's obvious that this isn't the case.

`extern "C"` did not actually have an effect here since it only impacts name mangling of functions, not structs (or other class types). Now this can get in the way when we add C++ blocks with functions , e.g. templates are not allowed in code with C-linkage. Most of these were added in ad4b7741db, even though it was known that this doesn't have any impact. Reason was because developers thought they would have to add that to all direct and indirect includes to be able to use a header in C++ (a common misconception). Now with most files compiled in C++, it's obvious that this isn't the case.

Julian Eisel added the

Module

Core

label 2023-09-04 13:06:43 +02:00

Julian Eisel added 1 commit 2023-09-04 13:06:51 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

92a78f0a05 Cleanup: Remove `extern "C"` from DNA headers

`extern "C"` did not actually have an effect here since it only impacts
name mangling of functions, not structs (or other class types). Now this
can get in the way when we add functions to structs, e.g. templates are
not allowed in code with C-linkage.

Most of these were added in ad4b7741db, even though it was known that
this doesn't have any impact. Reason was because developers thought they
would have to add that to all direct and indirect includes to be able to
use a header in C++ (a common misconception). Now with most files
compiled in C++, it's obvious that this isn't the case.

Julian Eisel requested review from Bastien Montagne 2023-09-04 13:07:27 +02:00

Bastien Montagne commented

2023-09-04 15:21:17 +02:00

@blender-bot build

Bastien Montagne approved these changes 2023-09-04 15:47:05 +02:00

Bastien Montagne left a comment

Provided builds are OK, patch LGTM, nice to get a bit less clutter in these files.

Julian Eisel merged commit 4c8847ec4f into main

2023-09-04 15:59:48 +02:00

Julian Eisel referenced this issue from a commit

2023-09-04 15:59:48 +02:00

Cleanup: Remove `extern "C"` from DNA headers