Animation: Graph Editor locked key drawing #111986

Christoph Lendenfeld · 2023-09-05T17:21:12+02:00

2023-09-05 17:21:12 +02:00

As people have pointed out, the changes to key drawing in this PR (#106052: Animation: Improve drawing of locked FCurves) are not ideal under all conditions.

The fact that an X is drawn to indicate a key can't be manipulated adds too much noise on dense data and is generally confusing.

To combat that, I've changed it back to drawing key dots, but this time in gray ( the same color as disabled curves) and slightly smaller.

~~While I think this is an improvement, there is something that needs to be discussed with the A&R module.~~
Using the same gray as a disabled curve might be conceptually confusing. Locked keys are not disabled, the still work but you just can't move them. If people don't feel like that is an issue then the patch can be landed.

This was discussed in the recent A&R module meeting and the decision was to keep the keys gray but also make them a bit smaller.

As people have pointed out, the changes to key drawing in this PR ([#106052: Animation: Improve drawing of locked FCurves](https://projects.blender.org/blender/blender/pulls/106052)) are not ideal under all conditions. The fact that an X is drawn to indicate a key can't be manipulated adds too much noise on dense data and is generally confusing. To combat that, I've changed it back to drawing key dots, but this time in gray ( the same color as disabled curves) and slightly smaller. -------- ~~While I think this is an improvement, there is something that needs to be discussed with the A&R module.~~ ~~Using the same gray as a disabled curve might be conceptually confusing. Locked keys are not disabled, the still work but you just can't move them. If people don't feel like that is an issue then the patch can be landed.~~ This was discussed in the [recent A&R](https://devtalk.blender.org/t/2023-09-07-animation-rigging-module-meeting/31022#patch-review-discussion-decision-time-5) module meeting and the decision was to keep the keys gray but also make them a bit smaller. ![image](/attachments/ab5579e5-e1dc-4bd1-b090-68374f06034a)

image.png

31 KiB

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-09-05 17:21:12 +02:00

Christoph Lendenfeld added 4 commits 2023-09-05 17:21:24 +02:00

c8160a78bc change color

265c5a12b4 Merge branch 'main' into ge_locked_keys

f65bcb0c0a Merge branch 'main' into ge_locked_keys

1bb3b64352 warning cleanup

Christoph Lendenfeld added this to the Animation & Rigging project 2023-09-05 17:21:37 +02:00