Fix #112028: Ctrl+Alt+Scroll not working on all selected objects #112095

Philipp Oeser · 2023-09-07T19:10:51+02:00

Philipp Oeser commented

2023-09-07 19:10:51 +02:00

Regression from c51467cd4c.

Above commit made the IS_ALLSELECT_EVENT more strict and now excluded
mousewheel events.

Refining IS_ALLSELECT_EVENT even further (to respect mousewheel there)
is unfortunately not easily possible since mouswheel events are excluded
from win->eventstate (could only be retrieved from win->event_queue
but that is not reliable either since it might have events that are not
handled yet).

Possible solutions:

Adding mouswheel events to win->eventstate

seemed to risky (could not forsee all possible consequences this would
have, e.g. double-click behavior)

Moving shortcuts for button array copy/paste from ALT to SHIFT

downside: breaking user habits
upside: additionally holding ALT could open the door for pasting on
all selected items
-- downside: without further work to make paste to multiple work better,
it would bring back #108096

So propose to do what was first suggested in #108270 as a third
solution:

Instead of refining IS_ALLSELECT_EVENT, bring it back to the state
before c51467cd4c (So Ctrl + Alt + V would still pass this test), but
specifically "filter out Ctrl + Alt + V right after in ui_apply_but().

Regression from c51467cd4c. Above commit made the IS_ALLSELECT_EVENT more strict and now excluded mousewheel events. Refining IS_ALLSELECT_EVENT even further (to respect mousewheel there) is unfortunately not easily possible since mouswheel events are excluded from `win->eventstate` (could only be retrieved from `win->event_queue` but that is not reliable either since it might have events that are not handled yet). Possible solutions: ___ Adding mouswheel events to `win->eventstate` - seemed to risky (could not forsee all possible consequences this would have, e.g. double-click behavior) ___ Moving shortcuts for button array copy/paste from ALT to SHIFT - downside: breaking user habits - upside: additionally holding ALT could open the door for pasting on all selected items -- downside: without further work to make paste to multiple work better, it would bring back #108096 ___ So propose to do what was first suggested in #108270 as a third solution: Instead of refining IS_ALLSELECT_EVENT, bring it back to the state before c51467cd4c (So `Ctrl + Alt + V` would still pass this test), but specifically "filter out `Ctrl + Alt + V` right after in ui_apply_but().

Philipp Oeser added 1 commit 2023-09-07 19:11:06 +02:00

9a9a84bb2d Fix #112028 : Ctrl+Alt+Scroll not working on all selected objects

Regression from c51467cd4c.

Above commit made the IS_ALLSELECT_EVENT more strict and now excluded
mousewheel events.

Refining IS_ALLSELECT_EVENT even further (to respect mousewheel there)
is unfortunately not easily possible since mouswheel events are excluded
from `win->eventstate` (could only be retrieved from `win->event_queue`
but that is not reliable either since it might have events that are not
handled yet).

Possible solutions:
___
Adding mouswheel events to `win->eventstate`
- seemed to risky (could not forsee all possible consequences this would
have, e.g. double-click behavior)
___
Moving shortcuts for button array copy/paste from ALT to SHIFT
- downside: breaking user habits
- upside: additionally holding ALT could open the door for pasting on
all selected items
-- downside: without further work to make paste to multiple work better,
it would bring back #108096
___

So propose to do what was first suggested in #108270 as a third
solution:

Instead of refining IS_ALLSELECT_EVENT, bring it back to the state
before c51467cd4c (So `Ctrl + Alt + V` would still pass this test), but
specifically "filter out `Ctrl + Alt + V` right after in ui_apply_but().

Philipp Oeser requested review from Campbell Barton 2023-09-07 19:11:30 +02:00

Philipp Oeser added this to the User Interface project 2023-09-07 19:11:35 +02:00

Philipp Oeser commented

2023-09-07 19:11:49 +02:00

Would need to go into 3.6 LTS

Campbell Barton approved these changes 2023-09-11 14:52:43 +02:00

Philipp Oeser merged commit 397a0a0e7e into main

2023-09-11 15:33:45 +02:00

Philipp Oeser deleted branch 112028_b

2023-09-11 15:33:46 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-11 15:33:48 +02:00