EEVEE-Next: Add back data passes UI and missing passes #112162

Miguel Pozo · 2023-09-08T21:00:52+02:00

Miguel Pozo commented

2023-09-08 21:00:52 +02:00

The VIEWLAYER_PT_eevee_next_layer_passes_data class name was re-used by mistake for Workbench Next in ba982119cd,
and the actual EEVEE Next class was then removed in 678dc456e3.

This adds back the UI as it was, and the missing passes (Vector and Position) it referenced.

Notes:

Position could be extrapolated from depth, at a precision loss cost.
Vector data format seems different than Cycles (in Cycles the .zw is inverted).
I don't understand why the Vector pass is disabled when motion blur is enabled.
That prevents compositing nodes from using motion vectors in combination with motion blur.

The `VIEWLAYER_PT_eevee_next_layer_passes_data` class name was re-used by mistake for Workbench Next in ba982119cd, and the actual EEVEE Next class was then removed in 678dc456e3. This adds back the UI as it was, and the missing passes (Vector and Position) it referenced. Notes: - Position could be extrapolated from depth, at a precision loss cost. - Vector data format seems different than Cycles (in Cycles the `.zw` is inverted). - I don't understand why the Vector pass is disabled when motion blur is enabled. That prevents compositing nodes from using motion vectors in combination with motion blur.

Miguel Pozo added the

Module

EEVEE & Viewport

label 2023-09-08 21:00:52 +02:00

Miguel Pozo added 3 commits 2023-09-08 21:01:02 +02:00

d371238740 Add layer passes UI back

The class name was re-used by mistake for Workbench Next in ba982119cd,
and the actual EEVEE Next class was incorrectly removed in 678dc456e3.

2ba03e6bd3 Enable Vector render pass

bbb03a3012 Add Position render pass

Miguel Pozo added this to the EEVEE & Viewport project 2023-09-08 21:01:26 +02:00

Miguel Pozo requested review from Clément Foucault 2023-09-08 21:01:32 +02:00

Miguel Pozo added 1 commit 2023-09-08 21:28:10 +02:00

505febdc1d Merge branch 'main' into pull-eeevee-next-missing-passes

Miguel Pozo added 1 commit 2023-09-08 21:38:02 +02:00

08897f3de0 Merge branch 'main' into pull-eeevee-next-missing-passes

Clément Foucault commented

2023-09-10 12:16:38 +02:00

Position could be extrapolated from depth, at a precision loss cost.

The precision loss is not acceptable here.

Vector data format seems different than Cycles (in Cycles the .zw is inverted).

It used to match. Maybe it was changed. Make sure viewport and render both works and match cycles.

Note that the final inversion for the renderpass is done in the film accumulation:

vector *= vec4(vec2(film_buf.render_extent), -vec2(film_buf.render_extent));

I don't understand why the Vector pass is disabled when motion blur is enabled.

Because if motion blur is enabled there is no right velocity for a pixel if the pixel has many object covering it. We follow the same practice as cycles, otherwise you could blur an already blurred image.

> Position could be extrapolated from depth, at a precision loss cost. The precision loss is not acceptable here. > Vector data format seems different than Cycles (in Cycles the .zw is inverted). It used to match. Maybe it was changed. Make sure viewport and render both works and match cycles. Note that the final inversion for the renderpass is done in the film accumulation: ``` vector *= vec4(vec2(film_buf.render_extent), -vec2(film_buf.render_extent)); ``` > I don't understand why the Vector pass is disabled when motion blur is enabled. Because if motion blur is enabled there is no right velocity for a pixel if the pixel has many object covering it. We follow the same practice as cycles, otherwise you could blur an already blurred image.

👍 1

Clément Foucault approved these changes 2023-09-10 12:17:03 +02:00

Miguel Pozo added 2 commits 2023-09-11 20:12:29 +02:00

f7afc25c88 Merge branch 'main' into pull-eeevee-next-missing-passes

c48fbfdd5b Match Cycles format

Miguel Pozo merged commit b3bf8a4e05 into main

2023-09-11 20:14:12 +02:00

Miguel Pozo referenced this issue from a commit

2023-09-11 20:14:12 +02:00

EEVEE-Next: Add back data passes UI and missing passes

Miguel Pozo deleted branch pull-eeevee-next-missing-passes

2023-09-11 20:14:14 +02:00