blender/blender
165
518
Fork 791
Code Issues 6.8k Pull Requests 942 Projects 21 Wiki Activity

WIP: Experiment: Geometry Nodes: support baking individual simulations #112179

Closed
Jacques Lucke wants to merge 51 commits from JacquesLucke/blender:simulation-bake-individual into main
pull from: JacquesLucke/blender:simulation-bake-individual
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 8 Commits 51 Files Changed 36 +1282 -293
Jacques Lucke commented 2023-09-09 12:46:41 +02:00
Member
Copy Link

This is a PR for my development branch. Some features might be split out into separate PRs after some testing.

Currently this contains:

  • Simulation panel in scene settings.
  • New "Play with Preroll" operator.
  • Add settings in the node properties of the simulation output node.
  • Support baking/deleting individual simulations.
  • Support custom path and frame range per simulation.
  • Improved timeline drawing (also see #112232). The solution right now has the following features:
    • Collapsed view of all individual simulation states.
    • Shows when all simulations are baked.
    • Shows when only some simulations are baked, but not all.
    • Shows which frames have valid/invalid simulation data.
    • When the all simulations are managed in sync, the visualization is the same as before (only missing frames are visualized differently now).
  • Initial (empty) new outliner display mode for "Bakes".
  • New simulation reset behavior (see #112154).

Settings for each simulation zone:
image

Scene simulation settings:
image

Play wit Preroll operator:
image

TODO:

  • Show simulation settings when simulation input or output node is selected.
This is a PR for my development branch. Some features might be split out into separate PRs after some testing. Currently this contains: * Simulation panel in scene settings. * New "Play with Preroll" operator. * Add settings in the node properties of the simulation output node. * Support baking/deleting individual simulations. * Support custom path and frame range per simulation. * Improved timeline drawing (also see #112232). The solution right now has the following features: * Collapsed view of all individual simulation states. * Shows when all simulations are baked. * Shows when only some simulations are baked, but not all. * Shows which frames have valid/invalid simulation data. * When the all simulations are managed in sync, the visualization is the same as before (only missing frames are visualized differently now). * Initial (empty) new outliner display mode for "Bakes". * New simulation reset behavior (see #112154). Settings for each simulation zone: ![image](/attachments/56239263-f9ff-48d3-b6e7-e33ce7a756de) Scene simulation settings: ![image](/attachments/d0c1593a-798a-4289-8dcd-7729bdf622c7) Play wit Preroll operator: ![image](/attachments/e0e98908-b2ab-45ba-8663-dc7ca7d4755f) TODO: * Show simulation settings when simulation input or output node is selected.
image.png
19 KiB
image.png
16 KiB
image.png
6.5 KiB
Jacques Lucke added 23 commits 2023-09-09 12:46:54 +02:00
Jacques Lucke added 4 commits 2023-09-11 13:39:24 +02:00
Jacques Lucke added 2 commits 2023-09-11 14:22:29 +02:00
Jacques Lucke added 6 commits 2023-09-12 17:07:27 +02:00
Jacques Lucke added 3 commits 2023-09-13 12:24:00 +02:00
Jacques Lucke added 1 commit 2023-09-13 12:58:06 +02:00
Jacques Lucke added 1 commit 2023-09-14 12:05:02 +02:00
Jacques Lucke added 2 commits 2023-09-14 15:52:03 +02:00
Jacques Lucke requested review from Simon Thommes 2023-09-16 14:02:42 +02:00
Jacques Lucke requested review from Hans Goudey 2023-09-16 14:02:42 +02:00
Simon Thommes requested changes 2023-09-18 18:05:08 +02:00
Simon Thommes left a comment
Member
Copy Link

  • Baking from the physics panel was still just use the scene range when I initially tested... not sure what caused this

  • instead on drawing two distinct lines I saw this when caching two different ranges. Not sure what this means:
    image

  • The Play with Preroll operator should never pause imo, but always just jump and play

  • We need to find a better UI solution for this button 😅

The way that the different settings and operators for baking are currently scattered around is worrying me a bit. We have settings in the scene properties, the physics properties and the node editor now. Either the scene panel or the physics panel should maybe move (?).

I'm lacking a bit the ability to inspect what range a simulation is now actually using. It's good that this is visible once the simulation is baked, but it would be good to see regardless of that, as depending on the toggles this could be either the scene range, the scene simulation range or the custom range.
would it be an option to draw the ranges of all simulations in the selection in the timeline as gray before they are baked/cached?

- Baking from the physics panel was still just use the scene range when I initially tested... not sure what caused this - instead on drawing two distinct lines I saw this when caching two different ranges. Not sure what this means: ![image](/attachments/3b9835c5-0014-4236-82a6-7554b59efb7f) - The `Play with Preroll` operator should never pause imo, but always just jump and play - We need to find a better UI solution for this button 😅 The way that the different settings and operators for baking are currently scattered around is worrying me a bit. We have settings in the scene properties, the physics properties and the node editor now. Either the scene panel or the physics panel should maybe move (?). I'm lacking a bit the ability to inspect what range a simulation is now actually using. It's good that this is visible once the simulation is baked, but it would be good to see regardless of that, as depending on the toggles this could be either the scene range, the scene simulation range or the custom range. would it be an option to draw the ranges of all simulations in the selection in the timeline as gray before they are baked/cached?
image.png
3.4 KiB
Hans Goudey commented 2023-09-18 19:18:15 +02:00
Member
Copy Link

Either the scene panel or the physics panel should maybe move (?).

The physics tab panel could move, since the future of the physics tab isn't clear with properties moving to (nodes) modifiers, and the simulation cache didn't really fit there in the first place.

>Either the scene panel or the physics panel should maybe move (?). The physics tab panel could move, since the future of the physics tab isn't clear with properties moving to (nodes) modifiers, and the simulation cache didn't really fit there in the first place.
Simon Thommes commented 2023-09-18 19:42:55 +02:00
Member
Copy Link

Either the scene panel or the physics panel should maybe move (?).

The physics tab panel could move, since the future of the physics tab isn't clear with properties moving to (nodes) modifiers, and the simulation cache didn't really fit there in the first place.

I generally agree, but it wouldn't fit to show buttons that are selection context dependent there... I guess once the outliner view is properly implemented it can just live there

> >Either the scene panel or the physics panel should maybe move (?). > > The physics tab panel could move, since the future of the physics tab isn't clear with properties moving to (nodes) modifiers, and the simulation cache didn't really fit there in the first place. I generally agree, but it wouldn't fit to show buttons that are selection context dependent there... I guess once the outliner view is properly implemented it can just live there
👍 1
Jacques Lucke added 3 commits 2023-09-20 11:37:39 +02:00
Jacques Lucke commented 2023-09-20 11:42:24 +02:00
Author
Member
Copy Link

Baking from the physics panel was still just use the scene range when I initially tested... not sure what caused this

My guess is that you forgot to enable the Simulation Range checkbox at first (at least that happened to me once).

instead on drawing two distinct lines I saw this when caching two different ranges. Not sure what this means

The thin opaque line is supposed to indicate that there is baked data on those frames (and consequently, the output might not be affected by changes to the input). On top of that it shows the valid/non-valid status of the non-baked simulations.

The Play with Preroll operator should never pause imo, but always just jump and play

I updated the behavior.

I'm lacking a bit the ability to inspect what range a simulation is now actually using.

Maybe something like this can help? It shows the frames that will be baked for this particular simulation.
image

would it be an option to draw the ranges of all simulations in the selection in the timeline as gray before they are baked/cached?

We probably could, but I won't implement that for now without having a better idea for how that relates to all the other information we want to show in the timeline.

> Baking from the physics panel was still just use the scene range when I initially tested... not sure what caused this My guess is that you forgot to enable the Simulation Range checkbox at first (at least that happened to me once). > instead on drawing two distinct lines I saw this when caching two different ranges. Not sure what this means The thin opaque line is supposed to indicate that there is baked data on those frames (and consequently, the output might not be affected by changes to the input). On top of that it shows the valid/non-valid status of the non-baked simulations. > The Play with Preroll operator should never pause imo, but always just jump and play I updated the behavior. > I'm lacking a bit the ability to inspect what range a simulation is now actually using. Maybe something like this can help? It shows the frames that will be baked for this particular simulation. ![image](/attachments/4ed7016c-3010-432e-b554-8a8c591d5712) > would it be an option to draw the ranges of all simulations in the selection in the timeline as gray before they are baked/cached? We probably could, but I won't implement that for now without having a better idea for how that relates to all the other information we want to show in the timeline.
image.png
12 KiB
Jacques Lucke requested review from Simon Thommes 2023-09-20 15:06:01 +02:00
Simon Thommes commented 2023-09-21 15:00:22 +02:00
Member
Copy Link

The thin opaque line is supposed to indicate that there is baked data on those frames (and consequently, the output might not be affected by changes to the input). On top of that it shows the valid/non-valid status of the non-baked simulations.

To me that wasn't clear looking at the lines, the thin opaque line is too subtle imo. It should at least be made thicker. Ideally we would display the invalidated cache in a different, more clear way in the first place, like with diagonal stripes (similar to caution tape). But that's a separate topic.

Maybe something like this can help? It shows the frames that will be baked for this particular simulation.

I'm personally not a fan of showing dynamic information like that inside of a button UI-wise. Not sure if there is something in the guidelines about this, but it feels wrong to me. I'd rather put it below, like you did once the bake exists. Adding this as strips in the timeline can then still be added at some point, once there is a design.

> The thin opaque line is supposed to indicate that there is baked data on those frames (and consequently, the output might not be affected by changes to the input). On top of that it shows the valid/non-valid status of the non-baked simulations. To me that wasn't clear looking at the lines, the thin opaque line is too subtle imo. It should at least be made thicker. Ideally we would display the invalidated cache in a different, more clear way in the first place, like with diagonal stripes (similar to caution tape). But that's a separate topic. > Maybe something like this can help? It shows the frames that will be baked for this particular simulation. I'm personally not a fan of showing dynamic information like that inside of a button UI-wise. Not sure if there is something in the guidelines about this, but it feels wrong to me. I'd rather put it below, like you did once the bake exists. Adding this as strips in the timeline can then still be added at some point, once there is a design.
Jacques Lucke added 4 commits 2023-09-21 15:37:22 +02:00
Jacques Lucke added 1 commit 2023-09-21 15:42:40 +02:00
Jacques Lucke commented 2023-09-21 15:43:10 +02:00
Author
Member
Copy Link

I updated the patch based on the two comments.

I updated the patch based on the two comments.
Jacques Lucke added 1 commit 2023-09-22 11:21:44 +02:00
Simon Thommes commented 2023-09-22 12:19:38 +02:00
Member
Copy Link

Changes look good to me, thanks

What's your current plan with the outliner display mode? Since bcon3 is getting close

Changes look good to me, thanks What's your current plan with the outliner display mode? Since bcon3 is getting close
Jacques Lucke commented 2023-09-22 12:36:35 +02:00
Author
Member
Copy Link

The feedback loops took a bit too long to be able to implement the outliner stuff unfortunately.

I'll create a separate patch for the stuff from this patch that is main-ready.

The feedback loops took a bit too long to be able to implement the outliner stuff unfortunately. I'll create a separate patch for the stuff from this patch that is `main`-ready.
👍 1
Jacques Lucke changed title from WIP: Geometry Nodes: support baking individual simulations to WIP: Experiment: Geometry Nodes: support baking individual simulations 2023-09-22 14:47:29 +02:00
Hans Goudey commented 2024-02-01 03:07:50 +01:00
Member
Copy Link

I guess this could be closed now, since the majority of the changes are merged?

I guess this could be closed now, since the majority of the changes are merged?
Jacques Lucke closed this pull request 2024-02-01 11:28:05 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Hans Goudey
Simon Thommes
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112179
No description provided.
Delete Branch "JacquesLucke/blender:simulation-bake-individual"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?