WIP: Add OSX support for Image copy/paste in the Image Editor osx-clipboard #112189

Jim-Snavely · 2023-09-09T22:30:26+02:00

Jim-Snavely commented

2023-09-09 22:30:26 +02:00

First-time contributor

override methods to SystemCocoa for image copy + paste
refactor drag and drop image handling so that the same code can be re-used
enable the image copy/paste operators for darwin

- override methods to SystemCocoa for image copy + paste - refactor drag and drop image handling so that the same code can be re-used - enable the image copy/paste operators for darwin See: #111404

Iliya Katushenock added this to the User Interface project 2023-09-09 22:32:33 +02:00

Iliya Katushenock changed title from ~~WIP: Add OSX support for Image copy/paste in the Image Editor osx-clipboard-111404~~ to WIP: Add OSX support for Image copy/paste in the Image Editor osx-clipboard

2023-09-09 22:32:46 +02:00

Jim-Snavely referenced this pull request

2023-09-09 22:35:04 +02:00

UI: Linux & Mac Support for Clipboard Copy/Paste Images #111404

Jim-Snavely force-pushed osx-clipboard-111404 from 71874ed175 to 5b50dc628b

2023-09-10 21:01:49 +02:00

Compare

Harley Acheson requested review from Harley Acheson 2023-09-10 21:15:44 +02:00

Harley Acheson commented

2023-09-10 21:25:48 +02:00

Although I have added myself as a reviewer, I don't compile for Mac so can't really test this.

Our very next step, after a cursory check, will be a review by a volunteer Mac dev. Then we'll make some package builds of this available for testing. Then we can have a core review.

Although I have added myself as a reviewer, I don't compile for Mac so can't really test this. Our very next step, after a cursory check, will be a review by a _volunteer_ Mac dev. Then we'll make some package builds of this available for testing. Then we can have a core review.

Harley Acheson commented

2023-09-11 18:43:46 +02:00

@ankitm

Do you have any time to check this out? I'm hoping for an initial cursory check of the code, a test to make sure it works as advertised. And if you think it looks plausible I can arrange to get some package builds out for user testing, all before getting a core review.

@Jim-Snavely

Similarly, is there are chance that you can take a look at the following? Again, a quick look at the code and then add a comment to the PR, especially a "Hey, we need this!" if warranted would be helpful. I don't think the PR is current compilable as it looks to have a conflict with main. But another set of eyes by a Mac user is appreciated.

#107267

@ankitm Do you have any time to check this out? I'm hoping for an initial cursory check of the code, a test to make sure it works as advertised. And if you think it looks plausible I can arrange to get some package builds out for user testing, all before getting a core review. @Jim-Snavely Similarly, is there are chance that you can take a look at the following? Again, a quick look at the code and then add a comment to the PR, especially a "Hey, we need this!" if warranted would be helpful. I don't think the PR is current compilable as it looks to have a conflict with main. But another set of eyes by a Mac user is appreciated. https://projects.blender.org/blender/blender/pulls/107267

Jim-Snavely commented

2023-09-11 23:42:18 +02:00

First-time contributor

Happy to look again, but I don't see a conflict with main, though it has become out-of-date since I last pulled upstream yesterday.

Is that what you're referring to @Harley ?

Happy to look again, but I don't see a conflict with main, though it has become out-of-date since I last pulled upstream yesterday. Is that what you're referring to @Harley ?

Jim-Snavely force-pushed osx-clipboard-111404 from 8c5abb41d4 to 5cb3397798

2023-09-11 23:46:45 +02:00

Compare

Jim-Snavely commented

2023-09-11 23:49:43 +02:00

First-time contributor

darn, I think I see what you'r referring to - not a git conflict but something else. I'll try to apply the changes fresh and see if it addresses it.

Harley Acheson commented

2023-09-11 23:54:30 +02:00

@Jim-Snavely - Is that what you're referring to Harley ?

No, I somehow missed adding the link I was talking about. I have edited my earlier comment to actually... include the thing. LOL.

In a nutshell I was hoping that Ankit could take a look at your PR and you at theirs. We just don't have many Mac developers so I am hoping to take advantage of you.

> @Jim-Snavely - Is that what you're referring to Harley ? No, I somehow missed adding the link I was talking about. I have edited my earlier comment to actually... include the thing. LOL. In a nutshell I was hoping that Ankit could take a look at your PR and you at theirs. We just don't have many Mac developers so I am hoping to take advantage of you.

Jim-Snavely commented

2023-09-12 00:14:00 +02:00

First-time contributor

LOL, I'm happy to be of service!

Ankit Meel commented

2023-09-13 06:17:13 +02:00

Did a cursory test and it works as advertised for PNG, JPEG and TIFF images when copied from open with preview > select all > copy

Though I don't think hasClipboardImage is working properly.. image paste button is enabled even if I copy a file from finder (PNG or TXT both). a file copied from Finder has multiple meanings.. https://apple.stackexchange.com/questions/180346/is-there-a-way-to-see-the-invisible-formatting-in-my-clipboard-and-or-create-the

Did a cursory test and it works as advertised for PNG, JPEG and TIFF images when copied from open with preview > select all > copy Though I don't think `hasClipboardImage` is working properly.. image paste button is enabled even if I copy a file from finder (PNG or TXT both). a file copied from Finder has multiple meanings.. https://apple.stackexchange.com/questions/180346/is-there-a-way-to-see-the-invisible-formatting-in-my-clipboard-and-or-create-the

Ankit Meel commented

2023-09-13 06:17:53 +02:00

For objc code, new code should use @autoreleasepool{} blocks instead of alloc and release

For objc code, new code should use `@autoreleasepool{}` blocks instead of alloc and release

Ankit Meel commented

2023-09-13 12:55:04 +02:00

a file copied from Finder has multiple meanings.

To be clear there's no need to paste the image if the copied item is a file from Finder or a full path to a file. Just that current code seems to be interpreting that path/file as image data and allowing user to paste some random stuff.

> a file copied from Finder has multiple meanings. To be clear there's no need to paste the image if the copied item is a file from Finder or a full path to a file. Just that current code seems to be interpreting that path/file as image data and allowing user to paste some random stuff.

This pull request has changes conflicting with the target branch.

intern/ghost/intern/GHOST_SystemCocoa.mm

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u osx-clipboard-111404:Jim-Snavely-osx-clipboard-111404

git checkout Jim-Snavely-osx-clipboard-111404

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Add OSX support for Image copy/paste in the Image Editor osx-clipboard #112189

Checkout