Fix: USD export: revert renaming active UV maps #112234

Merged
Michael Kowalski merged 1 commits from makowalski/blender:usd_revert_uv_map_rename into main 2023-09-11 16:54:06 +02:00

Pull request #109518 (commit cf5666345d) added logic to rename the
active UV map to "st". However, this behavior is currently breaking
UV Map node export to USD Preview Surface materials.

Specifically, UV Map nodes that reference the original active map name
do not get updated to use the new name "st", and the exported USD shader
references an invalid texture coordinate primvar.

This commit removes this logic for now. We should support such
renaming in the future, but the behavior should be extended to update
the relevant UV Map nodes with the new name. Also, we should consider
adding a USD export option to enable this feature.

Steps to Reproduce

Open the attached uvmap_shader_export_test.blend. Note that the material has a
UV Map shader that references "UVMap". Export the scene to USDA and open the
saved file in a text editor. Note that the shader "UV_Map" has "varname" input "UVMap",
which doesn't match the "st" texCoord2f primvar on the "Cube" mesh prim. Import the
USDA back into Blender and note that the texture does not display as expected.

Pull request #109518 (commit cf5666345d20) added logic to rename the active UV map to "st". However, this behavior is currently breaking UV Map node export to USD Preview Surface materials. Specifically, UV Map nodes that reference the original active map name do not get updated to use the new name "st", and the exported USD shader references an invalid texture coordinate primvar. This commit removes this logic for now. We should support such renaming in the future, but the behavior should be extended to update the relevant UV Map nodes with the new name. Also, we should consider adding a USD export option to enable this feature. ### Steps to Reproduce Open the attached `uvmap_shader_export_test.blend`. Note that the material has a `UV Map` shader that references "UVMap". Export the scene to USDA and open the saved file in a text editor. Note that the shader "UV_Map" has "varname" input "UVMap", which doesn't match the "st" `texCoord2f` primvar on the "Cube" mesh prim. Import the USDA back into Blender and note that the texture does not display as expected.
Michael Kowalski added 1 commit 2023-09-11 15:24:27 +02:00
Fix: USD export: revert renaming active UV maps.
All checks were successful
buildbot/vexp-code-patch-coordinator Build done.
080084bda4
Pull request #109518 (commit cf5666345d) added logic to rename the
active UV map to "st". However, this behavior is currently breaking
UV Map node export to USD Preview Surface materials.

Specifically, UV Map nodes that reference the original active map name
do not get updated to use the new name "st", and the exported USD shader
references an invalid texture coordinate primvar.

This commit removes this logic for now.  We should support such
renaming in the future, but the behavior should be extended to update
the relevant UV Map nodes with the new name.  Also, we should consider
adding a USD export option to enable this feature.
Iliya Katushenock requested review from Hans Goudey 2023-09-11 15:26:32 +02:00
Michael Kowalski added the
Interest
USD
Interest
Pipeline, Assets & IO
labels 2023-09-11 15:40:20 +02:00
Michael Kowalski added this to the USD project 2023-09-11 15:40:31 +02:00
Michael Kowalski requested review from Charles Wardlaw 2023-09-11 15:41:03 +02:00
Author
Member

@blender-bot build

@blender-bot build
Hans Goudey approved these changes 2023-09-11 16:16:22 +02:00
Michael Kowalski merged commit 678b827605 into main 2023-09-11 16:54:06 +02:00
Michael Kowalski deleted branch usd_revert_uv_map_rename 2023-09-11 16:54:07 +02:00

@makowalski and I had a nice chat about this-- it's currently blocking the UsdSkel work, and because of that I am fine adding this patch and bringing back the 'st' rename functionality in a future patch with an option to enable it.

@makowalski and I had a nice chat about this-- it's currently blocking the UsdSkel work, and because of that I am fine adding this patch and bringing back the 'st' rename functionality in a future patch with an option to enable it.
Charles Wardlaw approved these changes 2023-09-11 17:02:00 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:02 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:05 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:05 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:05 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:06 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:07 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:07 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:07 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:07 +02:00
Charles Wardlaw approved these changes 2023-09-11 17:02:07 +02:00
Bastien Montagne removed this from the USD project 2023-10-06 14:25:52 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112234
No description provided.