Fix: USD export: revert renaming active UV maps #112234

Michael Kowalski · 2023-09-11T15:24:13+02:00

Michael Kowalski commented

2023-09-11 15:24:13 +02:00

Pull request #109518 (commit cf5666345d) added logic to rename the
active UV map to "st". However, this behavior is currently breaking
UV Map node export to USD Preview Surface materials.

Specifically, UV Map nodes that reference the original active map name
do not get updated to use the new name "st", and the exported USD shader
references an invalid texture coordinate primvar.

This commit removes this logic for now. We should support such
renaming in the future, but the behavior should be extended to update
the relevant UV Map nodes with the new name. Also, we should consider
adding a USD export option to enable this feature.

Steps to Reproduce

Open the attached uvmap_shader_export_test.blend. Note that the material has a
UV Map shader that references "UVMap". Export the scene to USDA and open the
saved file in a text editor. Note that the shader "UV_Map" has "varname" input "UVMap",
which doesn't match the "st" texCoord2f primvar on the "Cube" mesh prim. Import the
USDA back into Blender and note that the texture does not display as expected.

Pull request #109518 (commit cf5666345d20) added logic to rename the active UV map to "st". However, this behavior is currently breaking UV Map node export to USD Preview Surface materials. Specifically, UV Map nodes that reference the original active map name do not get updated to use the new name "st", and the exported USD shader references an invalid texture coordinate primvar. This commit removes this logic for now. We should support such renaming in the future, but the behavior should be extended to update the relevant UV Map nodes with the new name. Also, we should consider adding a USD export option to enable this feature. ### Steps to Reproduce Open the attached `uvmap_shader_export_test.blend`. Note that the material has a `UV Map` shader that references "UVMap". Export the scene to USDA and open the saved file in a text editor. Note that the shader "UV_Map" has "varname" input "UVMap", which doesn't match the "st" `texCoord2f` primvar on the "Cube" mesh prim. Import the USDA back into Blender and note that the texture does not display as expected.

uvmap_shader_export_test.blend

1.2 MiB

Michael Kowalski added 1 commit 2023-09-11 15:24:27 +02:00

Fix: USD export: revert renaming active UV maps.

buildbot/vexp-code-patch-coordinator Build done.

Details

080084bda4

Pull request #109518 (commit cf5666345d) added logic to rename the
active UV map to "st". However, this behavior is currently breaking
UV Map node export to USD Preview Surface materials.

Specifically, UV Map nodes that reference the original active map name
do not get updated to use the new name "st", and the exported USD shader
references an invalid texture coordinate primvar.

This commit removes this logic for now.  We should support such
renaming in the future, but the behavior should be extended to update
the relevant UV Map nodes with the new name.  Also, we should consider
adding a USD export option to enable this feature.

Iliya Katushenock requested review from Hans Goudey 2023-09-11 15:26:32 +02:00

Michael Kowalski added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: USD export: revert renaming active UV maps #112234

Steps to Reproduce