USD: Fix for spammy attribute prints for unsupported and non-array attributes #112298

Merged

Michael Kowalski merged 1 commits from CharlesWardlaw/blender:bugfix/non_array_params into blender-v4.0-release

2023-10-24 15:31:19 +02:00

Charles Wardlaw commented

2023-09-12 21:09:59 +02:00

Member

This pull addresses the following issue: #112294 -- the file provided now only generates one error, which I believe is important to keep.

Added support for Point3* and Normal3* attributes as CD_PROP_FLOAT3
Caught the last two quaternion formats.
Silenced prints on quaternion and string formats, as they are known unsupported attributes.

This pull addresses the following issue: https://projects.blender.org/blender/blender/issues/112294 -- the file provided now only generates one error, which I believe is important to keep. - Added support for Point3* and Normal3* attributes as CD_PROP_FLOAT3 - Caught the last two quaternion formats. - Silenced prints on quaternion and string formats, as they are known unsupported attributes.

Charles Wardlaw added 1 commit 2023-09-12 21:10:11 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

c54f770eab Fix for spammy attribute prints for unsupported and non-array attributes. Added support for Point3* and Normal3*.

Michael Kowalski added the

Pipeline, Assets & IO

labels 2023-09-12 21:13:45 +02:00

Michael Kowalski added this to the USD project 2023-09-12 21:13:52 +02:00

Hans Goudey reviewed 2023-09-12 21:31:42 +02:00

source/blender/io/usd/intern/usd_reader_mesh.cc

						
				@ -912,0 +925,4 @@

				    if (ELEM(type,

				             pxr::SdfValueTypeNames->StringArray,

				             pxr::SdfValueTypeNames->QuatfArray,

				             pxr::SdfValueTypeNames->QuatdArray,

Hans Goudey commented

2023-09-12 21:31:40 +02:00

Member

It's unclear why quaternions have to be skipped here since they are handled in convert_usd_type_to_blender. Are you sure about that part?

It's unclear why quaternions have to be skipped here since they are handled in `convert_usd_type_to_blender`. Are you sure about that part?

Charles Wardlaw commented

2023-09-13 17:00:21 +02:00

Author

Member

Yes, because convert_usd_type_to_blender still returns them but not skipping them early keeps the printouts happening (indicating the types are unhandled).

Yes, because convert_usd_type_to_blender still returns them but not skipping them early keeps the printouts happening (indicating the types are unhandled).

CharlesWardlaw marked this conversation as resolved

Michael Kowalski commented

2023-09-13 04:52:19 +02:00

Member

@HooglyBoogly Since Blender has string attributes, would it make sense to also handle converting USD StringArrays? I can't remember if this was discussed in the original attribute import pull request.

@HooglyBoogly Since Blender has string attributes, would it make sense to also handle converting USD StringArrays? I can't remember if this was discussed in the original attribute import pull request.

Hans Goudey commented

2023-09-13 05:18:57 +02:00

Member

String attributes are very limited (as in, they have a length limit!) and not well supported right now, I think skipping those is the best approach for now.

String attributes are very limited (as in, they have a length limit!) and not well supported right now, I think skipping those is the best approach for now.

Charles Wardlaw commented

2023-09-13 17:02:00 +02:00

Author

Member

Just to note: string and quaternion attributes were skipped in the original patch due to them not having complete support; the returns are stub-ins for later. I would like to add them both once the support stabilizes in main, and that would be a symmetric import / export update in another patch.

Just to note: string and quaternion attributes were skipped in the original patch due to them not having complete support; the returns are stub-ins for later. I would like to add them both once the support stabilizes in main, and that would be a symmetric import / export update in another patch.

Hans Goudey commented

2023-09-13 17:07:20 +02:00

Member

If you'd like to do it later, that's totally fine too! Quaternion attributes are supported in main though.

If you'd like to do it later, that's totally fine too! Quaternion attributes are supported in main though.

Jesse Yurkovich commented

2023-10-15 21:26:43 +02:00

Member

@CharlesWardlaw It would be great to get this in for 4.0 as a fix if possible. Some USD files are printing hundreds of thousands of traces to console during import. I've tested this patch with the Moana Island Scene USD (v2.1) data set and can confirm it prevents all console spam except for a tiny few from Warning: Unsupported type double3[] for mesh data

@CharlesWardlaw It would be great to get this in for 4.0 as a fix if possible. Some USD files are printing hundreds of thousands of traces to console during import. I've tested this patch with the Moana Island Scene USD (v2.1) data set and can confirm it prevents all console spam except for a tiny few from `Warning: Unsupported type double3[] for mesh data`

Michael Kowalski commented

2023-10-19 23:18:46 +02:00

Member

@CharlesWardlaw I think this pull request should merge into the blender-v4.0-release branch and not into main.

@CharlesWardlaw I think this pull request should merge into the `blender-v4.0-release` branch and not into `main`.

Charles Wardlaw changed title from ~~USD: Fix for spammy attribute prints for unsupported and non-array attributes~~ to USD: Fix for spammy attribute prints for unsupported and non-array attributes

2023-10-20 15:44:29 +02:00

CharlesWardlaw changed target branch from main to blender-v4.0-release

2023-10-20 15:44:33 +02:00

Charles Wardlaw commented

2023-10-20 15:45:03 +02:00

Author

Member

@makowalski I modified the pull's target-- please let me know if you need anything further.

@makowalski I modified the pull's target-- please let me know if you need anything further.

Michael Kowalski commented

2023-10-23 16:14:54 +02:00

Member

@blender-bot build

@blender-bot build

Michael Kowalski approved these changes 2023-10-23 22:15:43 +02:00

Michael Kowalski merged commit 8caee74a11 into blender-v4.0-release

2023-10-24 15:31:19 +02:00

Michael Kowalski referenced this issue from a commit

2023-10-24 15:31:20 +02:00

Fix #112294: USD import: Fix spammy prints for unsupported and non-array attributes.

Bastien Montagne removed this from the USD project 2023-11-02 16:14:38 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112298

No description provided.