WIP: I18n: make favorites menu entry names translations depend on language #112327

Draft

Damien Picard wants to merge 2 commits from pioverfour/blender:dp_fix_110368 into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Damien Picard commented

2023-09-13 14:37:45 +02:00

Member

Buttons can be added to the quick favorites menu. The name of this
button is stored in a menu entry structure. Depending on the button
type (property, menu, operator), the name will be obtained in
different ways.

The correct name to store to is the untranslated one, because we want
to translate only when the menu is called. But in the case of
operators, the name copied to the struct was translated. This caused
the quick favorites menu to ignore language change and always display
the name as it was translated at the time of addition.

This commit adds a new function to get the raw, untranslated operator
name instead.

Fixes #110368: Favorites menu does not take into account language change

TODO

operators
operators with arguments (e.g. add a specific modifier),
menus
...?

Buttons can be added to the quick favorites menu. The name of this button is stored in a menu entry structure. Depending on the button type (property, menu, operator), the name will be obtained in different ways. The correct name to store to is the untranslated one, because we want to translate only when the menu is called. But in the case of operators, the name copied to the struct was translated. This caused the quick favorites menu to ignore language change and always display the name as it was translated at the time of addition. This commit adds a new function to get the raw, untranslated operator name instead. Fixes #110368: Favorites menu does not take into account language change **TODO** - [ ] operators - [ ] operators with arguments (e.g. add a specific modifier), - [ ] menus - [ ] ...?

Damien Picard added the

label 2023-09-13 14:37:45 +02:00

Damien Picard added 1 commit 2023-09-13 14:37:57 +02:00

d8590d693e I18n: make favorites menu entry names translations depend on language

Buttons can be added to the quick favorites menu. The name of this
button is stored in a menu entry structure. Depending on the button
type (property, menu, operator), the name will be obtained in
different ways.

The correct name to store to is the untranslated one, because we want
to translate only when the menu is called. But in the case of
operators, the name copied to the struct was translated. This caused
the quick favorites menu to ignore language change and always display
the name as it was translated at the time of addition.

This commit adds a new function to get the raw, untranslated operator
name instead.

Fixes #110368: Favorites menu does not take into account language change

TODO
- menus
- operators with attributes (e.g. add specific mod),
- ...?

Damien Picard referenced this pull request

2023-09-13 14:39:57 +02:00

Favorites menu does not take into account language change #110368

Hans Goudey reviewed 2023-09-13 19:28:35 +02:00

source/blender/windowmanager/intern/wm_operator_type.cc

						
				@ -586,0 +591,4 @@

				    name = ot->get_name(ot, properties);

				  }

				  return name.empty() ? std::string(RNA_struct_ui_name_raw(ot->srna)) : name;

Hans Goudey commented

2023-09-13 19:28:23 +02:00

Member

It might be nice to implement WM_operatortype_name in terms of WM_operatortype_name_raw, just like this:

return IFACE_(WM_operatortype_name_raw(ot, properties));

It might be nice to implement `WM_operatortype_name` in terms of `WM_operatortype_name_raw`, just like this: `return IFACE_(WM_operatortype_name_raw(ot, properties));`

Damien Picard commented

2023-09-19 13:57:56 +02:00

Author

Member

I tried doing that but actually it’s a bit more complex. A few operators get their name from a get_name callback which is supposed to return a translated name. 203e6e2b41 for instance changed things in that direction.

This means that if there is such a callback, WM_operatortype_name shouldn’t do any translation. It also means that currently, some operators cannot get an untranslated name at all. I’m not sure it’s worth it making get_name not translate right now as only a dozen operators use this, but still WM_operatortype_name should handle those cases.

I tried doing that but actually it’s a bit more complex. A few operators get their name from a `get_name` callback which is supposed to return a translated name. 203e6e2b41 for instance changed things in that direction. This means that if there is such a callback, `WM_operatortype_name` shouldn’t do any translation. It also means that currently, some operators cannot get an untranslated name at all. I’m not sure it’s worth it making `get_name` not translate right now as only a dozen operators use this, but still `WM_operatortype_name` should handle those cases.

Damien Picard added 1 commit 2023-09-27 21:11:38 +02:00

bec01540e8 Do not translate the op name if it comes from a get_name() callback

Damien Picard commented

2023-09-27 21:23:03 +02:00

Author

Member

I’m stuck with this because the translation is often based on uiButs’ drawstr, which is already translated. In order to get the untranslated string, it should be stored in the uiBut as well, but this feels redundant.

The alternative would be to store only the untranslated string, but I couldn’t find where this drawstr is updated from, as I assume it is when the user changes the UI language.

I’m stuck with this because [the translation is often based on](https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/interface/interface_context_menu.cc#L362) `uiBut`s’ `drawstr`, which is already translated. In order to get the untranslated string, it should be stored in the `uiBut` as well, but this feels redundant. The alternative would be to store only the untranslated string, but I couldn’t find where this `drawstr` is updated from, as I assume it is when the user changes the UI language.

This pull request is marked as a work in progress.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u dp_fix_110368:pioverfour-dp_fix_110368

git checkout pioverfour-dp_fix_110368

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112327

No description provided.