Fix: Simulation Nodes: assert when scrubbing the timeline with simulation (Blender 3.6) #112363

Jacques Lucke · 2023-09-14T10:01:35+02:00

Jacques Lucke commented

2023-09-14 10:01:35 +02:00

This issue only become visible in debug builds. I'm not aware of bad behavior that this caused in release builds. Fixing this is necessary to test #112110 in a debug build.

Jacques Lucke added 1 commit 2023-09-14 10:01:41 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

a6117f13bc fix

Jacques Lucke changed title from ~~Fix: Simulation Nodes: assert when scrubbing the timeline with simulation~~ to Fix: Simulation Nodes: assert when scrubbing the timeline with simulation (Blender 3.6)

2023-09-14 10:01:54 +02:00

Jacques Lucke commented

2023-09-14 10:02:18 +02:00

@blender-bot build

Jacques Lucke requested review from Philipp Oeser 2023-09-14 10:02:30 +02:00

Jacques Lucke requested review from Hans Goudey 2023-09-14 10:02:30 +02:00

Philipp Oeser approved these changes 2023-09-14 11:43:43 +02:00

Philipp Oeser left a comment

I can confirm the assert is gone (note though that I havent actually checked the logic, prefer if @HooglyBoogly reviews that)

Hans Goudey approved these changes 2023-09-14 14:11:18 +02:00

Hans Goudey left a comment

Takes a minute to understand the logic here, but it checks out :)

Jacques Lucke merged commit e55ca270e2 into blender-v3.6-release

2023-09-14 16:53:40 +02:00

Jacques Lucke referenced this issue from a commit

2023-09-14 16:53:41 +02:00

Fix: Simulation Nodes: assert when scrubbing the timeline with simulation

Jacques Lucke deleted branch fix-states-around-frame

2023-09-14 16:53:41 +02:00

MKRelax commented

2023-09-14 18:53:56 +02:00

First-time contributor

@JacquesLucke Unfortunately, this build still gives me the failed assertion:

BLI_assert failed: X:\Blender\3\blender\source\blender\blenkernel\intern\simulation_state.cc:153, get_state_at_frame_for_write(), at 'frame > states_at_frames_.last()->frame'

To reproduce:

take the default cube
add geometry nodes modifier to the cube
insert an empty simulation zone
scrub the timeline to the right (say from 0 to 100) and, keeping the mousekey pressed, then scrub backwards from 100 to 50.

On scrubbing backwards, this assertion fails consistently for me on different machines, debug build e55ca270e2 on Windows 10.

@JacquesLucke Unfortunately, this build still gives me the failed assertion: ``` BLI_assert failed: X:\Blender\3\blender\source\blender\blenkernel\intern\simulation_state.cc:153, get_state_at_frame_for_write(), at 'frame > states_at_frames_.last()->frame' ``` To reproduce: 1. take the default cube 2. add geometry nodes modifier to the cube 3. insert an empty simulation zone 4. scrub the timeline to the right (say from 0 to 100) and, keeping the mousekey pressed, then scrub backwards from 100 to 50. On scrubbing backwards, this assertion fails consistently for me on different machines, debug build `e55ca270e2` on Windows 10.

Jacques Lucke commented

2023-09-14 21:36:03 +02:00

@MKRelax I'm fairly certain that you tested the wrong commit. In e55ca270e2 there is no assert at simulation_state.cc:153. In the previous commit, there is an assert though.

@MKRelax I'm fairly certain that you tested the wrong commit. In e55ca270e2 there is no assert at `simulation_state.cc:153`. In the previous commit, there is an assert though.

MKRelax commented

2023-09-14 22:12:13 +02:00

First-time contributor

You're absolutely right. Apparently I was testing \build_windows_x64_vc16_Debug\bin\blender.exe from a previous build. Should have tested \build_windows_x64_vc16_Debug\bin\Debug\blender.exe.

The assert is indeed gone now. Sorry for the noise.

You're absolutely right. Apparently I was testing `\build_windows_x64_vc16_Debug\bin\blender.exe` from a previous build. Should have tested `\build_windows_x64_vc16_Debug\bin\Debug\blender.exe`. The assert is indeed gone now. Sorry for the noise.

MKRelax referenced this pull request

2023-09-15 10:14:27 +02:00

Fix #111978: Passthrough if there is no simulation state (backport to 3.6) #112110

Sign in to join this conversation.

No reviewers