WIP: Fix #112395: Transform with Proportional Influence in Graph editor only works horizontally #112401

Draft
Germano Cavalcante wants to merge 1 commits from mano-wii/blender:transform_graph_PET into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Support proportional editing in the Graph editor in both the X and Y
directions.


GIF.gif

This problem has already been reported other times (See for example #80716).

There is also an alternative solution that involves scaling the circle that indicates proportional transformation in the Y direction (https://archive.blender.org/developer/D9023).

The solution proposed here is to support the influence as indicated in the circle (either in the X or Y direction).

To address this, the distance calculation originally implemented in transform_convert_graph.cc has been removed. This previous calculation was not only inefficient, having a time complexity of O(n^2), but it also only considered the X direction.
The generic solution for most transform types is now used instead.

Additionally, a value for t->aspect had to be obtained and used as a Y-factor to calculate distances as they are visually perceived. But note that, if navigation during transformation is supported in the Graph editor, these distances with aspect cannot be updated.

So in summary.
Benefits:

  • The drawing of the Porportional Influence circle better matches what is transformed
  • Avoids unintentional or non-visual transformations (if the points are outside the region).
  • Code removal and optimization.

Disadvantages:

  • Some users may prefer the previous behavior.
  • Since the aspect is used to calculate distances, if someday navigation while transforming is supported in the Graph editor and this changes the aspect, this cannot be reflected in the distances calculated for Proportional Influence.

Alternative:

  • Support Proportional Influence in the Y direction, but always use the aspect [1, 1]. The drawing of the circle would change depending on the aspect.
Support proportional editing in the Graph editor in both the X and Y directions. --- ![GIF.gif](attachments/2ab8b791-6e84-45be-84d1-9d8b4f2aad52) This problem has already been reported other times (See for example #80716). There is also an alternative solution that involves scaling the circle that indicates proportional transformation in the Y direction (https://archive.blender.org/developer/D9023). The solution proposed here is to support the influence as indicated in the circle (either in the X or Y direction). To address this, the distance calculation originally implemented in `transform_convert_graph.cc` has been removed. This previous calculation was not only inefficient, having a time complexity of O(n^2), but it also only considered the X direction. The generic solution for most transform types is now used instead. Additionally, a value for `t->aspect` had to be obtained and used as a Y-factor to calculate distances as they are visually perceived. But note that, if navigation during transformation is supported in the Graph editor, these distances with aspect cannot be updated. So in summary. Benefits: - The drawing of the Porportional Influence circle better matches what is transformed - Avoids unintentional or non-visual transformations (if the points are outside the region). - Code removal and optimization. Disadvantages: - Some users may prefer the previous behavior. - Since the aspect is used to calculate distances, if someday navigation while transforming is supported in the Graph editor and this changes the aspect, this cannot be reflected in the distances calculated for Proportional Influence. Alternative: - Support Proportional Influence in the Y direction, but always use the aspect [1, 1]. The drawing of the circle would change depending on the aspect.
149 KiB
Germano Cavalcante added the
Module
Animation & Rigging
label 2023-09-15 04:54:36 +02:00
Germano Cavalcante added 1 commit 2023-09-15 04:54:49 +02:00
5998e0d847 Fix #112395: Transform with Proportional Influence in Graph editor only works horizontally
Support proportional editing in the Graph editor in both the X and Y
directions.

---
This problem has already been reported other times (See for example #80716).

There is also an alternative solution that involves scaling the circle that indicates proportional transformation in the Y direction (https://archive.blender.org/developer/D9023).

The solution proposed here is to support the influence as indicated in the circle (either in the X or Y direction).

To address this, the distance calculation originally implemented in `transform_convert_graph.cc` has been removed. This previous calculation was not only inefficient, having a time complexity of O(n^2), but it also only considered the X direction.

Additionally, a value for `t->aspect` had to be obtained and used as a Y-factor to calculate distances as they are visually perceived. But note that, if navigation during transformation is supported in the Graph editor, these distances with aspect cannot be updated.

So in summary.
Benefits:
- The drawing of the Porportional Influence circle better matches what is transformed
- Avoids unintentional or non-visual transformations (if the points are outside the region).
- Code removal and optimization.

Disadvantages:
- Some users may prefer the previous behavior.
- Since the aspect is used to calculate distances, if someday navigation while transforming is supported in the Graph editor and this changes the aspect, this cannot be reflected in the distances calculated for Proportional Influence.

Alternative:
- Support Proportional Influence in the Y direction, but always use the aspect [1, 1]. The drawing of the circle would change depending on the aspect.
Germano Cavalcante requested review from Sybren A. Stüvel 2023-09-15 04:55:01 +02:00

Some users may prefer the previous behavior.

I can certainly see a use case for limiting the proportional editing over time, ignoring the keyframe values. I also agree that the circle is not the right visual representation for this, but to me that's not enough to warrant the removal of this particular functionality.

Before introducing "actual circle mode" that behaves as one would expect, I think it's good to update the "proportional only over time" visualisation (and maybe also naming) so that it's no longer confusing.

> Some users may prefer the previous behavior. I can certainly see a use case for limiting the proportional editing over time, ignoring the keyframe values. I also agree that the circle is not the right visual representation for this, but to me that's not enough to warrant the removal of this particular functionality. Before introducing "actual circle mode" that behaves as one would expect, I think it's good to update the "proportional only over time" visualisation (and maybe also naming) so that it's no longer confusing.
Germano Cavalcante changed title from Fix #112395: Transform with Proportional Influence in Graph editor only works horizontally to WIP: Fix #112395: Transform with Proportional Influence in Graph editor only works horizontally 2023-09-28 19:55:57 +02:00
This pull request has changes conflicting with the target branch.
  • source/blender/editors/transform/transform_convert.cc
  • source/blender/editors/transform/transform_convert_graph.cc

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u transform_graph_PET:mano-wii-transform_graph_PET
git checkout mano-wii-transform_graph_PET
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112401
No description provided.