Fix: remove non-functional choice of weightpaint mode from lattices #112411

Merged
Member

Lattices would give the choice of going to weightpaint mode (which would
fail immediately because of vwpaint::mode_toggle_poll_test) because it
was marked as a compatible mode in ED_object_mode_compat_test.

I dont think this was ever supported properly, why this was marked as a
compatible mode is unknown (I stopped tracing git history at
deebf4f8f0).

Even if it was at some point, weightpaint mode nowadays is totally
depended on Mesh, so seems better to just remove it from Lattices.

Lattices would give the choice of going to weightpaint mode (which would fail immediately because of `vwpaint::mode_toggle_poll_test`) because it was marked as a compatible mode in `ED_object_mode_compat_test`. I dont think this was ever supported properly, why this was marked as a compatible mode is unknown (I stopped tracing git history at deebf4f8f0d7). Even if it was at some point, weightpaint mode nowadays is totally depended on Mesh, so seems better to just remove it from Lattices.
Philipp Oeser added this to the Animation & Rigging project 2023-09-15 13:16:25 +02:00
Philipp Oeser added the
Interest
Sculpt, Paint & Texture
label 2023-09-15 13:16:40 +02:00
Philipp Oeser requested review from Sybren A. Stüvel 2023-09-15 13:16:54 +02:00
Philipp Oeser requested review from Campbell Barton 2023-09-15 13:17:00 +02:00
Sybren A. Stüvel added the
Module
Animation & Rigging
label 2023-09-28 12:18:48 +02:00
Sybren A. Stüvel approved these changes 2023-09-28 12:38:53 +02:00
Sybren A. Stüvel left a comment
Member

I dont think this was ever supported properly, why this was marked as a
compatible mode is unknown (I stopped tracing git history at
deebf4f8f0).

That's some archaeology!

Even if it was at some point, weightpaint mode nowadays is totally
depended on Mesh, so seems better to just remove it from Lattices.

Agreed.

This PR also removes edit mode compatibility from point clouds. That's unexpected, given that point clouds aren't mentioned in the PR title or description. I think it's better to exclude that change from this commit, and commit it separately.

Before landing, please make sure to target the release branch.

Approving for the actually described changes, but please remove the pointcloud part before landing.

> I dont think this was ever supported properly, why this was marked as a > compatible mode is unknown (I stopped tracing git history at > deebf4f8f0d7). That's some archaeology! > Even if it was at some point, weightpaint mode nowadays is totally > depended on Mesh, so seems better to just remove it from Lattices. Agreed. This PR also removes edit mode compatibility from point clouds. That's unexpected, given that point clouds aren't mentioned in the PR title or description. I think it's better to exclude that change from this commit, and commit it separately. Before landing, please make sure to target the release branch. Approving for the actually described changes, but please remove the pointcloud part before landing.
Philipp Oeser changed title from Fix: remove non-functional choice of weightpaint mode from lattices to Fix: remove non-functional choice of weightpaint mode from lattices 2023-09-28 13:24:32 +02:00
lichtwerk changed target branch from main to blender-v4.0-release 2023-09-28 13:24:36 +02:00
Philipp Oeser force-pushed lattice_weightpaint_mode_compat_removal from 06b16ab074 to a56ea1fe8e 2023-09-28 13:39:21 +02:00 Compare
Author
Member

This PR also removes edit mode compatibility from point clouds. That's unexpected, given that point clouds aren't mentioned in the PR title or description. I think it's better to exclude that change from this commit, and commit it separately.

It doesnt remove edit mode compatibility from point clouds, it is now:

case OB_CURVES_LEGACY:
case OB_SURF:
case OB_FONT:
case OB_MBALL:
case OB_POINTCLOUD:
case OB_LATTICE:
  if (mode & OB_MODE_EDIT) {
    return true;
  }
  break;

Before landing, please make sure to target the release branch.

Done

> This PR also removes edit mode compatibility from point clouds. That's unexpected, given that point clouds aren't mentioned in the PR title or description. I think it's better to exclude that change from this commit, and commit it separately. It doesnt remove edit mode compatibility from point clouds, it is now: ``` case OB_CURVES_LEGACY: case OB_SURF: case OB_FONT: case OB_MBALL: case OB_POINTCLOUD: case OB_LATTICE: if (mode & OB_MODE_EDIT) { return true; } break; ``` > Before landing, please make sure to target the release branch. Done

It doesnt remove edit mode compatibility from point clouds, it is now:

doh!

> It doesnt remove edit mode compatibility from point clouds, it is now: doh!
Philipp Oeser merged commit cd557f0636 into blender-v4.0-release 2023-09-28 15:44:00 +02:00
Philipp Oeser deleted branch lattice_weightpaint_mode_compat_removal 2023-09-28 15:44:01 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112411
No description provided.