Allow setting weights (Ctrl+X) without paintmask enabled #112413

Merged

Philipp Oeser merged 1 commits from lichtwerk/blender:set_weight_without_paintmask into main

2023-09-27 09:13:13 +02:00

Philipp Oeser commented

2023-09-15 13:26:17 +02:00

Member

Currently if there is no selection mode enabled the operator is disabled and greyed
out in the menu. The shortcut doesn't do anything, which can be unexpected and jarring.

With this PR the operator will work when no selection mode is enabled and in that case
fill the entire mesh using the Weight from the active tool.
This is then consistent with vertex paint mode and the "Set Vertex Color" operator.

So now remove the overly-strict mask_paint_poll poll (and replace with
more appropriate weight_paint_mode_poll).

NOTE: mask_paint_poll is now unused, could be removed

Currently if there is no selection mode enabled the operator is disabled and greyed out in the menu. The shortcut doesn't do anything, which can be unexpected and jarring. With this PR the operator will work when no selection mode is enabled and in that case fill the entire mesh using the Weight from the active tool. This is then consistent with vertex paint mode and the "Set Vertex Color" operator. So now remove the overly-strict `mask_paint_poll` poll (and replace with more appropriate `weight_paint_mode_poll`). NOTE: `mask_paint_poll` is now unused, could be removed

Philipp Oeser added 1 commit 2023-09-15 13:26:22 +02:00

0154037851 Allow setting weights (Ctrl+X) without paintmask enabled

Compared to setting vertex colors with Ctrl+X (which does not have the
requirement of having vertex/face mask enabled) this was inconsistent.
It is also not needed to check if paintmask is enabled, the code checks
for this just fine.

So now remove the overly-strict `mask_paint_poll` poll (and replace with
more appropriate `weight_paint_mode_poll`).

NOTE: `mask_paint_poll` is now unused, could be removed

Philipp Oeser added this to the Animation & Rigging project 2023-09-15 13:26:31 +02:00

Philipp Oeser added the

Sculpt, Paint & Texture

label 2023-09-15 13:26:36 +02:00

Philipp Oeser requested review from Sybren A. Stüvel 2023-09-15 13:26:47 +02:00

Philipp Oeser requested review from Julien Kaspar 2023-09-15 13:26:53 +02:00

Julien Kaspar approved these changes 2023-09-15 15:07:42 +02:00

Julien Kaspar left a comment

Member

Yes I think this is for the best for consistency, even if it would be rarely used.

Yes I think this is for the best for consistency, even if it would be rarely used.

Sybren A. Stüvel commented

2023-09-25 15:45:26 +02:00

Member

As someone who doesn't do weightpainting on a daily basis, I'm a bit confused as to what this changes in practice.

As someone who doesn't do weightpainting on a daily basis, I'm a bit confused as to what this changes in practice.

Julien Kaspar commented

2023-09-26 10:52:28 +02:00

Member

This change was suggested from the rigging module artists when the keymap changes were introduced.
I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency.

I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut.

This change was suggested from the rigging module artists when the keymap changes were introduced. I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency. I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut.

Sybren A. Stüvel commented

2023-09-26 11:43:51 +02:00

Member

This change was suggested from the rigging module artists when the keymap changes were introduced.

For tracability of such decisions, please include information like this in the PR description. A link to the relevant meeting notes / devtalk thread would also be good. Right now, for me, this PR came out of the blue, and it's hard to do a review like that.

Please also refer to https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Pull_Request, as this PR description doesn't include much info about which problem is being solved, or why this is the best way to solve this.

I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency.

What would it do when there is no selection?

I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut.

I'm still confused as to what the exact problem is that this PR addresses. Or what the practical impact is of this change.

> This change was suggested from the rigging module artists when the keymap changes were introduced. For tracability of such decisions, please include information like this in the PR description. A link to the relevant meeting notes / devtalk thread would also be good. Right now, for me, this PR came out of the blue, and it's hard to do a review like that. Please also refer to https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Pull_Request, as this PR description doesn't include much info about which problem is being solved, or why this is the best way to solve this. > I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency. What would it do when there is no selection? > I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut. I'm still confused as to what the exact problem is that this PR addresses. Or what the practical impact is of this change.

Philipp Oeser commented

2023-09-26 12:14:45 +02:00

Author

Member

This change was suggested from the rigging module artists when the keymap changes were introduced.

For tracability of such decisions, please include information like this in the PR description. A link to the relevant meeting notes / devtalk thread would also be good. Right now, for me, this PR came out of the blue, and it's hard to do a review like that.

I wasnt aware this was "officially" decided actually, so it actually came "out of the blue" -- from personal observation.
Will try to dig up meeting notes (or do you have a link @JulienKaspar ?)

Please also refer to https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Pull_Request, as this PR description doesn't include much info about which problem is being solved, or why this is the best way to solve this.

I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency.

What would it do when there is no selection?

It does it on the entire mesh (just like if you would enable paint mask and select everything -- or as @JulienKaspar described "Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut."

I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut.

I'm still confused as to what the exact problem is that this PR addresses. Or what the practical impact is of this change.

Well, it makes it consistent with vertexpaint and saves you a couple of clicks in weightpaint

> > This change was suggested from the rigging module artists when the keymap changes were introduced. > > For tracability of such decisions, please include information like this in the PR description. A link to the relevant meeting notes / devtalk thread would also be good. Right now, for me, this PR came out of the blue, and it's hard to do a review like that. > I wasnt aware this was "officially" decided actually, so it actually came "out of the blue" -- from personal observation. Will try to dig up meeting notes (or do you have a link @JulienKaspar ?) > Please also refer to https://wiki.blender.org/wiki/Process/Contributing_Code#Ingredients_of_a_Pull_Request, as this PR description doesn't include much info about which problem is being solved, or why this is the best way to solve this. > > > I'm unsure if riggers would make heavy use of this operator when there's no selection but it is nice to allow it for consistency. > > What would it do when there is no selection? > It does it on the entire mesh (just like if you would enable paint mask and select everything -- or as @JulienKaspar described "Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut." > > I can personally see one use case: Instead of selecting everything in edit mode and using the "Assign" button (in Properties -> Object Data -> Vertex Groups), this can now directly be done in Weight Paint mode with this operator shortcut. > > I'm still confused as to what the exact problem is that this PR addresses. Or what the practical impact is of this change. > Well, it makes it consistent with vertexpaint and saves you a couple of clicks in weightpaint

Julien Kaspar commented

2023-09-26 12:16:27 +02:00

Member

Next time I'll document the request in meeting notes or somewhere traceable. Instead it was done in the module chat and hard to trace back.

For the missing info:

Currently if there is no selection mode enabled the operator is disabled and greyed out in the menu. The shortcut doesn't do anything, which can be unexpected and jarring.

With this PR the operator will work when no selection mode is enabled and in that case fill the entire mesh using the Weight from the active tool.
This is then consistent with vertex paint mode and the "Set Vertex Color" operator.

Next time I'll document the request in meeting notes or somewhere traceable. Instead it was done in the module chat and hard to trace back. For the missing info: Currently if there is no selection mode enabled the operator is disabled and greyed out in the menu. The shortcut doesn't do anything, which can be unexpected and jarring. With this PR the operator will work when no selection mode is enabled and in that case fill the entire mesh using the Weight from the active tool. This is then consistent with vertex paint mode and the "Set Vertex Color" operator.

Sybren A. Stüvel commented

2023-09-26 13:54:11 +02:00

Member

Thanks for the clarification, this helps.

I think the UI module should make a decision on this. There are other operators that silently do nothing when nothing is selected; the 'Symmetrize Armature' was discussed in #107902 (comment). Blender is inconsistent here, where some operators are disabled (like 'Set Weights') and some do nothing (like 'Delete' in mesh edit mode, or 'Delete Objects', which is even more insulting because it does ask you to confirm before doing nothing).

For the Symmetrize Armature we decided that it's likely best to keep it working, but emit a warning when there was nothing selected. I personally think that's the right approach, but as I said, it would be better to have a more Blender-wide approach to this (or maybe there is already and I'm just not aware).

Thanks for the clarification, this helps. I think the UI module should make a decision on this. There are other operators that silently do nothing when nothing is selected; the 'Symmetrize Armature' was discussed in https://projects.blender.org/blender/blender/pulls/107902#issuecomment-964704. Blender is inconsistent here, where some operators are disabled (like 'Set Weights') and some do nothing (like 'Delete' in mesh edit mode, or 'Delete Objects', which is even more insulting because it does ask you to confirm before doing nothing). For the Symmetrize Armature we decided that it's likely best to keep it working, but emit a warning when there was nothing selected. I personally think that's the right approach, but as I said, it would be better to have a more Blender-wide approach to this (or maybe there is already and I'm just not aware).

Philipp Oeser commented

2023-09-26 14:36:01 +02:00

Author

Member

Thanks for the clarification, this helps.

I think the UI module should make a decision on this. There are other operators that silently do nothing when nothing is selected; the 'Symmetrize Armature' was discussed in #107902 (comment). Blender is inconsistent here, where some operators are disabled (like 'Set Weights') and some do nothing (like 'Delete' in mesh edit mode, or 'Delete Objects', which is even more insulting because it does ask you to confirm before doing nothing).

For the Symmetrize Armature we decided that it's likely best to keep it working, but emit a warning when there was nothing selected. I personally think that's the right approach, but as I said, it would be better to have a more Blender-wide approach to this (or maybe there is already and I'm just not aware).

I think comparing Set Weights to the other operators you mention is misleading since objectmode / editmode /posemode do not require to enable something to make a selection to begin with (enable paintmask).
You can do pretty much everything in the Weights menu without having anything selected (except for Set Weights) as well as using the tools/brushes which also dont require a selection.

> Thanks for the clarification, this helps. > > I think the UI module should make a decision on this. There are other operators that silently do nothing when nothing is selected; the 'Symmetrize Armature' was discussed in https://projects.blender.org/blender/blender/pulls/107902#issuecomment-964704. Blender is inconsistent here, where some operators are disabled (like 'Set Weights') and some do nothing (like 'Delete' in mesh edit mode, or 'Delete Objects', which is even more insulting because it does ask you to confirm before doing nothing). > > For the Symmetrize Armature we decided that it's likely best to keep it working, but emit a warning when there was nothing selected. I personally think that's the right approach, but as I said, it would be better to have a more Blender-wide approach to this (or maybe there is already and I'm just not aware). > I think comparing `Set Weights` to the other operators you mention is misleading since objectmode / editmode /posemode do not require to `enable` something to make a selection to begin with (enable paintmask). You can do pretty much everything in the `Weights` menu without having anything selected (except for `Set Weights`) as well as using the tools/brushes which also dont require a selection.

Sybren A. Stüvel approved these changes 2023-09-26 18:19:49 +02:00

Sybren A. Stüvel left a comment

Member

Good point!

Good point!

Philipp Oeser merged commit 0b1d2d63fe into main

2023-09-27 09:13:13 +02:00

Philipp Oeser referenced this issue from a commit

2023-09-27 09:13:13 +02:00

Allow setting weights (Ctrl+X) without paintmask enabled

Philipp Oeser deleted branch set_weight_without_paintmask

2023-09-27 09:13:14 +02:00

Nate Rupsis referenced this issue from a commit

2023-09-28 20:19:25 +02:00

Allow setting weights (Ctrl+X) without paintmask enabled

Colin Basnett referenced this issue from a commit

2023-10-08 23:38:51 +02:00

Allow setting weights (Ctrl+X) without paintmask enabled

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112413

No description provided.