Vulkan: Fix Namespace Collision Between Shader Resources #112511

Merged

Jeroen Bakker merged 1 commits from Jeroen-Bakker/blender:vulkan/shader-resource-collision into main

2023-09-18 13:41:58 +02:00

Jeroen Bakker commented

2023-09-18 12:31:39 +02:00

Member

Previous implemetation had some limitations that were not working
for complex shaders. This limitations included:

All bindings should be bound to a location < 16.
Collision could happen when image locations where read that
overlapped with the texture locations.

This PR replaces the fixed binding locations with a dynamic vector.
When allocating locations for images the image offset is determined
that it is always clear if the requested locations is already
offsetted or not. This is done by ensuring the offset to larger than
the max slot of samplers, but also of image slots.

When using Eevee-next materials the slot numbers can be very high
as the location of the first material texture is set to
GPU_max_textures_frag() On current NVIDIA drivers this number is
set to 1K. Images are stored after the textures slots upwards.

In the future driver could set this to MAX_INT which will not work
with the new implementation. This isn't the case at this moment
and perhaps also not realistic. We don't check for this situation yet.

Previous implemetation had some limitations that were not working for complex shaders. This limitations included: * All bindings should be bound to a location < 16. * Collision could happen when image locations where read that overlapped with the texture locations. This PR replaces the fixed binding locations with a dynamic vector. When allocating locations for images the image offset is determined that it is always clear if the requested locations is already offsetted or not. This is done by ensuring the offset to larger than the max slot of samplers, but also of image slots. When using Eevee-next materials the slot numbers can be very high as the location of the first material texture is set to `GPU_max_textures_frag()` On current NVIDIA drivers this number is set to 1K. Images are stored after the textures slots upwards. In the future driver could set this to MAX_INT which will not work with the new implementation. This isn't the case at this moment and perhaps also not realistic. We don't check for this situation yet.

Jeroen Bakker added this to the 4.0 milestone 2023-09-18 12:31:39 +02:00

Jeroen Bakker added the

label 2023-09-18 12:31:39 +02:00

Jeroen Bakker self-assigned this 2023-09-18 12:31:39 +02:00

Jeroen Bakker added 1 commit 2023-09-18 12:31:50 +02:00

ae56788d42 Vulkan: Fix Namespace Collision Between Shader Resources

Previous implemetation had some limitations that were not working
for complex shaders. This limitations included:

* All bindings should be bound to a location < 16.
* Collision could happen when image locations where read that
  overlapped with the texture locations.

This PR replaces the fixed binding locations with a dynamic vector.
When allocating locations for images the image offset is determined
that it is always clear if the requested locations is already
offsetted or not. This is done by ensuring the offset to larger than
the max slot of samplers, but also of image slots.

When using Eevee-next materials the slot numbers can be very high
as the location of the first material texture is set to
`GPU_max_textures_frag()` On current NVIDIA drivers this number is
set to 1K. Images are stored after the textures slots upwards.

In the future driver could set this to MAX_INT which will not work
with the new implementation. This isn't the case at this moment
and perhaps also not realistic. We don't check for this situation yet.

Jeroen Bakker added this to the EEVEE & Viewport project 2023-09-18 13:41:41 +02:00

Jeroen Bakker merged commit 0e47a13e3e into main

2023-09-18 13:41:58 +02:00

Jeroen Bakker referenced this issue from a commit

2023-09-18 13:41:59 +02:00

Vulkan: Fix Namespace Collision Between Shader Resources

MohammadHossein Jamshidi referenced this issue from a commit

2023-09-21 22:46:58 +02:00

Vulkan: Fix Namespace Collision Between Shader Resources

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112511

No description provided.