Nodes: Rename ui_items property to items_tree #112527

Looks like renames are missing in `geometry_nodes.py` and `node.py`. Whichever addons have already been updated for the new API should probably be changed too. At least this should be a simple rename.

Hans Goudey changed title from ~~Fix #112523: Renamed the `ui_items` property to `items_tree`~~ to Fix #112523: Rename `ui_items` property to `items_tree`

2023-09-18 16:05:11 +02:00

Hans Goudey changed title from ~~Fix #112523: Rename `ui_items` property to `items_tree`~~ to Nodes: Rename `ui_items` property to `items_tree`

2023-09-18 16:05:24 +02:00

Lukas Tönne commented

2023-09-18 16:23:10 +02:00

Looks like renames are missing in geometry_nodes.py and node.py.

Thanks for checking, good catch. I didn't notice i had a search file pattern set.

Whichever addons have already been updated for the new API should probably be changed too.

There don't seem to be any addons already using ui_items. I did a pass over addons a while ago and there are only a handful that actually access the old inputs/outputs lists of NodeTree and would need to be changed to interface.items_tree.

> Looks like renames are missing in geometry_nodes.py and node.py. Thanks for checking, good catch. I didn't notice i had a search file pattern set. > Whichever addons have already been updated for the new API should probably be changed too. There don't seem to be any addons already using `ui_items`. I did a pass over addons a while ago and there are only a handful that actually access the old `inputs`/`outputs` lists of `NodeTree` and would need to be changed to `interface.items_tree`.

Lukas Tönne added 1 commit 2023-09-18 16:24:18 +02:00

Replace uses of ui_items in scripts.

buildbot/vexp-code-patch-coordinator Build done.

Details

9aeabfbe95

Lukas Tönne commented

2023-09-18 16:24:35 +02:00

@blender-bot build

Hans Goudey commented

2023-09-18 16:29:21 +02:00

There don't seem to be any addons already using ui_items

>There don't seem to be any addons already using ui_items ![image](/attachments/8792f361-dcf1-4607-a618-eadd4948bfbf)

image.png

24 KiB

Lukas Tönne commented

2023-09-18 16:33:32 +02:00

Oh what ... VSCode seems to exclude the addons folder from searches, perhaps because it's "smart" and knows it's a different git repo ... sigh. And thanks for checking again :)

Oh what ... VSCode seems to exclude the addons folder from searches, perhaps because it's "smart" and knows it's a different git repo ... sigh. And thanks for checking _again_ :)

Lukas Tönne added a new dependency 2023-09-18 16:39:40 +02:00

blender/blender-addons#104896 - Node Wrangler: `ui_items` collection renamed to `items_tree`

Lukas Tönne added 1 commit 2023-09-18 17:31:49 +02:00

Merge branch 'main' into rename-node-interface-ui-items

buildbot/vexp-code-patch-coordinator Build done.

Details

3c859b9dc7

Lukas Tönne commented

2023-09-18 17:31:59 +02:00

@blender-bot build

Lukas Tönne merged commit 742f3b233f into main

2023-09-18 18:07:33 +02:00