Custom Properties: Add extra subtypes for float array #112583

Jorijn de Graaf · 2023-09-19T16:05:07+02:00

Jorijn de Graaf commented

2023-09-19 16:05:07 +02:00

I think these are the most useful ones that are missing.
I left out matrix because it doesn't play nice with UI, so I figure nobody making custom properties would need it.
I also left out coordinates because as far as I can tell it's the same thing as XYZ; please correct me if I'm wrong.

I think these are the most useful ones that are missing. I left out matrix because it doesn't play nice with UI, so I figure nobody making custom properties would need it. I also left out coordinates because as far as I can tell it's the same thing as XYZ; please correct me if I'm wrong.

Jorijn de Graaf added 1 commit 2023-09-19 16:05:15 +02:00

37f0e44a6d Add extra subtypes for float array

I think these are the most useful ones that are missing.
I left out matrix because it doesn't play nice with UI so I figure nobody making custom properties would need it.
I also left out coordinates because as far as I can tell it's the same thing as XYZ.

Jorijn de Graaf requested review from Campbell Barton 2023-09-19 16:07:35 +02:00

Jorijn de Graaf requested review from Hans Goudey 2023-09-19 16:07:36 +02:00

Jorijn de Graaf referenced this pull request

2023-09-19 16:14:53 +02:00

Fix #102885: IDproperty subtype can cause Blender UI to throw exception #112582

Germano Cavalcante commented

2023-09-22 14:55:15 +02:00

LGTM, but to help with decision making, I think it would be useful to explain in the description why these types in arrays would be useful.
It might also be useful to show in a screenshot why matrix "doesn't play nice with UI".
I also didn't understand why the fact that "coordinates" is the same as XYZ prevents this from being supported as well.

However, just adding types seems to be OK. (I don't know why we can't just support everything at once).

LGTM, but to help with decision making, I think it would be useful to explain in the description why these types in arrays would be useful. It might also be useful to show in a screenshot why matrix "doesn't play nice with UI". I also didn't understand why the fact that "coordinates" is the same as XYZ prevents this from being supported as well. However, just adding types seems to be OK. (I don't know why we can't just support everything at once).

Jorijn de Graaf commented

2023-09-22 17:46:49 +02:00

These subtypes are used all over Blender, and are useful for custom properties for the same reason they're useful anywhere else.
Matrix looks like this in the UI: , which isn't very useful.
Currently the list is limited to "Most useful entries of rna_enum_property_subtype_items", I suppose to avoid overwhelming the user with options.
I'd be fine with adding Coordinates and more; I only kept the list limited to stick with the current design.

These subtypes are used all over Blender, and are useful for custom properties for the same reason they're useful anywhere else. Matrix looks like this in the UI: ![image](/attachments/5bd3045f-23ef-4326-be02-6d993d74bb3f), which isn't very useful. Currently the list is limited to "Most useful entries of rna_enum_property_subtype_items", I suppose to avoid overwhelming the user with options. I'd be fine with adding Coordinates and more; I only kept the list limited to stick with the current design.

image.png

2.2 KiB

Hans Goudey commented

2023-10-02 23:41:09 +02:00

Looks good. How is XYZ_LENGTH different from TRANSLATION though?

Looks good. How is `XYZ_LENGTH` different from `TRANSLATION` though?

Hans Goudey changed title from ~~Add extra subtypes for float array~~ to Custom Properties: Add extra subtypes for float array

2023-10-02 23:41:26 +02:00

Jorijn de Graaf commented

2023-10-03 00:11:01 +02:00

Looks good. How is XYZ_LENGTH different from TRANSLATION though?

They're the same, but XYZ_LENGTH is used for dimensions while TRANSLATION is used for offset.
I suppose you could get rid of either, though I'm not sure which I'd choose.

> Looks good. How is `XYZ_LENGTH` different from `TRANSLATION` though? They're the same, but `XYZ_LENGTH` is used for dimensions while `TRANSLATION` is used for offset. I suppose you could get rid of either, though I'm not sure which I'd choose.

Hans Goudey commented

2023-10-03 00:19:22 +02:00

Since "TRANSLATION" is exposed in the node editor, I'd prefer to use that here over "XYZ_LENGTH".

Jorijn de Graaf commented

2023-10-03 00:36:38 +02:00

That makes sense, I'll remove XYZ_LENGTH then.
Tomorrow because I've already shut off for the night.

That makes sense, I'll remove `XYZ_LENGTH` then. Tomorrow because I've already shut off for the night.

Jorijn de Graaf added 1 commit 2023-10-03 16:48:15 +02:00

b436d6350c Remove XYZ_LENGTH from the list

It behaves the same as TRANSLATION, and we're choosing to keep that one because geometry nodes uses it too.

Jorijn de Graaf commented

2023-10-03 16:49:19 +02:00

@HooglyBoogly Alright done, XYZ_LENGTH is no more.

@HooglyBoogly Alright done, `XYZ_LENGTH` is no more.

Hans Goudey approved these changes 2023-10-05 09:42:37 +02:00

Hans Goudey merged commit 355a30c106 into main

2023-10-05 09:43:42 +02:00

Hans Goudey referenced this issue from a commit

2023-10-05 09:43:43 +02:00

Custom Properties: Add extra subtypes for float array

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom Properties: Add extra subtypes for float array #112583