Fix #112604: Add "tag" to the tool tip of asset search #112609

YimingWu · 2023-09-20T04:23:25+02:00

YimingWu commented

2023-09-20 04:23:25 +02:00

Asset search will also filter tags alongside names, this patch makes the
description consistent with what it actually does.

Asset search will also filter tags alongside names, this patch makes the description consistent with what it actually does.

YimingWu added 1 commit 2023-09-20 04:23:35 +02:00

Fix #112604 : Add "tag" to the tool tip of asset search 7b69206616

Asset search will also filter tags alongside names, this patch makes the
description consistent with what it actually does.

Pratik Borhade requested review from Pablo Vazquez 2023-09-20 04:33:57 +02:00

Pablo Vazquez commented

2023-09-20 19:08:03 +02:00

I think it should be Filter by name or tag (use or, instead of and), since it is not possible to combine tags and names. It's either or.

I think it should be `Filter by name or tag` (use `or`, instead of `and`), since it is not possible to combine tags and names. It's either or.

👍 1

YimingWu added 1 commit 2023-09-21 04:11:45 +02:00

Use "or" instead of "and" phrase d2f4a398b9

Pablo Vazquez added the

Module

User Interface

label 2023-09-21 12:39:58 +02:00

Pablo Vazquez approved these changes 2023-09-21 12:40:05 +02:00

YimingWu merged commit 4720fda1a7 into main

2023-09-21 16:00:23 +02:00

YimingWu deleted branch fix-112604

2023-09-21 16:00:25 +02:00

YimingWu referenced this issue from a commit

2023-09-21 16:00:27 +02:00

Fix #112604: Add "tag" to the tool tip of asset search

sanek122005 commented

2023-09-21 16:30:04 +02:00

First-time contributor

have you thought about adding an switch to enable search results by tag or name? in my opinion, this can be useful in situations where the tag name and asset match

have you thought about adding an switch to enable search results by tag or name? in my opinion, this can be useful in situations where the tag name and asset match ![Снимок экрана 2023-09-21 172345.png](/attachments/5c01d555-1f41-48fd-9a0b-a8c26327f52b)

Снимок экрана 2023-09-21 172345.png

31 KiB

Julian Eisel commented

2023-09-21 16:44:57 +02:00

Note that this property is shared between the asset and the file browser. So the file browser search will now also mention tags.

👀 1

Colin Basnett referenced this issue from a commit

2023-09-22 10:24:46 +02:00

Fix #112604: Add "tag" to the tool tip of asset search

Sign in to join this conversation.

No reviewers