Fix #104554: 2d paint does not paint with linear color on 32bit images #112631

Philipp Oeser · 2023-09-20T17:03:43+02:00

Philipp Oeser commented

2023-09-20 17:03:43 +02:00

When painting in the Image Editor on Non-Color float images, the brush color was
not converted from sRGB to linear, leading to differences painting with
the same brush in the 3DView vs. the Image Editor.

Now corrected by piping the brush color through
srgb_to_linearrgb_v3_v3() when painting on 32bit images.

Should probably go into LTS as well.

When painting in the Image Editor on Non-Color float images, the brush color was not converted from sRGB to linear, leading to differences painting with the same brush in the 3DView vs. the Image Editor. Now corrected by piping the brush color through srgb_to_linearrgb_v3_v3() when painting on 32bit images. Should probably go into LTS as well.

Philipp Oeser added 1 commit 2023-09-20 17:03:58 +02:00

2bba33b62d Fix #104554 : 2d paint does not paint with linear color on 32bit images

When painting in the Image Editor on float images, the brush color was
not converted from sRGB to linear, leading to differences painting with
the same brush in the 3DView vs. the Image Editor.

Now corrected by piping the brush color through
srgb_to_linearrgb_v3_v3() when painting on 32bit images.

Should probably go into LTS as well.

Philipp Oeser requested review from Sergey Sharybin 2023-09-20 17:04:08 +02:00

Philipp Oeser requested review from Brecht Van Lommel 2023-09-20 17:04:14 +02:00

Philipp Oeser requested review from Julien Kaspar 2023-09-20 17:04:21 +02:00

Philipp Oeser added this to the Sculpt, Paint & Texture project 2023-09-20 17:04:32 +02:00

Philipp Oeser referenced this pull request

2023-09-20 17:17:06 +02:00

32 bit Float Image Different Value In 3D Viewport And Image Editor #104554

Philipp Oeser commented

2023-09-20 17:18:36 +02:00

Hold on, just realized the fix it is probably more complicated , see #95797 (since now this seems to break 2d painting with textures other than Non Color colorspace)

Hold on, just realized the fix it is probably more complicated , see #95797 (since now this seems to break 2d painting with textures other than `Non Color` colorspace)

Philipp Oeser changed title from ~~Fix #104554: 2d paint does not paint with linear color on 32bit images~~ to WIP: Fix #104554: 2d paint does not paint with linear color on 32bit images

2023-09-20 17:22:26 +02:00

Philipp Oeser added 1 commit 2023-09-20 18:05:54 +02:00

d52c9208f4 only convert to linear if it hasnt been done before

colorspaces other than Non-Color would have converted to linear in
paint_brush_color_get() already.

Philipp Oeser commented

2023-09-20 18:07:31 +02:00

Hold on, just realized the fix it is probably more complicated , see #95797 (since now this seems to break 2d painting with textures other than Non Color colorspace)

Ah, for non-color, conversion to linear was done already

> Hold on, just realized the fix it is probably more complicated , see #95797 (since now this seems to break 2d painting with textures other than `Non Color` colorspace) Ah, for non-color, conversion to linear was done already

Philipp Oeser changed title from ~~WIP: Fix #104554: 2d paint does not paint with linear color on 32bit images~~ to Fix #104554: 2d paint does not paint with linear color on 32bit images

2023-09-20 18:07:44 +02:00

Philipp Oeser commented

2023-09-20 19:36:27 +02:00

Hm, sampling in the Image Editor is wrong, too, guess I have to look at this with fresh eyes again

Daniel Bystedt commented

2024-02-29 19:58:55 +01:00

I have just tested this issue with a half float precision image set to colorspace Non-Color. Sampling a texture and painting in the texture paint mode. I can verify that this is a bug.

Sampling hotkey is shift+X for anyone testing this.

Sampling in image view and painting in image view results in correct color
Sampling in 3d view and paint in the 3d view results in correct color
Sampling in image view and painting in 3d view results in INCORRECT color

Furthermore I find it strange that the color in the color swatches are not afffected by the scene view transform settings. I would assume the color swatches to have the same color as the colors represented after view transform on the image. The RGB values in the color settings should however represent the true, linear values of the color.

Another observation I made was that the image editor was not affected by the view transform settings in render > color management. This is not desired behaviour. The image editor should result in the same color as in the 3d view.

I have just tested this issue with a half float precision image set to colorspace Non-Color. Sampling a texture and painting in the texture paint mode. I can verify that this is a bug. Sampling hotkey is shift+X for anyone testing this. - Sampling in `image view` and painting in `image view` results in correct color - Sampling in `3d view` and paint in the` 3d view` results in correct color - Sampling in `image view` and painting in `3d view` results in INCORRECT color Furthermore I find it strange that the color in the color swatches are not afffected by the scene view transform settings. I would assume the color swatches to have the same color as the colors represented after view transform on the image. The RGB values in the color settings should however represent the true, linear values of the color. Another observation I made was that the image editor was not affected by the view transform settings in `render > color management`. This is not desired behaviour. The image editor should result in the same color as in the 3d view.

debug 104554 v001.blend

1006 KiB

debug color sampling.mp4

7.4 MiB

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 104554:lichtwerk-104554

git checkout lichtwerk-104554

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #104554: 2d paint does not paint with linear color on 32bit images #112631

Checkout