Fix #112650: UI: Missing Header Status in Node Editor after Turning off Auto-offset #112657

Pratik Borhade · 2023-09-21T10:43:37+02:00

Pratik Borhade commented

2023-09-21 10:43:37 +02:00

Caused by 42f8b49581
When auto-offset is OFF, garbage characters was displayed due to
uninitialized string.
To fix this, create an empty string and also display status that auto offset is OFF

Caused by 42f8b495815c95211ebd969283ea2bf47fa7c720 When auto-offset is OFF, garbage characters was displayed due to uninitialized string. To fix this, create an empty string and also display status that `auto offset` is OFF

Pratik Borhade added 1 commit 2023-09-21 10:43:49 +02:00

1dd83db21c Fix #112650 : UI: Missing Header Status in Node Editor after Turning off Auto-offset

When auto-offset is OFF, garbage characters was displayed due to
uninitialized string.
To fix this, create an empty string and also display status that `auto
offset` is OFF

Pratik Borhade requested review from Leon Schittek 2023-09-21 10:44:15 +02:00

Leon Schittek added 1 commit 2023-09-21 13:03:21 +02:00

269314330c Merge branch 'main' into 112650-node-auto-offset

Leon Schittek commented

2023-09-21 22:02:16 +02:00

Thanks for the fix!

It works well, but I'm not sure about always showing "Auto-offset direction: OFF" in the header.
Now that this is a preference It feels weird to always remind people of something they deliberately turned off - especially since they can't actually enable it while the message is shown.

How about something like this:

diff --git a/source/blender/editors/transform/transform_mode_translate.cc b/source/blender/editors/transform/transform_mode_translate.cc
index c9deb98579a..e33c395f0ef 100644
--- a/source/blender/editors/transform/transform_mode_translate.cc
+++ b/source/blender/editors/transform/transform_mode_translate.cc
@@ -564,7 +564,7 @@ static bool clip_uv_transform_translation(TransInfo *t, float vec[2])

 static void applyTranslation(TransInfo *t)
 {
-  char str[UI_MAX_DRAW_STR];
+  char str[UI_MAX_DRAW_STR] = "";
   float global_dir[3] = {0.0f};

   if (t->flag & T_INPUT_IS_VALUES_FINAL) {
@@ -640,7 +640,7 @@ static void applyTranslation(TransInfo *t)
   headerTranslation(t, (t->con.mode & CON_APPLY) ? t->values_final : global_dir, str);

   recalc_data(t);
-  ED_area_status_text(t->area, str);
+  ED_area_status_text(t->area, (str[0] == '\0') ? nullptr : str);
 }

That way we don't get a status text at all, when there is no information to show.

(Also sorry for the random merge earlier. I accidentally clicked that button when looking at this on my phone :') )

Thanks for the fix! It works well, but I'm not sure about always showing "Auto-offset direction: OFF" in the header. Now that this is a preference It feels weird to always remind people of something they deliberately turned off - especially since they can't actually enable it while the message is shown. How about something like this: ```diff diff --git a/source/blender/editors/transform/transform_mode_translate.cc b/source/blender/editors/transform/transform_mode_translate.cc index c9deb98579a..e33c395f0ef 100644 --- a/source/blender/editors/transform/transform_mode_translate.cc +++ b/source/blender/editors/transform/transform_mode_translate.cc @@ -564,7 +564,7 @@ static bool clip_uv_transform_translation(TransInfo *t, float vec[2]) static void applyTranslation(TransInfo *t) { - char str[UI_MAX_DRAW_STR]; + char str[UI_MAX_DRAW_STR] = ""; float global_dir[3] = {0.0f}; if (t->flag & T_INPUT_IS_VALUES_FINAL) { @@ -640,7 +640,7 @@ static void applyTranslation(TransInfo *t) headerTranslation(t, (t->con.mode & CON_APPLY) ? t->values_final : global_dir, str); recalc_data(t); - ED_area_status_text(t->area, str); + ED_area_status_text(t->area, (str[0] == '\0') ? nullptr : str); } ``` That way we don't get a status text at all, when there is no information to show. (Also sorry for the random merge earlier. I accidentally clicked that button when looking at this on my phone :') )

👍 1

Pratik Borhade added 2 commits 2023-09-22 11:28:50 +02:00

7a9c60c58f Don't show message when auto-offset is off

cfaad84f49 Merge branch '112650-node-auto-offset' of projects.blender.org:PratikPB2123/blender into 112650-node-auto-offset

Leon Schittek approved these changes 2023-09-22 15:14:56 +02:00

Leon Schittek left a comment

Tested it some more and looks good to me. Thanks!

Leon Schittek added this to the User Interface project 2023-09-22 15:15:41 +02:00

Leon Schittek added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #112650: UI: Missing Header Status in Node Editor after Turning off Auto-offset #112657