UI: Remove File Browser "small_size" Feature #112696

Harley Acheson · 2023-09-22T04:15:42+02:00

Harley Acheson commented

2023-09-22 04:15:42 +02:00

Remove non-working feature that changes File Browser list view when the
thumbnails are smaller than 64x64.

File Browser code currently contains a feature for "small_size" which doesn't work and causes some issues.

The intent is to alter the File Browser listing to show a more compact display under some conditions. Unfortunately it is tied to the size of thumbnails. Which makes no sense since this is for the non-thumbnail view. And the condition is when the thumbnail size drops below 64, which has never been the case so this code has never been used or tested.

But since #105815 we are allowing thumbnails to get smaller than 64, which exposes the problems with the "small_size". It alters the width of the date column but does not properly alter the string that goes in there. It alters the width of the size column but then we don't have a more compact form of size. The result is that if you have thumbnails smaller than 64 then some columns in list view will overflow.

The PR just removes this feature, rather than fix it. A fix is submitted as #112464 but it is getting a bit late in the release for that. We could merge this one and perhaps revive the feature properly for 4.1.

Remove non-working feature that changes File Browser list view when the thumbnails are smaller than 64x64. --- File Browser code currently contains a feature for "small_size" which doesn't work and causes some issues. The intent is to alter the File Browser listing to show a more compact display under some conditions. Unfortunately it is tied to the size of thumbnails. Which makes no sense since this is for the non-thumbnail view. And the condition is when the thumbnail size drops below 64, which has never been the case so this code has never been used or tested. But since #105815 we are allowing thumbnails to get smaller than 64, which exposes the problems with the "small_size". It alters the width of the date column but does not properly alter the string that goes in there. It alters the width of the size column but then we don't have a more compact form of size. The result is that if you have thumbnails smaller than 64 then some columns in list view will overflow. ![image](/attachments/5f063bc7-6360-4d0f-bef4-d865f8152ff2) The PR just removes this feature, rather than fix it. A fix is submitted as #112464 but it is getting a bit late in the release for that. We could merge this one and perhaps revive the feature properly for 4.1.

image.png

140 KiB

image.png

13 KiB

Harley Acheson added 1 commit 2023-09-22 04:15:53 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

384996d90c UI: Remove File Browser "small_size"

Remove non-working feature that changes File Browser list view when the
thumbnails are smaller than 64x64.

---

File Browser code currently contains a feature for "small_size" which doesn't work and causes some issues.

The intent is to alter the File Browser listing to show a more compact display under some conditions. Unfortunately it is tied to the size of thumbnails. Which makes no sense since this is for the non-thumbnail view. And the condition is when the thumbnail size drops below 64, which has never been the case so this code has never been used or tested.

But since #105815 we are allowing thumbnails to get smaller than 64, which exposes the problems with the "small_size". It alters the width of the date column but does not properly alter the string that goes in there. It alters the width of the size column but then we don't have a more compact form of size.  The result is that if you have thumbnails smaller than 64 then some columns in list view will overflow.

The PR just removes this feature, rather than fix it. A fix is submitted as #112464 but it is getting a bit late for that. We could merge this one and perhaps revive the feature for 4.1

Harley Acheson added this to the User Interface project 2023-09-22 04:16:06 +02:00

Harley Acheson requested review from Julian Eisel 2023-09-22 04:16:16 +02:00

Julian Eisel approved these changes 2023-09-22 16:01:47 +02:00

Harley Acheson commented

2023-09-22 17:18:36 +02:00

@blender-bot build

Harley Acheson merged commit 01c2f72f26 into main

2023-09-22 17:47:51 +02:00

Harley Acheson referenced this issue from a commit

2023-09-22 17:47:51 +02:00

UI: Remove File Browser "small_size" Feature

Harley Acheson deleted branch RemoveSmallSize

2023-09-22 17:47:53 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Remove File Browser "small_size" Feature #112696