Modeling: Snap 3d cursor rotation to active #112718

MohammadHossein Jamshidi · 2023-09-22T14:11:36+02:00

2023-09-22 14:11:36 +02:00

First-time contributor

This PR adds the ability of snapping(aligning) the rotation of the 3d cursor to the active element.
we can choose snap mode: location only, rotation only, location and rotation.
It also takes care of skewed cases; so a function that handles the skewness, keeps an important axis and cures the others.

General 3d cursor bug: there's an issue with the operators that are manipulating the 3d cursor's transformation. Since is is not included in undo_stack, changing the state of the operator, will result in rerunning also in the new mode. To see this, apply the "snap cursor to active", then change the mode and you'll see that.

This PR adds the ability of snapping(aligning) the rotation of the 3d cursor to the active element. we can choose snap mode: location only, rotation only, location and rotation. It also takes care of skewed cases; so a function that handles the skewness, keeps an important axis and cures the others. General 3d cursor bug: there's an issue with the operators that are manipulating the 3d cursor's transformation. Since is is not included in undo_stack, changing the state of the operator, will result in rerunning also in the new mode. To see this, apply the "snap cursor to active", then change the mode and you'll see that. ![image](/attachments/97e89ce8-12e9-49db-8e15-951b9be60888)

image.png

15 KiB

❤️ 2

MohammadHossein Jamshidi added 4 commits 2023-09-22 14:11:44 +02:00

ca41cf7484 snap 3dcursor rotation in pose mode and general

TODO: edit mode and other snapping types

64a9cc088c snap 3d cursor in edit mode

418bea4db3 snap mode enum added

3bf9f6a9a7 active bone function rename

MohammadHossein Jamshidi requested review from Campbell Barton 2023-09-22 14:12:17 +02:00

Christoph Lendenfeld commented

2023-09-22 15:15:44 +02:00

this seems to be a bug with the 3D cursor and the undo system
#57100: Redo panel does not work for the 3d cursor

this seems to be a bug with the 3D cursor and the undo system [#57100: Redo panel does not work for the 3d cursor](https://projects.blender.org/blender/blender/issues/57100)

MohammadHossein Jamshidi changed title from ~~WIP: Snap 3d cursor rotation to active~~ to Modeling: Snap 3d cursor rotation to active

2023-09-22 15:20:42 +02:00

Nate Rupsis added the

Module

Modeling

label 2023-09-22 17:23:17 +02:00

MohammadHossein Jamshidi changed title from ~~Modeling: Snap 3d cursor rotation to active~~ to WIP: Modeling: Snap 3d cursor rotation to active

2023-09-23 00:17:02 +02:00

MohammadHossein Jamshidi changed title from ~~WIP: Modeling: Snap 3d cursor rotation to active~~ to Modeling: Snap 3d cursor rotation to active

2023-09-23 00:17:19 +02:00

This pull request has changes conflicting with the target branch.

source/blender/blenlib/intern/math_matrix.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u snap_3dcursor_rotation_to_active:Jam3D-snap_3dcursor_rotation_to_active

git checkout Jam3D-snap_3dcursor_rotation_to_active

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Modeling: Snap 3d cursor rotation to active #112718

Checkout