Fix: Garbage string when searching in menu #112719

Pratik Borhade · 2023-09-22T14:13:00+02:00

Pratik Borhade commented

2023-09-22 14:13:00 +02:00

In debug mode, garbage string is displayed when searching in menu.
This is because utf8_buf was copied to initial query property
string.

In debug mode, garbage string is displayed when searching in menu. This is because `utf8_buf` was copied to `initial query` property string.

search-query.mp4

11 MiB

Pratik Borhade added 1 commit 2023-09-22 14:13:13 +02:00

e48aa3b67e Fix: Garbage string when searching in panels

In debug mode, garbage string is displayed when searching in panels.
This is because `utf8_buf` was copied to `initial query` property
string.

Pratik Borhade requested review from Jacques Lucke 2023-09-22 14:13:21 +02:00

Pratik Borhade commented

2023-09-22 14:16:35 +02:00

Not sure if this is replicable on other systems but I've been observing this for last 4-5 days

Jacques Lucke commented

2023-09-22 14:28:06 +02:00

This is not quite right. We need the initial_query, otherwise the search will start out empty which is not intended. The question is why there is some garbage in the buffer.

This is not quite right. We need the `initial_query`, otherwise the search will start out empty which is not intended. The question is why there is some garbage in the buffer.

Hans Goudey commented

2023-09-22 14:28:07 +02:00

I've noticed this too, thanks for looking into it! But I think it's searching in menus rather than panels, just to be picky about the naming ;)

Pratik Borhade commented

2023-09-22 16:01:24 +02:00

This is not quite right. We need the initial_query, otherwise the search will start out empty which is not intended

I might be misunderstanding something but when we press some key to invoke search operation, shouldn't the text field be empty by default?

But I think it's searching in menus rather than panels, just to be picky about the naming

Sorry for that 😅

> This is not quite right. We need the initial_query, otherwise the search will start out empty which is not intended I might be misunderstanding something but when we press some key to invoke search operation, shouldn't the text field be empty by default? > But I think it's searching in menus rather than panels, just to be picky about the naming Sorry for that 😅

Jacques Lucke commented

2023-09-22 16:07:14 +02:00

I might be misunderstanding something but when we press some key to invoke search operation, shouldn't the text field be empty by default?

No, it should contain the key that you pressed so that you don't have to press it again.

> I might be misunderstanding something but when we press some key to invoke search operation, shouldn't the text field be empty by default? No, it should contain the key that you pressed so that you don't have to press it again.

Pratik Borhade commented

2023-09-22 16:09:16 +02:00

Ah, right. Didn't noticed this earlier.
I can take a look after some time today. But if you have quick fix, feel free to commit 🙂

Ah, right. Didn't noticed this earlier. I can take a look after some time today. But if you have quick fix, feel free to commit 🙂

Jacques Lucke commented

2023-09-22 16:10:28 +02:00

I don't have a quick fix right now, sry.

👍 1

Pratik Borhade added 1 commit 2023-09-22 17:52:14 +02:00

b39fa4196e Pass only first char from utf8_buf

Rest chars are intentionally filled in debug mode with 0xff
So only pass first char from buffer

Pratik Borhade commented

2023-09-22 17:53:23 +02:00

Rest chars are intentionally filled in debug mode with 0xff

see: wm_event_system.cc

> Rest chars are intentionally filled in debug mode with 0xff see: [wm_event_system.cc](https://projects.blender.org/blender/blender/src/branch/main/source/blender/windowmanager/intern/wm_event_system.cc#L5710)

Jacques Lucke reviewed 2023-09-22 18:00:37 +02:00

source/blender/windowmanager/intern/wm_operators.cc Outdated

						
				@ -1916,3 +1916,3 @@

				                 "initial_query",

				                 nullptr,

				                 0,

				                 2,

Jacques Lucke commented

2023-09-22 18:00:33 +02:00

Haven't tested it yet, but generally an utf8 buffer can have 1-4 bytes.

Pratik Borhade commented

2023-09-23 13:03:03 +02:00

but we only need first char from the buffer (i.e. pressed key), no? :)

(And the search menu is only invoked when A-to-Z letters are pressed so the pressed letter is always within 1 byte)

but we only need first char from the buffer (i.e. pressed key), no? :) (And the search menu is only invoked when A-to-Z letters are pressed so the `pressed letter` is always within 1 byte)

Jacques Lucke commented

2023-09-23 13:18:21 +02:00

Yeah, but the initial_query input could totally be used elsewhere in the future. Fixing the issue here at that level seems wrong.

Better only change where the operator is invoked, because the actual error is passing in the debug values. You should be able to get the correct size for the first utf8 char using BLI_str_utf8_as_unicode_step_safe. Otherwise just pass in the first byte since we are only dealing with a-z there for now anyway as I rightly pointed out.

Yeah, but the `initial_query` input could totally be used elsewhere in the future. Fixing the issue here at that level seems wrong. Better only change where the operator is invoked, because the actual error is passing in the debug values. You should be able to get the correct size for the first utf8 char using `BLI_str_utf8_as_unicode_step_safe`. Otherwise just pass in the first byte since we are only dealing with a-z there for now anyway as I rightly pointed out.

Pratik Borhade changed title from ~~Fix: Garbage string when searching in panels~~ to Fix: Garbage string when searching in menu

2023-09-23 13:07:46 +02:00

Pratik Borhade added 1 commit 2023-09-24 14:49:37 +02:00

ff29efdf7d Pass first byte in invoke function

Jacques Lucke referenced this issue from a commit

2023-09-24 22:38:31 +02:00

Fix: UI: garbage string when invoking search from menu

Jacques Lucke commented

2023-09-24 22:39:51 +02:00

Sorry for wasting your time on this one with unclear instructions. By "better only change where the operator is invoked" I meant the ui_handle_menu_letter_press function which calls the operator.

I committed the fix I had in mind now: eef2a706b4.

Sorry for wasting your time on this one with unclear instructions. By "better only change where the operator is invoked" I meant the `ui_handle_menu_letter_press` function which calls the operator. I committed the fix I had in mind now: eef2a706b45227689ae2f1b55a7c28ff6dbee8ba.

Jacques Lucke closed this pull request

2023-09-24 22:39:52 +02:00

Pratik Borhade commented

2023-09-25 12:58:28 +02:00

Thanks :)

Pratik Borhade deleted branch search-type-query

2023-09-25 12:58:36 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Garbage string when searching in menu #112719

Pull request closed