Fix: text hint option look inactive when it is working. #112737

Closed
Gilberto Rodrigues wants to merge 1 commits from Gilberto.R:temp-hintpref into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Contributor

text hint option look inactive when it is working.
see #112736

text hint option look inactive when it is working. see https://projects.blender.org/blender/blender/issues/112736
Gilberto Rodrigues added 1 commit 2023-09-22 19:01:06 +02:00
Gilberto Rodrigues requested review from Harley Acheson 2023-09-22 19:01:16 +02:00
Member

I am soooo glad you noticed this.

But the difference in output you see when changing the "hinting" options when "Anti-aliasing" is turned off is not due to the hinting. You'll notice that there wouldn't be difference between selecting "Slight" or "Full".

Unintuitively, the non-antialiased mode is actually a hinting type. We could actually remove that checkmark and add a new item to the "Hinting" list for it. It just wouldn't make much sense to most users that way. The hinting in this mode strongly moves glyph features to align to the pixel grid as best as possible. It is still mostly ugly, but that is the idea.

The difference you see when in that mode and change hinting to Slight or Full is really just the new Subpixel AA. That feature can only make the mono hinting mode worse and never better. I just didn't notice this combination because I didn't think of changing the hinting dropdown while it was greyed out.

Thanks again for noticing this issue. I really do appreciate it. I fixed it in #112759 by not doing subpixel AA in this mode.

I am soooo glad you noticed this. But the difference in output you see when changing the "hinting" options when "Anti-aliasing" is turned off is not due to the hinting. You'll notice that there wouldn't be difference between selecting "Slight" or "Full". Unintuitively, the non-antialiased mode is actually a hinting type. We could actually remove that checkmark and add a new item to the "Hinting" list for it. It just wouldn't make much sense to most users that way. The hinting in this mode **strongly** moves glyph features to align to the pixel grid as best as possible. It is still mostly ugly, but that is the idea. The difference you see when in that mode and change hinting to Slight or Full is really just the new Subpixel AA. That feature can only make the mono hinting mode worse and never better. I just didn't notice this combination because I didn't think of changing the hinting dropdown while it was greyed out. Thanks again for noticing this issue. I really do appreciate it. I fixed it in #112759 by not doing subpixel AA in this mode.
Harley Acheson closed this pull request 2023-09-23 01:39:37 +02:00
Gilberto Rodrigues deleted branch temp-hintpref 2023-09-25 11:20:30 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112737
No description provided.