Fix #111532: Partial Update Byte Data Texture with Scaling Broken #112834

Jeroen Bakker · 2023-09-25T09:14:36+02:00

Jeroen Bakker commented

2023-09-25 09:14:36 +02:00

When texture painting on a Non-color byte texture with Texture limit active
(or the texture didn't fit on the GPU) the data for partial updating of a GPU
texture was incorrect.

gpu_texture_update_scaled expects an input buffer clipped to
the bounds of the input area that needs to be updated. In case for Byte
textures with Non Color colorspace it received the unmodified input
buffer, resulting in incorrect data to be uploaded to the GPU texture.

This PR fixes this by selecting the non-optimized branch when the
texture is a Byte buffer with Data color space and scaling should
happen.

When texture painting on a Non-color byte texture with Texture limit active (or the texture didn't fit on the GPU) the data for partial updating of a GPU texture was incorrect. `gpu_texture_update_scaled` expects an input buffer clipped to the bounds of the input area that needs to be updated. In case for Byte textures with Non Color colorspace it received the unmodified input buffer, resulting in incorrect data to be uploaded to the GPU texture. This PR fixes this by selecting the non-optimized branch when the texture is a Byte buffer with Data color space and scaling should happen.

Jeroen Bakker added this to the 4.0 milestone 2023-09-25 09:14:36 +02:00

Jeroen Bakker added the

Module

Core

label 2023-09-25 09:14:36 +02:00

Jeroen Bakker self-assigned this 2023-09-25 09:14:36 +02:00

Jeroen Bakker changed title from ~~Fix 111532: Texture Painting on Byte Data With Texture Limit~~ to Fix #111532: Texture Painting on Byte Data With Texture Limit

2023-09-25 09:15:13 +02:00

Jeroen Bakker changed title from ~~Fix #111532: Texture Painting on Byte Data With Texture Limit~~ to Fix #111532: Partial Texture Byte Data Update With Texture Limit Issue

2023-09-25 09:16:17 +02:00

Jeroen Bakker changed title from ~~Fix #111532: Partial Texture Byte Data Update With Texture Limit Issue~~ to Fix #111532: Partial Update Byte Data Texture with Scaling Broken

2023-09-25 09:17:04 +02:00

Jeroen Bakker requested review from Brecht Van Lommel 2023-09-25 09:23:10 +02:00

Jeroen Bakker added this to the EEVEE & Viewport project 2023-09-25 09:23:27 +02:00

Jeroen Bakker added

and removed

labels 2023-09-25 09:23:33 +02:00

Jeroen Bakker force-pushed fix/111532 from 28f7e108b6 to b521c6b7f1

2023-09-25 09:30:38 +02:00