Fix #112022: allow vertex groups and attributes with same names again #112889

Jacques Lucke · 2023-09-26T10:18:34+02:00

Jacques Lucke commented

2023-09-26 10:18:34 +02:00

This was discussed in #112022 and on devtalk: https://devtalk.blender.org/t/vertex-groups-generic-attributes-and-name-clashing/31073

While vertex groups with the same name as attributes should be avoided, since it can cause ambiguities when using attributes, it's something we can handle gracefully for now. Enforcing unique names for vertex groups resulted in breaking other functionality under some circumstances.

This effectively reverts 12ef20990b, except for the bug fix in BKE_id_attribute_new.

#112891 adds a warning to avoid make users aware of duplicate names so that they can be avoided in practice.

This was discussed in #112022 and on devtalk: https://devtalk.blender.org/t/vertex-groups-generic-attributes-and-name-clashing/31073 While vertex groups with the same name as attributes should be avoided, since it can cause ambiguities when using attributes, it's something we can handle gracefully for now. Enforcing unique names for vertex groups resulted in breaking other functionality under some circumstances. This effectively reverts 12ef20990b35efbf8358a501d52119cd9f6197ed, except for the bug fix in `BKE_id_attribute_new`. #112891 adds a warning to avoid make users aware of duplicate names so that they can be avoided in practice.

Jacques Lucke added 1 commit 2023-09-26 10:18:47 +02:00

8b38b11f05 revert

Jacques Lucke referenced this pull request

2023-09-26 10:33:29 +02:00

Mesh: show attribute name collision warning in more panels #112891

Jacques Lucke requested review from Bastien Montagne 2023-09-26 10:35:13 +02:00

Jacques Lucke requested review from Hans Goudey 2023-09-26 10:35:13 +02:00

Hans Goudey approved these changes 2023-09-26 14:48:36 +02:00

Jacques Lucke merged commit 5c5a041edd into main

2023-09-26 15:36:19 +02:00

Jacques Lucke deleted branch revert-unique-vertex-group-names

2023-09-26 15:36:21 +02:00