I18n: fix translation of Grease Pencil 3.0 layer names #112930

Merged

Bastien Montagne merged 1 commits from pioverfour/blender:dp_fix_gp_layer_names_trans into blender-v4.0-release

2023-10-05 10:51:41 +02:00

Damien Picard commented

2023-09-27 01:06:05 +02:00

Member

The Grease Pencil 3.0 layers and groups were not properly translated:

The layers and groups' names were translated during display in the
layer list. Since they are data, they should be left untranslated at
this time.
On object creation, the names "GP_Layer", "Color", "Lines", and
"Fills" were not translated at all.
This adds DATA_() macros around to translate them if the user has
enabled translation of new data names.
The functions returning unique names for layers and groups
unique_layer_group_name() and unique_layer_name() would return
"GP_Layer" and "GP_Group" by default.
These defaults are now translated.
When adding new layers and groups, the name was always hardcoded to
"GP_Layer" and "GP_Group" because the operators' properties for the
names defaulted to that, and prop defaults cannot be translated.
Instead, make them default to a null string, but choose an
appropriate name when executing the op. This name is chosen by
unique_layer_name() and unique_layer_group_name(), whose defaults
are now translated.

The Grease Pencil 3.0 layers and groups were not properly translated: - The layers and groups' names were translated during display in the layer list. Since they are data, they should be left untranslated at this time. - On object creation, the names "GP_Layer", "Color", "Lines", and "Fills" were not translated at all. This adds DATA_() macros around to translate them if the user has enabled translation of new data names. - The functions returning unique names for layers and groups unique_layer_group_name() and unique_layer_name() would return "GP_Layer" and "GP_Group" by default. These defaults are now translated. - When adding new layers and groups, the name was always hardcoded to "GP_Layer" and "GP_Group" because the operators' properties for the names defaulted to that, and prop defaults cannot be translated. Instead, make them default to a null string, but choose an appropriate name when executing the op. This name is chosen by unique_layer_name() and unique_layer_group_name(), whose defaults are now translated.

Damien Picard added the

labels 2023-09-27 01:06:05 +02:00

Damien Picard requested review from Bastien Montagne 2023-09-27 01:07:02 +02:00

Damien Picard changed title from ~~I18n: fix translation of Grease Pencil 3.0 layer names~~ to I18n: fix translation of Grease Pencil 3.0 layer names

2023-09-27 16:11:10 +02:00

Damien Picard changed title from ~~I18n: fix translation of Grease Pencil 3.0 layer names~~ to I18n: fix translation of Grease Pencil 3.0 layer names

2023-09-27 16:11:10 +02:00

pioverfour changed target branch from main to blender-v4.0-release

2023-09-27 16:11:12 +02:00

Damien Picard force-pushed dp_fix_gp_layer_names_trans from 4ed0aacc36 to 6b75550183

2023-09-27 16:13:50 +02:00

Compare

Damien Picard added the

label 2023-09-28 11:03:11 +02:00

Bastien Montagne approved these changes 2023-10-03 18:27:14 +02:00

Bastien Montagne left a comment

Owner

LGTM, but would not mind a second pair of eyes from GP team here.

LGTM, but would not mind a second pair of eyes from GP team here.

Bastien Montagne requested review from Falk David 2023-10-03 18:27:25 +02:00

Falk David approved these changes 2023-10-05 10:27:10 +02:00

Falk David left a comment

Member

Thank you for looking at this! The changes look good to me. One thing I would actually like to change is the default names. E.g. "GP_Layer" seems a bit redundant, since we know that it's grease pencil. Just "Layer" might be better. And "Layer Group" or just "Group" for the default group name.
But I think that's out of scope for this PR :)

Thank you for looking at this! The changes look good to me. One thing I would actually like to change is the default names. E.g. "GP_Layer" seems a bit redundant, since we know that it's grease pencil. Just "Layer" might be better. And "Layer Group" or just "Group" for the default group name. But I think that's out of scope for this PR :)

Bastien Montagne referenced this issue from a commit

2023-10-05 10:51:40 +02:00

I18n: fix translation of Grease Pencil 3.0 layer names

Bastien Montagne merged commit e773e0952a into blender-v4.0-release

2023-10-05 10:51:41 +02:00

Bastien Montagne deleted branch dp_fix_gp_layer_names_trans

2023-10-05 10:51:43 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112930

No description provided.