Fix #113008: VIEW3D Header Overlap With No Transparency #113032

Harley Acheson · 2023-09-28T21:49:58+02:00

Harley Acheson commented

2023-09-28 21:49:58 +02:00

Do not treat the VIEW3D Header as overlapped if fully opaque. This
allows opening the Header Context menu from any part of it when without
transparency.

This just makes the VIEW3D return false for ED_region_is_overlap if the header color is not fully opaque. That way you can right-click anywhere on it to get the header context menu.

Note that we cache this state in region->overlap. So a potential problem is that this will not get updated if you change the header opacity while blender is running. This problem is already commented as "set here, assuming userpref switching forces to call this again." This is why this PR changes the RNA_def_property_update for the change of header color so that it forces a redraw (just like changing use_region_overlap).

Note that the tool header has to always be overlapped, no matter what the header color, since we need to click through the empty portions of it.

Do not treat the VIEW3D Header as overlapped if fully opaque. This allows opening the Header Context menu from any part of it when without transparency. --- This just makes the VIEW3D return false for `ED_region_is_overlap` if the header color is not fully opaque. That way you can right-click anywhere on it to get the header context menu. Note that we cache this state in `region->overlap`. So a potential problem is that this will not get updated if you change the header opacity while blender is running. This problem is already commented as "set here, assuming userpref switching forces to call this again." This is why this PR changes the `RNA_def_property_update` for the change of header color so that it forces a redraw (just like changing use_region_overlap). Note that the _tool header_ has to always be overlapped, no matter what the header color, since we need to click through the empty portions of it.

Harley Acheson added 1 commit 2023-09-28 21:50:09 +02:00

3dffeb9892 Fix #113008 : 3DView Header Overlap With No Transparency

Do not treat the 3DView Header as overlapped if fully opaque. This
allows opening the Header Context menu from any part of it when without
transparency.

Harley Acheson added this to the User Interface project 2023-09-28 21:50:18 +02:00

Harley Acheson requested review from Julian Eisel 2023-09-28 21:50:25 +02:00

Harley Acheson referenced this issue from a commit

2023-10-09 18:55:26 +02:00

Fix #113008: VIEW3D Header Overlap With No Transparency

Harley Acheson merged commit ec59d5eac0 into blender-v4.0-release

2023-10-09 18:55:27 +02:00

Harley Acheson deleted branch Fix113008

2023-10-09 18:55:31 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113008: VIEW3D Header Overlap With No Transparency #113032