Realtime Compositor: Implement Keying Screen node #113055

Merged
Omar Emara merged 7 commits from OmarEmaraDev/blender:gpu-keying-screen into main 2023-10-04 07:35:15 +02:00
Member

This patch implements the Keying Screen node for the Realtime
Compositor. Draw data was introduced to the Movie Clip ID to allow
caching of the keying screen.

Depends on: #112480.

This patch implements the Keying Screen node for the Realtime Compositor. Draw data was introduced to the Movie Clip ID to allow caching of the keying screen. Depends on: #112480.
Omar Emara added the
Interest
Compositing
Module
VFX & Video
labels 2023-09-29 12:53:00 +02:00
Omar Emara added 4 commits 2023-09-29 12:53:12 +02:00
Sergey Sharybin was assigned by Omar Emara 2023-09-29 12:53:36 +02:00
Clément Foucault was assigned by Omar Emara 2023-09-29 12:53:36 +02:00
Sergey Sharybin was unassigned by Clément Foucault 2023-09-30 09:46:41 +02:00
Clément Foucault removed their assignment 2023-09-30 09:46:42 +02:00
Clément Foucault requested review from Sergey Sharybin 2023-09-30 09:46:54 +02:00
Clément Foucault requested review from Clément Foucault 2023-09-30 09:46:55 +02:00
Clément Foucault requested changes 2023-09-30 10:07:37 +02:00
Clément Foucault left a comment
Member

Just a couple of warning on Metal.

Just a couple of warning on Metal.
@ -0,0 +12,4 @@
* faster. */
void populate_cache()
{
if (gl_LocalInvocationIndex < number_of_markers) {

Cast gl_LocalInvocationIndex to int.

Cast `gl_LocalInvocationIndex` to `int`.
OmarEmaraDev marked this conversation as resolved
@ -0,0 +35,4 @@
float sum_of_weights = 0.0;
vec4 weighted_sum = vec4(0.0);
for (int i = 0; i < number_of_markers; i++) {
vec2 marker_position = i < CACHE_SIZE ? cached_marker_positions[i] : marker_positions[i];

Use parenthesis around the test and cast CACHE_SIZE to int. Same thing for marker_color.

Use parenthesis around the test and cast `CACHE_SIZE` to `int`. Same thing for `marker_color`.
OmarEmaraDev marked this conversation as resolved
Omar Emara added 2 commits 2023-10-02 09:42:55 +02:00
Clément Foucault approved these changes 2023-10-02 10:33:16 +02:00
Sergey Sharybin reviewed 2023-10-02 11:51:33 +02:00
@ -57,2 +57,4 @@
/** Animation data (must be immediately after id for utilities to use it). */
struct AnimData *adt;
/* runtime (must be immediately after id for utilities to use it). */
DrawDataList drawdata;

Can this me in the MovieClip_Runtime ?

I also don't really understand the comment or requirement. It is already not after id, and presumable things work just fine?

Can this me in the `MovieClip_Runtime` ? I also don't really understand the comment or requirement. It is already not after `id`, and presumable things work just fine?
Author
Member

@Sergey I copied the comment from similar IDs, so didn't think it through. But I shall update all similar IDs in a cleanup commit. It should say after the AnimData member and reference the template type.

See IdDdtTemplate and DRW_drawdatalist_from_id to understand this requirement. This should also explain why it can't be part of MovieClip_Runtime.

@Sergey I copied the comment from similar IDs, so didn't think it through. But I shall update all similar IDs in a cleanup commit. It should say after the `AnimData` member and reference the template type. See `IdDdtTemplate` and `DRW_drawdatalist_from_id` to understand this requirement. This should also explain why it can't be part of `MovieClip_Runtime`.

Ah, I see. Seems a bit unintuitive, but is not related to this patch.

Ah, I see. Seems a bit unintuitive, but is not related to this patch.
OmarEmaraDev marked this conversation as resolved
Sergey Sharybin approved these changes 2023-10-02 12:11:10 +02:00
Omar Emara added 1 commit 2023-10-04 07:33:44 +02:00
Omar Emara merged commit 17bdf18397 into main 2023-10-04 07:35:15 +02:00
Omar Emara deleted branch gpu-keying-screen 2023-10-04 07:35:17 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113055
No description provided.