Fix #113038: Box projection rotation inconsistent for dominant Z axis #113064

Closed
Philipp Oeser wants to merge 1 commits from lichtwerk/blender:113038 into blender-v4.0-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

While rotation might seem a bit arbitrary in box, it seems it would make
sense to match orientation we would get from flat projection.

This is want this PR does (for Cycles [incl OSL] and EEVEE).

As this might change the look of many old files, the motivation should
really have its justification (not totally sure about this, but previous
behavior does seem inconsistent and 4.0 might be the chance to rectify).

While rotation might seem a bit arbitrary in box, it seems it would make sense to match orientation we would get from flat projection. This is want this PR does (for Cycles [incl OSL] and EEVEE). As this might change the look of many old files, the motivation should really have its justification (not totally sure about this, but previous behavior does seem inconsistent and 4.0 might be the chance to rectify).
Philipp Oeser added 1 commit 2023-09-29 16:19:07 +02:00
While rotation might seem a bit arbitrary in box, it seems it would make
sense to match orientation we would get from flat projection.

This is want this PR does (for Cycles [incl OSL] and EEVEE).

As this might change the look of many old files, the motivation should
really have its justification (not totally sure about this, but previous
behavior does seem inconsistent and 4.0 might be the chance to rectify).
Philipp Oeser added this to the Render & Cycles project 2023-09-29 16:19:17 +02:00
Philipp Oeser added the
Interest
EEVEE & Viewport
label 2023-09-29 16:19:24 +02:00
Philipp Oeser requested review from Brecht Van Lommel 2023-09-29 16:19:31 +02:00
Philipp Oeser requested review from Clément Foucault 2023-09-29 16:19:37 +02:00

I don't really have a strong opinion on this. The changes make sense but I'm not sure it is worth breaking all scenes.

I don't really have a strong opinion on this. The changes make sense but I'm not sure it is worth breaking all scenes.

I don't like breaking compatibility much, and I'm not sure it's worth it.

We could perhaps rename "Box" to "Box (YX)" and add new default a "Box (XY)" option? Not sure I like it much, but maybe some user control is convenient here anyway?

I don't like breaking compatibility much, and I'm not sure it's worth it. We could perhaps rename "Box" to "Box (YX)" and add new default a "Box (XY)" option? Not sure I like it much, but maybe some user control is convenient here anyway?
Clément Foucault requested changes 2023-10-05 12:54:24 +02:00
Clément Foucault left a comment
Member

While I think this is a valid fix. I have to admit that breaking old files or adding a new option is not good either way.

Best idea I have to make this work is to make a node group that emulate this legacy behavior on older files (3 independent projection with mix nodes).

If we don't want to have this versioning code, I think it is just best to label as known issue.

While I think this is a valid fix. I have to admit that breaking old files or adding a new option is not good either way. Best idea I have to make this work is to make a node group that emulate this legacy behavior on older files (3 independent projection with mix nodes). If we don't want to have this versioning code, I think it is just best to label as known issue.
Author
Member

Upon @fclem request, rather not leave PRs that are not in active developement opened It can be reopened if needed

Upon @fclem request, rather not leave PRs that are not in active developement opened It can be reopened if needed
Philipp Oeser closed this pull request 2024-07-15 16:06:48 +02:00

Pull request closed

Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113064
No description provided.