Fix #113038: Box projection rotation inconsistent for dominant Z axis #113064

Open

Philipp Oeser wants to merge 1 commits from lichtwerk/blender:113038 into blender-v4.0-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Philipp Oeser commented

2023-09-29 16:18:56 +02:00

Member

While rotation might seem a bit arbitrary in box, it seems it would make
sense to match orientation we would get from flat projection.

This is want this PR does (for Cycles [incl OSL] and EEVEE).

As this might change the look of many old files, the motivation should
really have its justification (not totally sure about this, but previous
behavior does seem inconsistent and 4.0 might be the chance to rectify).

While rotation might seem a bit arbitrary in box, it seems it would make sense to match orientation we would get from flat projection. This is want this PR does (for Cycles [incl OSL] and EEVEE). As this might change the look of many old files, the motivation should really have its justification (not totally sure about this, but previous behavior does seem inconsistent and 4.0 might be the chance to rectify).

Philipp Oeser added 1 commit 2023-09-29 16:19:07 +02:00

93670e8fb4 Fix #113038 : Box projection rotation inconsistent for dominant Z axis

While rotation might seem a bit arbitrary in box, it seems it would make
sense to match orientation we would get from flat projection.

This is want this PR does (for Cycles [incl OSL] and EEVEE).

As this might change the look of many old files, the motivation should
really have its justification (not totally sure about this, but previous
behavior does seem inconsistent and 4.0 might be the chance to rectify).

Philipp Oeser added this to the Render & Cycles project 2023-09-29 16:19:17 +02:00

Philipp Oeser added the

EEVEE & Viewport

label 2023-09-29 16:19:24 +02:00

Philipp Oeser requested review from Brecht Van Lommel 2023-09-29 16:19:31 +02:00

Philipp Oeser requested review from Clément Foucault 2023-09-29 16:19:37 +02:00

Clément Foucault commented

2023-09-29 20:47:20 +02:00

Member

I don't really have a strong opinion on this. The changes make sense but I'm not sure it is worth breaking all scenes.

I don't really have a strong opinion on this. The changes make sense but I'm not sure it is worth breaking all scenes.

Brecht Van Lommel commented

2023-10-03 19:55:29 +02:00

Owner

I don't like breaking compatibility much, and I'm not sure it's worth it.

We could perhaps rename "Box" to "Box (YX)" and add new default a "Box (XY)" option? Not sure I like it much, but maybe some user control is convenient here anyway?

I don't like breaking compatibility much, and I'm not sure it's worth it. We could perhaps rename "Box" to "Box (YX)" and add new default a "Box (XY)" option? Not sure I like it much, but maybe some user control is convenient here anyway?

Clément Foucault requested changes 2023-10-05 12:54:24 +02:00

Clément Foucault left a comment

Member

While I think this is a valid fix. I have to admit that breaking old files or adding a new option is not good either way.

Best idea I have to make this work is to make a node group that emulate this legacy behavior on older files (3 independent projection with mix nodes).

If we don't want to have this versioning code, I think it is just best to label as known issue.

While I think this is a valid fix. I have to admit that breaking old files or adding a new option is not good either way. Best idea I have to make this work is to make a node group that emulate this legacy behavior on older files (3 independent projection with mix nodes). If we don't want to have this versioning code, I think it is just best to label as known issue.

Philipp Oeser referenced this pull request

2023-10-11 12:18:37 +02:00

shader editor's image texture node is aligning image to the wrong local axis when box projection is used. #113038

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 113038:lichtwerk-113038

git checkout lichtwerk-113038

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113064

No description provided.