Fix #113044: Reset Fonts When Loading New Files #113104

Harley Acheson · 2023-10-01T05:30:25+02:00

Harley Acheson commented

2023-10-01 05:30:25 +02:00

Close user-loaded fonts when loading a new blend file so that the
global_font slots are not taken up by the old file's fonts.

We maintain the list of current fonts in an array called global_font. We add a font id to this when opening a font, and remove them with calls to BLF_unload, BLF_unload_id, and BLF_unload_all. However, when loading new blend files this array remains populated with the old files.

Therefore, as illustrated in #113044, if you start Blender, load a blend file that uses 40 unique fonts, then load a blend file containing 40 different fonts, you could get a "Too many fonts!!!" errror.

We clear the list in BLF_init(), called only from WM_init in main during program startup. We also clear the list in BLF_exit() from WM_exit when closing down. We don't want to close and reinitialize FreeType, nor do we want to call uiStyleInit (which also closes all fonts) as that can duplicate items in the uifonts list.

Basically we don't want to close all files anyway. This PR just closes the fonts not used by the UI. So ones that are not the current UI font, not the usual UI font, nor mono, nor anything in the font stack.

Close user-loaded fonts when loading a new blend file so that the global_font slots are not taken up by the old file's fonts. --- We maintain the list of current fonts in an array called `global_font`. We add a font id to this when opening a font, and remove them with calls to BLF_unload, BLF_unload_id, and BLF_unload_all. However, when loading new blend files this array remains populated with the old files. Therefore, as illustrated in #113044, if you start Blender, load a blend file that uses 40 unique fonts, then load a blend file containing 40 different fonts, you could get a "Too many fonts!!!" errror. We clear the list in BLF_init(), called only from WM_init in main during program startup. We also clear the list in BLF_exit() from WM_exit when closing down. We don't want to close and reinitialize FreeType, nor do we want to call `uiStyleInit` (which also closes all fonts) as that can duplicate items in the uifonts list. Basically we don't want to close all files anyway. This PR just closes the fonts not used by the UI. So ones that are not the current UI font, not the usual UI font, nor mono, nor anything in the font stack.

Harley Acheson added 1 commit 2023-10-01 05:30:39 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

02ee5e22c9 Fix #113044 : Reset Fonts When Loading New Files

Close user-loaded fonts when loading a new blend file so that the
global_font slots are not taken up by the old file's fonts.

Harley Acheson added this to the User Interface project 2023-10-01 05:30:51 +02:00

Harley Acheson requested review from Brecht Van Lommel 2023-10-01 05:30:58 +02:00

Harley Acheson changed title from ~~Fix #113044: Reset Fonts When Loading New Files~~ to Fix #113044: Reset Fonts When Loading New Files

2023-10-01 17:37:14 +02:00

Harley changed target branch from main to blender-v4.0-release

2023-10-01 17:37:16 +02:00

Brecht Van Lommel approved these changes 2023-10-02 14:12:26 +02:00

Harley Acheson commented

2023-10-02 20:04:19 +02:00

@blender-bot build

Harley Acheson merged commit e196f0a874 into blender-v4.0-release

2023-10-03 01:21:10 +02:00

Harley Acheson referenced this issue from a commit

2023-10-03 01:21:11 +02:00

Fix #113044: Reset Fonts When Loading New Files

Harley Acheson deleted branch Fix113044

2023-10-03 01:21:14 +02:00

Joseph Eagar referenced this issue from a commit

2023-10-07 21:46:17 +02:00

Fix #113044: Reset Fonts When Loading New Files

Joseph Eagar referenced this issue from a commit

2023-10-07 21:46:18 +02:00

Fix #113044: Reset Fonts When Loading New Files

Colin Basnett referenced this issue from a commit

2023-10-08 23:38:52 +02:00

Fix #113044: Reset Fonts When Loading New Files

Philipp Oeser referenced this issue from a commit

2023-10-12 13:02:01 +02:00

Fix #113044: Reset Fonts When Loading New Files

Philipp Oeser referenced this issue from a commit

2023-10-12 13:54:53 +02:00

Fix #113044: Reset Fonts When Loading New Files

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113044: Reset Fonts When Loading New Files #113104