Vulkan: Support for Framebuffer with Missing Attachments #113141

Merged

Jeroen Bakker merged 9 commits from Jeroen-Bakker/blender:vulkan/wireframe-shading-mode into main

2023-10-10 09:27:14 +02:00

Jeroen Bakker commented

2023-10-02 12:58:01 +02:00

Member

Wireframe mode wasn't working and viewport had flickering artifacts.
Reason was that the render pass creation failed for its framebuffer as
the input data was filled with garbage for attachments that were unused.

Vulkan requires every attachment to be filled upto the highest used attachment
slot. This PR fills missing attachments with a dummy texture.

Wireframe mode wasn't working and viewport had flickering artifacts. Reason was that the render pass creation failed for its framebuffer as the input data was filled with garbage for attachments that were unused. Vulkan requires every attachment to be filled upto the highest used attachment slot. This PR fills missing attachments with a dummy texture.

Jeroen Bakker added 2 commits 2023-10-02 12:58:10 +02:00

c1e3a67117 Use dummy textures for unused framebuffer attachments.

9008d37f8b Fix blend state size

Jeroen Bakker referenced this pull request

2023-10-02 13:00:04 +02:00

Vulkan: Enable as Experimental Option #113057

Jeroen Bakker referenced this issue from a commit

2023-10-06 15:24:32 +02:00

Vulkan: Enable as Experimental Option

Jeroen Bakker added 4 commits 2023-10-10 08:44:30 +02:00

ee47417795 Moved to device

c89f6a51a8 Merge branch 'main' into vulkan/wireframe-shading-mode

7b5d7ee89d Merge branch 'main' into vulkan/wireframe-shading-mode

2dbc77069d Fix memory leak

Jeroen Bakker added 1 commit 2023-10-10 08:55:59 +02:00

94d0799146 Reduce code complexity.

Jeroen Bakker added 1 commit 2023-10-10 09:07:37 +02:00

d6b4b3a138 Remove unused include

Jeroen Bakker added 1 commit 2023-10-10 09:24:02 +02:00

b2925f72c7 Reduce code complexity.

Jeroen Bakker added the

label 2023-10-10 09:25:15 +02:00

Jeroen Bakker added this to the 4.1 milestone 2023-10-10 09:25:19 +02:00

Jeroen Bakker added this to the EEVEE & Viewport project 2023-10-10 09:25:22 +02:00

Jeroen Bakker self-assigned this 2023-10-10 09:25:26 +02:00

Jeroen Bakker referenced this issue from a commit

2023-10-10 09:27:14 +02:00

Vulkan: Support for Framebuffer with Missing Attachments

Jeroen Bakker merged commit d67ec32747 into main

2023-10-10 09:27:14 +02:00

Kazashi Yoshioka commented

2023-10-10 11:52:46 +02:00

Contributor

we can leave unused attachments by using VK_ATTACHMENT_UNUSED.
(vk_framebuffer)[f3dc49f605/source/blender/gpu/vulkan/vk_framebuffer.cc (L1041)]

we can leave unused attachments by using `VK_ATTACHMENT_UNUSED`. (vk_framebuffer)[https://projects.blender.org/vnapdv/blender/src/commit/f3dc49f60505c0da94759c7123d148721a073727/source/blender/gpu/vulkan/vk_framebuffer.cc#L1041]

Jeroen Bakker commented

2023-10-10 12:00:00 +02:00

Author

Member

@vnapdv in the renderpass they can be left unused, but in the list of image views they still need to exist according to the vulkan specs. https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkFramebufferCreateInfo.html#VUID-VkFramebufferCreateInfo-flags-02778

If flags does not include VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT and attachmentCount is not 0, pAttachments must be a valid pointer to an array of attachmentCount valid VkImageView handles

Having a framebuffer that for example has a color attachement on slot 1, but not on slot 0, slot 0 still needs to be filled with a valid handle. Other solutions would be to change the binding points in the shader, But that would reduce performance as Blender allows skipping attachment slots by design.

@vnapdv in the renderpass they can be left unused, but in the list of image views they still need to exist according to the vulkan specs. https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkFramebufferCreateInfo.html#VUID-VkFramebufferCreateInfo-flags-02778 >If flags does not include VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT and attachmentCount is not 0, pAttachments must be a valid pointer to an array of attachmentCount valid VkImageView handles Having a framebuffer that for example has a color attachement on slot 1, but not on slot 0, slot 0 still needs to be filled with a valid handle. Other solutions would be to change the binding points in the shader, But that would reduce performance as Blender allows skipping attachment slots by design.

Kazashi Yoshioka commented

2023-10-10 12:05:18 +02:00

Contributor

In my implementation, Image-view is not necessary. If you set VK_ATTACHMENT_UNUSED to attachment 0 in the subpass descriptions, you can actually set the reference of attachment 1 to 0, so there is only one Image-view and there is no need to change the shader.

In my implementation, Image-view is not necessary. If you set VK_ATTACHMENT_UNUSED to attachment 0 in the subpass descriptions, you can actually set the reference of attachment 1 to 0, so there is only one Image-view and there is no need to change the shader.

Jeroen Bakker commented

2023-10-10 12:07:14 +02:00

Author

Member

I see, yes that could also work

I see, yes that could also work

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113141

No description provided.