Realtime Compositor: Implement File Output node #113204

Omar Emara · 2023-10-03T14:36:55+02:00

Omar Emara commented

2023-10-03 14:36:55 +02:00

This patch implements the File Output node for the Realtime Compositor.

Omar Emara added 1 commit 2023-10-03 14:37:07 +02:00

3332c3432d Realtime Compositor: Implement File Output node

This patch implements the File Output node for the Realtime Compositor.

Omar Emara added 1 commit 2023-10-04 19:11:19 +02:00

86d1bfc600 Implement single layer file writers

Omar Emara added 1 commit 2023-10-05 10:49:18 +02:00

a4a90158ac Add single layer EXR

Omar Emara changed title from ~~WIP: Realtime Compositor: Implement File Output node~~ to Realtime Compositor: Implement File Output node

2023-10-05 12:21:19 +02:00

Omar Emara requested review from Sergey Sharybin 2023-10-05 12:21:29 +02:00

Omar Emara added the

labels 2023-10-05 12:21:46 +02:00

Omar Emara added 2 commits 2023-10-05 14:37:15 +02:00

379213cf0c Merge branch 'main' into gpu-file-output-node

25fea16a72 Fix memory leak in image format copy

Sergey Sharybin requested changes 2023-10-09 16:55:01 +02:00

Sergey Sharybin left a comment

I think the much better implementation would avoid having such a large chunk of duplicated code w.r.t the existing file output node.

The way I'd do it is by constructing temporary RenderResult with passes which match the node sockets (do it from both CPU and GPU compositor), and leave the actual file IO to a dedicated function, which will decide on file naming etc and refer the actual saving to BKE_image_render_write_exr/BKE_image_render_write.

There is already seems to be discrepancy in the way how stamping is handled.

I think the much better implementation would avoid having such a large chunk of duplicated code w.r.t the existing file output node. The way I'd do it is by constructing temporary `RenderResult` with passes which match the node sockets (do it from both CPU and GPU compositor), and leave the actual file IO to a dedicated function, which will decide on file naming etc and refer the actual saving to `BKE_image_render_write_exr`/`BKE_image_render_write`. There is already seems to be discrepancy in the way how stamping is handled.

Sergey Sharybin requested review from Brecht Van Lommel 2023-10-09 16:55:20 +02:00

Omar Emara commented

2023-10-09 18:47:43 +02:00

I will look into that. The main issue I see immediately is that multi-view saving would need a cross-evaluation storage mechanism similar to global EXR handles used here, which would need to be a separate implementation for both GPU and CPU compositors. So I suspect we will likely end up having more duplicate and complex code than what we have now.

Brecht Van Lommel reviewed 2023-10-09 19:54:26 +02:00

source/blender/nodes/composite/nodes/node_composite_output_file.cc

						
				@ -454,0 +493,4 @@

				     * even this compositor evaluation. This is useful for multi-view images, since the compositor

				     * is dispatched multiple times for each of the views, so we need a global resource to add all

				     * views to the same EXR image. The EXR is then only written once the last view was added. */

				    void *exr_handle = IMB_exr_get_handle_name(image_path);

Brecht Van Lommel commented

2023-10-09 19:53:36 +02:00

Does this exr handle leak when a multiview render is interrupted?

Omar Emara commented

2023-10-09 20:24:30 +02:00

I am not sure, but if the render pipeline can be interrupted before the last view is executed, which seems to be the case looking at the code, then I guess yes, it will leak. This seems to be the case for the CPU compositor as well, so I guess this mechanism can't be used anyways ...

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Realtime Compositor: Implement File Output node #113204

Pull request closed