Mesh: Add flag to store presence of overlapping topology #113205

Merged
Hans Goudey merged 3 commits from HooglyBoogly/blender:mesh-overlapping-flag into main 2023-11-15 14:02:59 +01:00
Member

For improving performance in the triangulate node, it's very helpful to
know whether the mesh has edges or faces that overlap each other.
If that is known to be false, the node can skip edge deduplication.
This might apply to the future "Replace Faces" node as well.

This information is stored as a flag on the mesh and set in various
places that create "clean" new meshes. It isn't calculated lazily unlike
other other areas, because the point is to improve performance, and
the calculation probably isn't faster than the duplication check it's
meant to replace.

For improving performance in the triangulate node, it's very helpful to know whether the mesh has edges or faces that overlap each other. If that is known to be false, the node can skip edge deduplication. This might apply to the future "Replace Faces" node as well. This information is stored as a flag on the mesh and set in various places that create "clean" new meshes. It isn't calculated lazily unlike other other areas, because the point is to improve performance, and the calculation probably isn't faster than the duplication check it's meant to replace.
Hans Goudey added 1 commit 2023-10-03 14:38:59 +02:00
3bb905a6fc Mesh: Add flag to store presence of overlapping topology
For improving performance in the triangulate node, it's very helpful to
know whether the mesh has edges or faces that overlap each other.
If that is known to be false, the node can skip edge deduplication.

Since this property doesn't often change as part of mesh processing
operations, it's simple to store it once. Currently this is done using
a `SharedCache`, though there is no lazy computation since I'm not
sure it would be worth it.
Hans Goudey added 2 commits 2023-11-14 12:52:33 +01:00
Hans Goudey changed title from WIP: Mesh: Add flag to store presence of overlapping topology to Mesh: Add flag to store presence of overlapping topology 2023-11-14 12:56:05 +01:00
Hans Goudey added the
Interest
Geometry Nodes
Interest
Modeling
labels 2023-11-14 12:58:19 +01:00
Hans Goudey requested review from Jacques Lucke 2023-11-14 12:58:24 +01:00
Jacques Lucke approved these changes 2023-11-15 11:35:40 +01:00
Hans Goudey merged commit 9785f2631e into main 2023-11-15 14:02:59 +01:00
Hans Goudey deleted branch mesh-overlapping-flag 2023-11-15 14:03:00 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113205
No description provided.