Fix #112729: Blender don`t has icon on taskbar #113321

Closed
Guillermo Venegas wants to merge 1 commits from guishe:win-app-id into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Contributor

Registering PKEY_AppUserModel_ID with same ID will make
all installations of Blender share the same taskbar group
on Windows, and pinning Blender in the taskbar will create
a ImplicitAppShortcut that also will be shared between
all installations with the same ID. However if the shortcut
that the ImplicitAppShortcut points is removed, running other
installation of Blender with the same already registered ID will show
a missing icon in the taskbar.

To prevent that, this APP ID will also include a hash of the
installation folder.

With this changes different Blender installations with the same version
will have different Pinning Groups in the taskbar.

Registering `PKEY_AppUserModel_ID` with same ID will make all installations of Blender share the same taskbar group on Windows, and pinning Blender in the taskbar will create a `ImplicitAppShortcut` that also will be shared between all installations with the same ID. However if the shortcut that the `ImplicitAppShortcut` points is removed, running other installation of Blender with the same already registered ID will show a missing icon in the taskbar. To prevent that, this APP ID will also include a hash of the installation folder. With this changes different Blender installations with the same version will have different Pinning Groups in the taskbar.
Guillermo Venegas added 1 commit 2023-10-06 06:11:41 +02:00
Author
Contributor

This video shows that different Blender installations with the same version will have different Pinning Groups in the taskbar.

This video shows that different Blender installations with the same version will have different Pinning Groups in the taskbar. <video src="/attachments/90be2f36-4cf8-460e-84fc-6bbb324d58d0" title="2023-10-05 22-13-10.mp4" controls></video>
Iliya Katushenock added this to the Platforms, Builds Tests & Devices project 2023-10-06 06:20:53 +02:00
Iliya Katushenock added the
Platform
Windows
label 2023-10-06 06:21:00 +02:00
Guillermo Venegas requested review from Ray molenkamp 2023-10-06 19:18:24 +02:00
Member

This patch is lacking the changes requires in the file registration to make jumplists work, however moot point...

I should have probably left a comment on that bug, i wasn't expecting anyone but @Harley to work on it and he was fully booked. I tried this same solution as well, but turns out adding the hash was a really bad idea of mine for the following reasons :

1 - You register 10 blenders from different daily builds, they all show up in the open with menu, all with blender 4.0 as title, with no way to tell what is what
2 - You can't unregister them unless you unregister from the exact path they were registered in, odds are people won't remember so you end up with a bunch of registrations you can't get rid off.

The solution is actually much worse than the bug it is trying to solve.

I ended up implementing updating the path to blender in the the .lnk in the user profile, which turned out to be not too bad but due to time restrictions haven't gotten around to posting a pull for it just yet.

This patch is lacking the changes requires in the file registration to make jumplists work, however moot point... I should have probably left a comment on that bug, i wasn't expecting anyone but @Harley to work on it and he was fully booked. I tried this same solution as well, but turns out adding the hash was a really bad idea of mine for the following reasons : 1 - You register 10 blenders from different daily builds, they all show up in the open with menu, all with blender 4.0 as title, with no way to tell what is what 2 - You can't unregister them unless you unregister from the exact path they were registered in, odds are people won't remember so you end up with a bunch of registrations you can't get rid off. The solution is actually much worse than the bug it is trying to solve. I ended up implementing updating the path to blender in the the .lnk in the user profile, which turned out to be not too bad but due to time restrictions haven't gotten around to posting a pull for it just yet.
Ray molenkamp closed this pull request 2023-10-07 02:21:32 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113321
No description provided.