Fix #87160: Clean Keyframes only works if channels are selected #113335

Christoph Lendenfeld · 2023-10-06T12:43:54+02:00

2023-10-06 12:43:54 +02:00

The issue was that the code filtered for selected channels,
while the expectation was that it would only filter for selected keys.

This PR changes the behavior of the operator in the following way:

when "Clean Channels" is disabled, it will clean only selected keyframes, regardless of the channel selection
when "Clean Channels" is enabled, it will clean selected channels regardless of keyframe selection

The same logic was applied to the Graph Editor code.
It only makes a difference in the case when "Clean Channels" is enabled.
That is because channels were automatically selected when a key was selected.

In addition to that I moved the menu entry for "Clean Channels" to the channel menu
to reduce confusion.

Another solution would have been to make the Dope Sheet select channels
when keys are selected. This might still be done in the future, but I think the
only correct fix is to change the actual operator behavior.

The issue was that the code filtered for selected channels, while the expectation was that it would only filter for selected keys. This PR changes the behavior of the operator in the following way: * when "Clean Channels" is **disabled**, it will clean only selected keyframes, regardless of the channel selection * when "Clean Channels" is **enabled**, it will clean selected channels regardless of keyframe selection The same logic was applied to the Graph Editor code. It only makes a difference in the case when "Clean Channels" is enabled. That is because channels were automatically selected when a key was selected. In addition to that I moved the menu entry for "Clean Channels" to the channel menu to reduce confusion. Another solution would have been to make the Dope Sheet select channels when keys are selected. This might still be done in the future, but I think the only correct fix is to change the actual operator behavior.

Christoph Lendenfeld added this to the 4.0 milestone 2023-10-06 12:43:54 +02:00

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-10-06 12:43:54 +02:00

Christoph Lendenfeld added 1 commit 2023-10-06 12:44:12 +02:00

478e81a7cf fix clean channels confusion

Sybren A. Stüvel approved these changes 2023-10-06 12:53:03 +02:00

Sybren A. Stüvel left a comment

I think this is a good approach. It also makes it much clearer what the two "Clean XXX" versions actually do.

Christoph Lendenfeld referenced this issue from a commit

2023-10-06 13:51:13 +02:00

Fix #87160: Clean Keyframes only works if channels are selected

Christoph Lendenfeld merged commit d85e7f4577 into blender-v4.0-release

2023-10-06 13:51:14 +02:00

Christoph Lendenfeld deleted branch fix_dope_sheet_clean_channel

2023-10-06 13:51:18 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #87160: Clean Keyframes only works if channels are selected #113335