Fix #113346: Append/Link fails if no name is specified #113350

Merged
Harley Acheson merged 1 commits from lichtwerk/blender:113346 into blender-v4.0-release 2023-10-09 18:29:59 +02:00
Member

Caused by fa29d28d73 .

Code used to work like this:

  • if items are selected, these are considered for Append/Link
    -- name is ignored in that case
  • if no items are selected, the name is considered for Append/Link

Selection with the mouse usually sets the name as well (unnecessarily
even) -- so this still worked fine even after fa29d28d73 .
Selecting All with 'A' does not set a name, but code from fa29d28d73
added the additional check to the early out and reports an error.

Now remove the additional check again, the logic following that code
takes care of handling ether selected items or a provided name just
fine.

Caused by fa29d28d731e . Code used to work like this: - if items are selected, these are considered for Append/Link -- name is ignored in that case - if no items are selected, the name is considered for Append/Link Selection with the mouse usually sets the name as well (unnecessarily even) -- so this still worked fine even after fa29d28d731e . Selecting All with 'A' does not set a name, but code from fa29d28d731e added the additional check to the early out and reports an error. Now remove the additional check again, the logic following that code takes care of handling ether selected items or a provided name just fine.
Philipp Oeser added 1 commit 2023-10-06 16:20:43 +02:00
c2d5fc91ec Fix #113346: Append/Link fails if no name is specified
Caused by fa29d28d73 .

Code used to work like this:
- if items are selected, these are considered for Append/Link
-- name is ignored in that case
- if no items are selected, the name is considered for Append/Link

Selection with the mouse usually sets the name as well (unnecessarily
even) -- so this still worked fine even after fa29d28d73 .
Selecting All with 'A' does not set a name, but code from fa29d28d73
added the additional check to the early out and reports an error.

Now remove the additional check again, the logic following that code
takes care of handling ether selected items or a provided name just
fine.
Philipp Oeser requested review from Bastien Montagne 2023-10-06 16:20:51 +02:00
Philipp Oeser added this to the User Interface project 2023-10-06 16:20:57 +02:00
Philipp Oeser added the
Interest
Pipeline, Assets & IO
label 2023-10-06 16:21:06 +02:00
Harley Acheson requested review from Harley Acheson 2023-10-09 18:24:21 +02:00
Harley Acheson approved these changes 2023-10-09 18:26:15 +02:00
Harley Acheson left a comment
Member

I didn't notice that you had picked this one up and got to this exact solution.

I didn't notice that you had picked this one up and got to this exact solution.
Harley Acheson merged commit 78489af86a into blender-v4.0-release 2023-10-09 18:29:58 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113350
No description provided.