Fix #113340: Socket naming consistency #113353

Amine Bensalem · 2023-10-06T17:25:02+02:00

Amine Bensalem commented

2023-10-06 17:25:02 +02:00

fixed geometry node socket output name for issue #113340 to "Points".

fixed geometry node socket output name for issue #113340 to "Points". ![image](/attachments/ac3fc960-d819-43f9-9e18-010945267fce)

image.png

6.7 KiB

Amine Bensalem added 1 commit 2023-10-06 17:25:18 +02:00

ec1ab249c3 Fix issue #113340 : Fixed typo on the Points node's socket output name

Iliya Katushenock changed title from ~~WIP:UI: issue #113340 : Fixed typo on the Points node's socket output name~~ to WIP: Fix #113340: Socket naming consistency

2023-10-06 17:44:03 +02:00

Iliya Katushenock added this to the Nodes & Physics project 2023-10-06 17:44:10 +02:00

Iliya Katushenock added the

Interest

Geometry Nodes

label 2023-10-06 17:44:36 +02:00

Hans Goudey approved these changes 2023-10-06 19:07:06 +02:00

Hans Goudey requested changes 2023-10-06 19:07:17 +02:00

Hans Goudey left a comment

This makes sense to me. It's better to just adjust the socket name though, and not the identifier. The add_output has arguments for changing them separately.

Unfortunately because of some bad design mixup, this currently does affect the Python API, so we'd have to decide whether this is worth it.

This makes sense to me. It's better to just adjust the socket name though, and not the identifier. The `add_output` has arguments for changing them separately. Unfortunately because of some bad design mixup, this currently does affect the Python API, so we'd have to decide whether this is worth it.

👍 1

Amine Bensalem commented

2023-10-06 22:44:48 +02:00

This makes sense to me. It's better to just adjust the socket name though, and not the identifier. The add_output has arguments for changing them separately.

Unfortunately because of some bad design mixup, this currently does affect the Python API, so we'd have to decide whether this is worth it.

Fair enough.
Should I wait until this has been discussed or should I make another commit in the meantime ?

> This makes sense to me. It's better to just adjust the socket name though, and not the identifier. The `add_output` has arguments for changing them separately. > > Unfortunately because of some bad design mixup, this currently does affect the Python API, so we'd have to decide whether this is worth it. Fair enough. Should I wait until this has been discussed or should I make another commit in the meantime ?

Amine Bensalem force-pushed UI_geometry_nodes from a46f7f5efa to 3f87fff839

2023-10-07 03:50:13 +02:00

Compare

Amine Bensalem requested review from Hans Goudey 2023-10-07 03:52:35 +02:00

Amine Bensalem commented

2023-10-07 03:57:27 +02:00

@HooglyBoogly
Hi , I modified the renaming using "Geometry" as identifier , and "Points" as the name.
On my side , it works, although I've noticed crashes when linking various nodes ... I'm still not sure yet if the culprit is this piece of code , or something related to #113336

@HooglyBoogly Hi , I modified the renaming using "Geometry" as identifier , and "Points" as the name. On my side , it works, although I've noticed crashes when linking various nodes ... I'm still not sure yet if the culprit is this piece of code , or something related to #113336

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113340: Socket naming consistency #113353