Fix assert in PBVH face set drawing code #113354

Sergey Sharybin · 2023-10-06T17:38:54+02:00

Sergey Sharybin commented

2023-10-06 17:38:54 +02:00

The assert was assuming that the attribute request is properly
initialized and that was not the case: the "special" data layers
like coordinates, normals, masks, and face sets did not initialize
domain in the attribute request.

The domain is now properly initialized. As well as there is an
assert added in other PBVH types for the face sets. It is possible
to add asserts in more places, but it is not directly related to
this CL.

The assert was assuming that the attribute request is properly initialized and that was not the case: the "special" data layers like coordinates, normals, masks, and face sets did not initialize domain in the attribute request. The domain is now properly initialized. As well as there is an assert added in other PBVH types for the face sets. It is possible to add asserts in more places, but it is not directly related to this CL.

Sergey Sharybin added the

Module

Sculpt, Paint & Texture

label 2023-10-06 17:38:54 +02:00

Sergey Sharybin added 1 commit 2023-10-06 17:39:05 +02:00

798732b2ec Fix assert in PBVH face set drawing code

The assert was assuming that the attribute request is properly
initialized and that was not the case: the "special" data layers
like coordinates, normals, masks, and face sets did not initialize
domain in the attribute request.

The domain is now properly initialized. As well as there is an
assert added in other PBVH types for the face sets. It is possible
to add asserts in more places, but it is not directly related to
this CL.

Sergey Sharybin requested review from Hans Goudey 2023-10-06 17:39:14 +02:00

Hans Goudey approved these changes 2023-10-06 18:00:25 +02:00

Hans Goudey left a comment

struct -> class isn't really necessary here, but the change seems reasonable anyway.

`struct` -> `class` isn't really necessary here, but the change seems reasonable anyway.

Hans Goudey merged commit 9a44445667 into main

2023-10-06 18:06:07 +02:00

Hans Goudey referenced this issue from a commit

2023-10-06 18:06:09 +02:00

Fix assert in PBVH face set drawing code

Dalai Felinto referenced this issue from a commit

2023-10-08 20:21:15 +02:00

Fix assert in PBVH face set drawing code

Sergey Sharybin deleted branch sculpt_fix_fset_assert

2023-10-31 16:33:30 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix assert in PBVH face set drawing code #113354