Fix #113352: UI: Round Pen When Subpixel AA is Off #113399

Merged
Harley Acheson merged 1 commits from Harley/blender:AAoffRound into blender-v4.0-release 2023-10-12 20:55:04 +02:00
Member

When "Subpixel Anti-Aliasing" is turned OFF then the spacing is nicer
if the advancing pen position is rounded.


Will make builds for testing.

When "Subpixel Anti-Aliasing" is turned OFF then the spacing is nicer if the advancing pen position is rounded. --- Will make builds for testing.
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR113399) when ready.
Author
Member

@blender-bot package windows

@blender-bot package windows
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR113399) when ready.
Harley Acheson force-pushed AAoffRound from a0f9a5917d to b2086c761b 2023-10-12 01:24:09 +02:00 Compare
Harley Acheson changed title from WIP: UI: Round Pen When Subpixel AA is Off to WIP: UI: Round Pen When Subpixel AA is Off 2023-10-12 01:25:40 +02:00
Harley changed target branch from main to blender-v4.0-release 2023-10-12 01:25:42 +02:00
Author
Member

Feedback for this is here:

#113352 (comment)

#113352 (comment)

Feedback for this is here: https://projects.blender.org/blender/blender/issues/113352#issuecomment-1041003 https://projects.blender.org/blender/blender/issues/113352#issuecomment-1041714
Harley Acheson changed title from WIP: UI: Round Pen When Subpixel AA is Off to Fix #113352: UI: Round Pen When Subpixel AA is Off 2023-10-12 01:27:18 +02:00
Harley Acheson merged commit 1c4b2ad17f into blender-v4.0-release 2023-10-12 20:55:04 +02:00
Harley Acheson deleted branch AAoffRound 2023-10-12 20:55:08 +02:00
Member

Why does this change an existing assert in a different code location? The + 2 there seems quite arbitrary now, at least warrants a comment.

Why does this change an existing assert in a different code location? The `+ 2` there seems quite arbitrary now, at least warrants a comment.
Author
Member

Why does this change an existing assert in a different code location? The + 2 there seems quite arbitrary now, at least warrants a comment.

Good point. That particular assert has been the bane of my existence for years. I have added a Pulitzer Prize-winning comment there explaining why the assert is there and why it needs wriggle room.

> Why does this change an existing assert in a different code location? The `+ 2` there seems quite arbitrary now, at least warrants a comment. Good point. That particular assert has been the bane of my existence for years. I have added a Pulitzer Prize-winning comment there explaining why the assert is there and why it needs wriggle room.
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113399
No description provided.