Nodes: move socket declaration methods to base declaration builder #113410

Jacques Lucke · 2023-10-08T13:01:11+02:00

Jacques Lucke commented

2023-10-08 13:01:11 +02:00

The goal here is to make it easier to use the socket declaration builder
for cases where the actual socket type is not known at compile time.
For that purpose, all the methods that are not dependent on the specific
socket type are moved to the base socket declaration builder.

A nice side effect of this is reduced templated boilerplate and that more
code can be moved out of the header.

With this patch, one is now forced to put type specific method calls before
generic method calls in a chain. For example .default_value(...).supports_field()
instead of supports_field().default_value(...). In theory, we could keep
support for both orders but that would involve a lot of additional boilerplate
code. Enforcing this order is simple enough. Note that this limitation only
applies when chaining multiple method calls. This is still possible:

auto &decl = b.add_input<decl::Vector>("Value");
decl.supports_field();
decl.default_value(...);

The goal here is to make it easier to use the socket declaration builder for cases where the actual socket type is not known at compile time. For that purpose, all the methods that are not dependent on the specific socket type are moved to the base socket declaration builder. A nice side effect of this is reduced templated boilerplate and that more code can be moved out of the header. With this patch, one is now forced to put type specific method calls before generic method calls in a chain. For example `.default_value(...).supports_field()` instead of `supports_field().default_value(...)`. In theory, we could keep support for both orders but that would involve a lot of additional boilerplate code. Enforcing this order is simple enough. Note that this limitation only applies when chaining multiple method calls. This is still possible: ``` auto &decl = b.add_input<decl::Vector>("Value"); decl.supports_field(); decl.default_value(...); ```

Jacques Lucke added 7 commits 2023-10-08 13:01:23 +02:00

53f6deea9c initial steps to making dynamic sockets easier

a9914def8d move code out of header

15aa490f32 move comments to base declaration

8fcc3aa24c cleanup

5cae450262 remove templated wrappers

45898e3373 cleanup

buildbot/vexp-code-patch-coordinator Build done. Details

6809fd3743 cleanup

Jacques Lucke commented

2023-10-08 13:01:48 +02:00

@blender-bot build