Nodes: Use index instead of reordering for draw order #113419

Hans Goudey · 2023-10-08T18:29:59+02:00

Hans Goudey commented

2023-10-08 18:29:59 +02:00

Currently nodes are reordered so that the "on top" nodes are last in the
list. Node order changing for simple operations like selection means we
either have to reevaluate the node tree data-block on selections or
accept that the evaluated order can be different from the original.
Currently we do the latter (see d76a0e98ba), but makes it
complex to refer to nodes by index, and is hard to reason about.

Instead of reordering nodes, store the ui order in the node itself
and sort the nodes before drawing them or doing any processing
that depends on the "depth."

The "selected_nodes" list in the context is no longer ordered by the
recent selection.

Currently nodes are reordered so that the "on top" nodes are last in the list. Node order changing for simple operations like selection means we either have to reevaluate the node tree data-block on selections or accept that the evaluated order can be different from the original. Currently we do the latter (see d76a0e98baecfca4e691), but makes it complex to refer to nodes by index, and is hard to reason about. Instead of reordering nodes, store the ui order in the node itself and sort the nodes before drawing them or doing any processing that depends on the "depth." The "selected_nodes" list in the context is no longer ordered by the recent selection.

Hans Goudey added 1 commit 2023-10-08 18:30:13 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

7cb6e464bb Nodes: Use index instead of reordering for draw order

Currently nodes are reordered so that the "on top" nodes are last in the
list. Node order changing for simple operations like selection means we
either have to reevaluate the node tree data-block on selections or
accept that the evaluated order can be different from the original.
Currently we do the latter (see d76a0e98ba), but makes it
complex to refer to nodes by index, and is hard to reason about.

Instead of reordering nodes, store the ui order in the node itself
and sort the nodes before drawing them or doing any processing
that depends on the "depth."

Hans Goudey requested review from Jacques Lucke 2023-10-08 18:30:22 +02:00

Hans Goudey added this to the Nodes & Physics project 2023-10-08 18:30:27 +02:00

Hans Goudey commented

2023-10-08 18:30:59 +02:00

@blender-bot build

Jacques Lucke approved these changes 2023-10-08 19:58:53 +02:00

source/blender/editors/space_node/space_node.cc

						
				@ -1072,3 +1072,3 @@

				  if (CTX_data_equals(member, "selected_nodes")) {

				    if (snode->edittree) {

				      LISTBASE_FOREACH_BACKWARD (bNode *, node, &snode->edittree->nodes) {

				      for (bNode *node : snode->edittree->all_nodes()) {

Jacques Lucke commented

2023-10-08 19:58:28 +02:00

Looks like it was an intentional choice to add the nodes in a specific order to the list. I'm fine with changing it, but that should be mentioned in the commit. Also it may be necessary to expose the ui_order in rna. Addons also need the ability to figure out which order nodes are drawn in for some modal operators.

You could also try to figure when the order of nodes in context.selected_nodes became more explicit. Maybe some code relies on that currently.

Looks like it was an intentional choice to add the nodes in a specific order to the list. I'm fine with changing it, but that should be mentioned in the commit. Also it may be necessary to expose the `ui_order` in rna. Addons also need the ability to figure out which order nodes are drawn in for some modal operators. You could also try to figure when the order of nodes in `context.selected_nodes` became more explicit. Maybe some code relies on that currently.

Hans Goudey commented

2023-10-10 10:56:45 +02:00

I didn't see any code relying on this. I'll expose the ui_order in a follow-up PR, I agree that would be helpful.

I didn't see any code relying on this. I'll expose the `ui_order` in a follow-up PR, I agree that would be helpful.

Hans Goudey merged commit 1ccba4d9fe into main

2023-10-10 10:58:02 +02:00

Hans Goudey referenced this issue from a commit

2023-10-10 10:58:02 +02:00

Nodes: Use index instead of reordering for draw order

Hans Goudey deleted branch node-no-reorder

2023-10-10 10:58:04 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Nodes: Use index instead of reordering for draw order #113419