Geometry Nodes: Resample Edges node #113427

Open

Iliya Katushenock wants to merge 12 commits from mod_moder/blender:resample_edges_node into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Iliya Katushenock commented

2023-10-08 22:06:18 +02:00

Member

Resample Edges node. Like the Resample Curve node, edge resampler
is used to increase amount of points in one poly line. Usually, result is the
N-Gon mesh topology. Node can be used in way to create round holes in
faces or for other shapes from mesh faces. Resampling of loose edges will allow
to avoid conversion to curve to did resample as well.

Holes	Fractal resampling and triangulation

Resample Edges node. Like the Resample Curve node, edge resampler is used to increase amount of points in one poly line. Usually, result is the N-Gon mesh topology. Node can be used in way to create round holes in faces or for other shapes from mesh faces. Resampling of loose edges will allow to avoid conversion to curve to did resample as well. | Holes | Fractal resampling and triangulation | | -- | -- | | ![image](/attachments/69c1c46d-9335-4e4f-a1d7-dbac7f52d534) | ![image](/attachments/ed094942-0d0d-4fcc-9629-75a097409bf8) |

2023-10-08 22-48-21.mp4

6.8 MiB

130 KiB

464 KiB

👍 4 ❤️ 5

Iliya Katushenock added the

label 2023-10-08 22:06:18 +02:00

Iliya Katushenock added 1 commit 2023-10-08 22:06:30 +02:00

0a36f3059a init

Iliya Katushenock referenced this pull request

2023-10-08 22:07:03 +02:00

WIP: resample topology node #108436

Iliya Katushenock added this to the Nodes & Physics project 2023-10-08 22:07:28 +02:00

Iliya Katushenock changed title from ~~Geometry Nodes: Resample Edge node~~ to Geometry Nodes: Resample Edges node

2023-10-08 22:07:41 +02:00

Iliya Katushenock added 1 commit 2023-10-08 22:36:46 +02:00

5eb0c95f72 format

Iliya Katushenock added 2 commits 2023-10-09 21:06:01 +02:00

b89c9971e6 Merge branch 'main' into resample_edges_node

145cd40062 progress

Iliya Katushenock added 3 commits 2023-10-10 20:47:12 +02:00

5b9ba734a7 Merge branch 'main' into resample_edges_node

14514903c3 Merge branch 'main' into resample_edges_node

9ecc9a65f5 progress

Iliya Katushenock requested review from Jacques Lucke 2023-10-10 20:59:50 +02:00

Iliya Katushenock requested review from Hans Goudey 2023-10-10 20:59:51 +02:00

Jacques Lucke commented

2023-10-11 10:51:05 +02:00

Member

Can you show an example for how you use this node to create the holes?

Can you show an example for how you use this node to create the holes?

Iliya Katushenock commented

2023-10-11 14:15:09 +02:00

Author

Member

Basically, i resample face edges, set it shape to circle and delete it.

Basically, i resample face edges, set it shape to circle and delete it. ![image](/attachments/b33faf54-e321-4ce4-9425-738566e750a1)

holes_example.blend

992 KiB

345 KiB

fractal_resample_edges.blend

916 KiB

AgentA1cr commented

2023-10-11 17:16:54 +02:00

First-time contributor

This would be incredibly useful with a selection input.

This would be incredibly useful with a selection input.

Jacques Lucke commented

2023-10-12 13:43:05 +02:00

Member

Hm, currently I'm not convinced that this node makes too much sense by itself. With a selection input it would be more useful. I can see that it might be more useful in conjunction with the tesselate node, but I'd have to try them both together.

You might be able to change my mind with a more compelling example. A selection input would help for that example as well of course. Generally it would be nice to avoid having huge ngons as an intermediate step, but I'm not sure if that can be avoided in general.

Hm, currently I'm not convinced that this node makes too much sense by itself. With a selection input it would be more useful. I can see that it might be more useful in conjunction with the tesselate node, but I'd have to try them both together. You might be able to change my mind with a more compelling example. A selection input would help for that example as well of course. Generally it would be nice to avoid having huge ngons as an intermediate step, but I'm not sure if that can be avoided in general.

Iliya Katushenock commented

2023-10-12 16:55:21 +02:00

Author

Member

Well, just to clarify, Count input is a field, so Selection input doesn't make sense. Also, i see now, some node like Squaring (Kind of Triangulate node, but for 4-gons) will make loop cut much easier for user (such splitting still allow to polygonize any n-gon geometry or resample any edges/meshes in different task). Edge Rings node also in this area.. but yeah, all of this request artist feedback too.

Well, just to clarify, `Count` input is a field, so `Selection` input doesn't make sense. Also, i see now, some node like `Squaring` (Kind of `Triangulate` node, but for 4-gons) will make loop cut much easier for user (such splitting still allow to polygonize any n-gon geometry or resample any edges/meshes in different task). Edge Rings node also in this area.. but yeah, all of this request artist feedback too.

Marek Smoliński commented

2023-10-12 17:40:39 +02:00

First-time contributor

I think this node would be very useful: without it you have to convert the edge to a curve, delete neighboring faces of the edge, create as many curve circles for each edge as many faces were deleted, resample the circles based on old faces vertex count + added cuts on the edge, distribute the circles in a grid so they don't overlap, fill curves (which is very slow), then position the vertices of new circles on the spot of the old face, and I'm not sure at the moment on how to correctly map the indices…

Creating holes is I think a very nice example, because creating holes or circular extrusions is just so common in modelling.

Another example could be adaptive subdivision, which is made so much easier when you can split edges, subdivide selection, and subdivide edges of inverse selection (and merge by distance). One could even use Catmul-Clark without boundary preservation if he wouldn't mind (or ensure not to produce) non-coplanar n-gons surrounding the selection…

Is it possible to replicate adaptive subdivision in geometry nodes?
How to subdivide a selection of faces in geometry nodes
How to create gradual face subdivide effect with geometry nodes?

In general we need more subdivision methods, considering how some subdivision methods exist in Vanilla Blender in Edit Mode, but not in geonodes: How to subdivide triangles into four triangles with Geometry Nodes?

I think this node could compare favorably to some other nodes in regards to how hard is it to reproduce this functionality in existing nodes, how much performance it saves, how often it is used: corner of edge, corner of face, dual mesh - the last I think may get a nice synergy with this new "Resample Edge" node...

BTW, maybe instead of "Resample Edge" it should be "Subdivide Edge"?

I think this node would be very useful: without it you have to convert the edge to a curve, delete neighboring faces of the edge, create as many curve circles for each edge as many faces were deleted, resample the circles based on old faces vertex count + added cuts on the edge, distribute the circles in a grid so they don't overlap, fill curves (which is very slow), then position the vertices of new circles on the spot of the old face, and I'm not sure at the moment on how to correctly map the indices… Creating holes is I think a very nice example, because creating holes or circular extrusions is just so common in modelling. Another example could be adaptive subdivision, which is made so much easier when you can split edges, subdivide selection, and subdivide edges of inverse selection (and merge by distance). One could even use Catmul-Clark without boundary preservation if he wouldn't mind (or ensure not to produce) non-coplanar n-gons surrounding the selection… [Is it possible to replicate adaptive subdivision in geometry nodes?](https://blender.stackexchange.com/q/298717/60486) [How to subdivide a selection of faces in geometry nodes](https://blender.stackexchange.com/q/274918/60486) [How to create gradual face subdivide effect with geometry nodes?](https://blender.stackexchange.com/q/288467/60486) In general we need more subdivision methods, considering how some subdivision methods exist in Vanilla Blender in Edit Mode, but not in geonodes: [How to subdivide triangles into four triangles with Geometry Nodes?](https://blender.stackexchange.com/q/291926/60486) I think this node could compare favorably to some other nodes in regards to how hard is it to reproduce this functionality in existing nodes, how much performance it saves, how often it is used: corner of edge, corner of face, dual mesh - the last I think may get a nice synergy with this new "Resample Edge" node... BTW, maybe instead of "Resample Edge" it should be "Subdivide Edge"?

AgentA1cr commented

2023-10-12 18:05:34 +02:00

First-time contributor

Now that I realize the input is a field, yes, this would be incredibly useful. I've been wanting something like this for ages.

Now that I realize the input is a field, yes, this would be incredibly useful. I've been wanting something like this for ages.

baoyu commented

2023-10-12 20:48:07 +02:00

First-time contributor

Another example could be adaptive subdivision, which is made so much easier when you can split edges, subdivide selection, and subdivide edges of inverse selection (and merge by distance). One could even use Catmul-Clark without boundary preservation if he wouldn't mind (or ensure not to produce) non-coplanar n-gons surrounding the selection…

Yeah, I was trying to make adaptive subdivision in GN a few days ago and realized that this node is a perfectly match.

BTW, maybe instead of "Resample Edge" it should be "Subdivide Edge"?

Both sounds good to me.

> Another example could be adaptive subdivision, which is made so much easier when you can split edges, subdivide selection, and subdivide edges of inverse selection (and merge by distance). One could even use Catmul-Clark without boundary preservation if he wouldn't mind (or ensure not to produce) non-coplanar n-gons surrounding the selection… Yeah, I was trying to make adaptive subdivision in GN a few days ago and realized that this node is a perfectly match. > BTW, maybe instead of "Resample Edge" it should be "Subdivide Edge"? Both sounds good to me.

Jacques Lucke commented

2023-10-13 10:41:42 +02:00

Member

Well, just to clarify, Count input is a field, so Selection input doesn't make sense.

It should still have a selection. That's more consistent (see e.g. Duplicate Elements), easier to use and easier to optimize for us.

Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary? I haven't looked too much into tesselation yet, but it seems like that would provide a more straight forward way to add a hole to many faces, even without this node.

maybe instead of "Resample Edge" it should be "Subdivide Edge"?

I prefer Subdivide Edges as well.

> Well, just to clarify, Count input is a field, so Selection input doesn't make sense. It should still have a selection. That's more consistent (see e.g. `Duplicate Elements`), easier to use and easier to optimize for us. Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary? I haven't looked too much into tesselation yet, but it seems like that would provide a more straight forward way to add a hole to many faces, even without this node. > maybe instead of "Resample Edge" it should be "Subdivide Edge"? I prefer `Subdivide Edges` as well.

Iliya Katushenock commented

2023-10-13 11:06:41 +02:00

Author

Member

Oh, i just checked, Resample Curve have Selection input too... will add.
I really don't like references to Subdivide, this is not fractal subdivide operation.

Oh, i just checked, Resample Curve have `Selection` input too... will add. I really don't like references to `Subdivide`, this is not fractal subdivide operation.

Iliya Katushenock added 5 commits 2023-10-15 13:29:24 +02:00

0c9e5efe9b Merge branch 'main' into resample_edges_node

eccb8350b7 Merge branch 'main' into resample_edges_node

35d9dbf9a9 attemp to add selection

d902339f76 Merge branch 'main' into resample_edges_node

c99bb799ee add selection

Iliya Katushenock commented

2023-10-15 13:32:41 +02:00

Author

Member

Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary?

Done

> Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary? Done ![image](/attachments/7b8e2388-216a-49ea-8092-3bdeab3c15ff)

holes_example.blend

1.1 MiB

858 KiB

Ludvik Koutny commented

2023-11-03 10:17:26 +01:00

Contributor

Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary?

Done

Could this do also holes that don't unnecessarily subdivide outer edges of the quads? The geometry on the screenshot above still would not be very usable. Could it be used to achieve something like this?:

> > Can you change your example that adds a hole to a face so that it does not generate more geometry than necessary? > > Done > ![image](/attachments/7b8e2388-216a-49ea-8092-3bdeab3c15ff) Could this do also holes that don't unnecessarily subdivide outer edges of the quads? The geometry on the screenshot above still would not be very usable. Could it be used to achieve something like this?: ![image](/attachments/c78545f4-49c1-4f37-9418-365be8aabb1c)

899 KiB

Iliya Katushenock commented

2023-11-03 10:19:19 +01:00

Author

Member

Yes, just need some edges to be deselected.

Yes, just need some edges to be deselected.

Bun ny commented

2024-01-01 02:28:05 +01:00

First-time contributor

Looks to be the missing piece for loop cuts and adaptive subdivision. Would appreciate a buildbot build when the conflict is resolved.

Looks to be the missing piece for loop cuts and adaptive subdivision. Would appreciate a buildbot build when the conflict is resolved.

Daniel Gryningstjerna commented

2024-03-14 13:46:10 +01:00

First-time contributor

Any news? Seems very useful and would make it easier to make new types of modeling tools and modifiers that is not possible currently.

Any news? Seems very useful and would make it easier to make new types of modeling tools and modifiers that is not possible currently.

This pull request has changes conflicting with the target branch.

source/blender/blenkernel/BKE_node.h
source/blender/nodes/geometry/CMakeLists.txt

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u resample_edges_node:mod_moder-resample_edges_node

git checkout mod_moder-resample_edges_node

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

8 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113427

No description provided.