Fix #113463: VSE Hold-Split has no visual indication anymore #113494

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:113463 into blender-v4.0-release 2023-10-11 09:18:47 +02:00
Member

Exposed by cba9f47562 (but actually caused by 4d668e6825 I think).

Because of 4d668e6825 , the StripDrawContext content_start &
content_end were wrong for hold still regions.
These wrong extends were then used in cba9f47562 .

Now actually update StripDrawContext content_start & content_end
when hold still regions are in play (instead of just calling the right
functions [but not using their return values]).

Exposed by cba9f4756228 (but actually caused by 4d668e6825ac I think). Because of 4d668e6825ac , the `StripDrawContext` `content_start` & `content_end` were wrong for hold still regions. These wrong extends were then used in cba9f4756228 . Now actually update `StripDrawContext` `content_start` & `content_end` when hold still regions are in play (instead of just calling the right functions [but not using their return values]).
Philipp Oeser added 1 commit 2023-10-10 14:51:22 +02:00
Exposed by cba9f47562 (but actually caused by 4d668e6825 I think).

Because of 4d668e6825 , the `StripDrawContext` `content_start` &
`content_end` were wrong for hold still regions.
These wrong extends were then used in cba9f47562 .

Now actually update `StripDrawContext` `content_start` & `content_end`
when hold still regions are in play (instead of just calling the right
functions [but not using their return values]).
Philipp Oeser requested review from Richard Antalik 2023-10-10 14:51:30 +02:00
Philipp Oeser added this to the Video Sequencer project 2023-10-10 14:51:42 +02:00
Philipp Oeser added the
Interest
User Interface
label 2023-10-10 14:51:50 +02:00
Richard Antalik approved these changes 2023-10-10 21:23:18 +02:00
Philipp Oeser merged commit 0e18097674 into blender-v4.0-release 2023-10-11 09:18:47 +02:00
Philipp Oeser deleted branch 113463 2023-10-11 09:18:52 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113494
No description provided.