Refactor: Move keyframing code to animrig #113503

Christoph Lendenfeld · 2023-10-10T17:00:26+02:00

Christoph Lendenfeld commented

2023-10-10 17:00:26 +02:00

No functional changes.

Move the following keyframing functions to the animrig folder

insert_keyframe_direct
insert_keyframe
delete_keyframe
clear_keyframe

In order to disentangle the code I had to move the following as well

delete_keyframe_fcurve
visualkey_can_use
visualkey_get_values

In order to sort the functions I made 3 files (and their header counterparts)

fcurve.cc
keyframing.cc
visualkey.cc

The following functions I made public so they won't get duplicated

update_autoflags_fcurve_direct
ANIM_setting_get_rna_values

There are public keyframing functions that I left in the editors/animation/keyframing.cc file
I'd like to limit the scope of this refactor, and then clean up the moved functions before moving even more over

Part of #113278: Anim: Keyframing Rework

No functional changes. Move the following keyframing functions to the animrig folder * `insert_keyframe_direct` * `insert_keyframe` * `delete_keyframe` * `clear_keyframe` In order to disentangle the code I had to move the following as well * `delete_keyframe_fcurve` * `visualkey_can_use` * `visualkey_get_values` In order to sort the functions I made 3 files (and their header counterparts) * fcurve.cc * keyframing.cc * visualkey.cc The following functions I made public so they won't get duplicated * `update_autoflags_fcurve_direct` * `ANIM_setting_get_rna_values` There are public keyframing functions that I left in the editors/animation/keyframing.cc file I'd like to limit the scope of this refactor, and then clean up the moved functions before moving even more over Part of [#113278: Anim: Keyframing Rework](https://projects.blender.org/blender/blender/issues/113278)

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-10-10 17:00:26 +02:00

Christoph Lendenfeld added 1 commit 2023-10-10 17:00:42 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

e2dcd559ce move code to animrig

Christoph Lendenfeld commented

2023-10-10 17:02:01 +02:00

@blender-bot build

Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-10-10 17:08:33 +02:00

Christoph Lendenfeld referenced this pull request

2023-10-10 17:09:35 +02:00

Anim: Keyframing Rework #113278

Christoph Lendenfeld added this to the Animation & Rigging project 2023-10-10 17:10:21 +02:00

Christoph Lendenfeld added 1 commit 2023-10-10 17:23:59 +02:00

5e3741a832 remove unused imports

Sybren A. Stüvel approved these changes 2023-10-12 12:31:17 +02:00

Sybren A. Stüvel left a comment

LGTM. The only thing that I see now is that it's probably fine to use using blender; at the top of a file, then use animrig::the_function() in the rest.

LGTM. The only thing that I see now is that it's probably fine to use `using blender;` at the top of a file, then use `animrig::the_function()` in the rest.

Christoph Lendenfeld commented

2023-10-12 12:46:15 +02:00

i had a quick look at using using blender; but I couldn't get it to work. will land this now and look at shortening the namespacing later

i had a quick look at using `using blender;` but I couldn't get it to work. will land this now and look at shortening the namespacing later

👍 1

Christoph Lendenfeld referenced this issue from a commit

2023-10-12 12:46:54 +02:00

Refactor: Move keyframing code to animrig

Christoph Lendenfeld merged commit 555731f8aa into main

2023-10-12 12:46:55 +02:00

Christoph Lendenfeld deleted branch refactor_move_functions_to_animrig

2023-10-12 12:46:56 +02:00

Christoph Lendenfeld removed this from the Animation & Rigging project 2023-10-24 09:30:10 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Refactor: Move keyframing code to animrig #113503