GPv3: Implement expanding of Grease Pencil component in the spreadsheet #113507
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#113507
Loading…
Reference in New Issue
No description provided.
Delete Branch "filedescriptor/blender:gpv3-geometry-nodes-spreadsheet-layer-tree"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This patch adds the ability for users to expand the grease pencil component in the spreadsheet and see the values for each
CurvesGeometry
in each layer.313a0a06ee
to3f4c0cfcc9
WIP: GPv3: Implement expanding of Grease Pencil component in the spreadsheetto GPv3: Implement expanding of Grease Pencil component in the spreadsheet@ -424,0 +453,4 @@
}
if (const bke::greasepencil::Drawing *drawing =
bke::greasepencil::get_eval_grease_pencil_layer_drawing(*grease_pencil,
component_index_))
This results in an assert if the index is out of range.
@ -1986,2 +1986,4 @@
/* eSpaceSpreadsheet_ObjectEvalState. */
uint8_t object_eval_state;
/* Active index for list of components in another component. */
uint32_t active_component_index;
Think we should just call this by what it is: active grease pencil layer index.
Use
int
instad ofuint32_t
.@ -503,8 +542,8 @@ bke::GeometrySet spreadsheet_get_display_geometry_set(const SpaceSpreadsheet *ss
if (object_orig->mode == OB_MODE_EDIT) {
if (const BMEditMesh *em = mesh->edit_mesh) {
Mesh *new_mesh = (Mesh *)BKE_id_new_nomain(ID_ME, nullptr);
/* This is a potentially heavy operation to do on every redraw. The best solution here is
Could revert this whitespace change
Updated screenshot:
@ -43,6 +43,7 @@ class GeometryDataSource : public DataSource {
const bke::GeometrySet geometry_set_;
const bke::GeometryComponent *component_;
eAttrDomain domain_;
const int component_index_;
I know we're not consistent about this ("geometry_set_" above), but better not to use const for value types inside a class. That means it can't be moved, for example. Also, I'd like to see "component_index" renamed to "layer_index" everywhere, since it's not the index of the component
After talking with Pablo about the UI we decided it would be best to allow all components to be collapsible. There are some UI tweaks that we need to make like moving the icons a little.
@ -38,6 +41,15 @@ class GeometryDataSetTreeViewItem : public ui::AbstractTreeViewItem {
StringRef label,
BIFIconID icon);
GeometryDataSetTreeViewItem(bke::GeometryComponent::Type component_type,
int component_index,
There are still many places that use
component_index
instead oflayer_index
.