Fix #110524: Use correct typed API to retrieve python GPU buffer sizes #113566

Merged
Jesse Yurkovich merged 1 commits from deadpin/blender:fix110524-largebuffers into blender-v4.0-release 2023-10-12 07:44:22 +02:00

Large GPU buffers can overflow their dimension property due to the use
of PyLong_AsLong instead of PyLong_AsSsize_t for the 1-dimensional
buffer case.

Example: Attempting to do the following would fail:

import gpu

fb = gpu.state.active_framebuffer_get()
fb.clear(color=(0.0, 0.0, 0.0, 0.0))

width = 23172
height = 23172
pixel_data = fb.read_color(0, 0, width, height, 4, 0, 'UBYTE')
pixel_data.dimensions = width * height * 4

Notes

The multi-dimensional case was also changed to use PyLong_AsSsize_t though it's arguable if that one is necessary given the size of images/documents that would produce.

To fully address the bug filer's issue, the UV export addon should have its "Size" property modified to allow sizes larger than 32k as they wanted to output a 40000 x 20000 image. This will work for SVG/EPS formats however PNG would still fail. Blender is ultimately limited by the max 2d texture size of the OpenGL driver which is typically 32k. So this patch allows 32k to work with PNGs but for larger sizes you'll need to continue to use SVG etc.

Large GPU buffers can overflow their dimension property due to the use of `PyLong_AsLong` instead of `PyLong_AsSsize_t` for the 1-dimensional buffer case. Example: Attempting to do the following would fail: ``` import gpu fb = gpu.state.active_framebuffer_get() fb.clear(color=(0.0, 0.0, 0.0, 0.0)) width = 23172 height = 23172 pixel_data = fb.read_color(0, 0, width, height, 4, 0, 'UBYTE') pixel_data.dimensions = width * height * 4 ``` ---- Notes The multi-dimensional case was also changed to use `PyLong_AsSsize_t` though it's arguable if that one is necessary given the size of images/documents that would produce. To fully address the bug filer's issue, the UV export addon should have its "Size" property modified to allow sizes larger than 32k as they wanted to output a 40000 x 20000 image. This will work for SVG/EPS formats however PNG would still fail. Blender is ultimately limited by the max 2d texture size of the OpenGL driver which is typically 32k. So this patch allows 32k to work with PNGs but for larger sizes you'll need to continue to use SVG etc.
Jesse Yurkovich added 1 commit 2023-10-12 02:06:30 +02:00
Jesse Yurkovich requested review from Germano Cavalcante 2023-10-12 02:07:51 +02:00
Germano Cavalcante approved these changes 2023-10-12 02:50:18 +02:00
Germano Cavalcante left a comment
Member

Looks good! And correct!

To fully address the bug filer's issue, ...

Is there still something missing to fix the addon? If so, the title may be misleading.

Looks good! And correct! > To fully address the bug filer's issue, ... Is there still something missing to fix the addon? If so, the title may be misleading.
Author
Member

Is there still something missing to fix the addon? If so, the title may be misleading.

Yeah, but only because the bug was actually 2 different issues really, and the other one needs fixing in the blender-addons repo. I can remove the "Fix" tag from this title and close the bug manually once both are checked in. Want to do that?

> Is there still something missing to fix the addon? If so, the title may be misleading. Yeah, but only because the bug was actually 2 different issues really, and the other one needs fixing in the blender-addons repo. I can remove the "Fix" tag from this title and close the bug manually once both are checked in. Want to do that?

I will trust your decision ;)

Since the report is in the blender repository, it actually seems to be expected to close with what can be done in the repository.

I will trust your decision ;) Since the report is in the blender repository, it actually seems to be expected to close with what can be done in the repository.
Jesse Yurkovich merged commit fa987dc059 into blender-v4.0-release 2023-10-12 07:44:22 +02:00
Jesse Yurkovich deleted branch fix110524-largebuffers 2023-10-12 07:44:26 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113566
No description provided.