Fix #101058: Allow Cryptomatte Picking Between Windows #113636

Harley Acheson · 2023-10-13T02:44:06+02:00

Harley Acheson commented

2023-10-13 02:44:06 +02:00

Allow the source and target windows to differ when selecting
objects using Cryptomatte.

Allow the source and target windows to differ when selecting objects using Cryptomatte. --- ![CryptoMatte.gif](/attachments/0eb9747c-5790-4845-8083-523cb980fd38)

CryptoMatte.gif

240 KiB

CryptoPickWin.gif

176 KiB

Harley Acheson added 1 commit 2023-10-13 02:44:18 +02:00

bf24467e10 Fix #101058 : Allow Cryptomatte Picking Between Windows

Allow the source and target windows to differ when selecting
objects using Cryptomatte. But this does not show the name.

Harley Acheson added this to the User Interface project 2023-10-13 02:44:47 +02:00

Harley Acheson requested review from Germano Cavalcante 2023-10-13 02:53:30 +02:00

Germano Cavalcante commented

2023-10-13 17:37:44 +02:00

The code is simple and straightforward, it seems easy to implement.

But I believe that more clarification is needed as to why the name cannot be displayed in other windows.

It was mentioned that we can reassign the callback to the other window. But it's not clear why this doesn't work. And the real reason why it's not worth implementing it either. (Code gets too complex and hard to maintain?).

The code is simple and straightforward, it seems easy to implement. But I believe that more clarification is needed as to why the name cannot be displayed in other windows. It was mentioned that we can reassign the callback to the other window. But it's not clear why this doesn't work. And the real reason why it's not worth implementing it either. (Code gets too complex and hard to maintain?).

Harley Acheson commented

2023-10-13 17:52:33 +02:00

It was mentioned that we can reassign the callback to the other window. But it's not clear why this doesn't work. And the real reason why it's not worth implementing it either. (Code gets too complex and hard to maintain?).

I don't mind setting this to "WIP" and tackling that too when I get a chance. I'm fairly certain that existing code will allow that name display on the other window as I have done multi-window callbacks with #104665 okay. But in this case I gave that part of it an hour or so and could only get some "?????" showing in the wrong location. It looked like it was turning into a time sink and my next four weeks are pretty blown.

So I could set this WIP and get to it when I can or I could just add some "TODO" comments with explanation on why it is not showing the label and how to approach making that work. What do you think?

> It was mentioned that we can reassign the callback to the other window. But it's not clear why this doesn't work. And the real reason why it's not worth implementing it either. (Code gets too complex and hard to maintain?). I don't mind setting this to "WIP" and tackling that too when I get a chance. I'm fairly certain that existing code will allow that name display on the other window as I have done multi-window callbacks with #104665 okay. But in this case I gave that part of it an hour or so and could only get some "?????" showing in the wrong location. It looked like it was turning into a time sink and my next four weeks are pretty blown. So I could set this WIP and get to it when I can or I could just add some "TODO" comments with explanation on why it is not showing the label and how to approach making that work. What do you think?

Germano Cavalcante commented

2023-10-13 18:03:58 +02:00

It may be worth checking whether other drawing callback APIs (such as region or cursor APIs) can be used instead of Windows.

Harley Acheson commented

2023-10-13 18:08:36 +02:00

It may be worth checking whether other drawing callback APIs (such as region or cursor APIs) can be used instead of Windows.

Thanks for the tips! I'll set this to WIP for now, at least through the weekend, and investigate a bit further.

> It may be worth checking whether other drawing callback APIs (such as region or cursor APIs) can be used instead of Windows. Thanks for the tips! I'll set this to WIP for now, at least through the weekend, and investigate a bit further.

Harley Acheson changed title from ~~Fix #101058: Allow Cryptomatte Picking Between Windows~~ to WIP: Fix #101058: Allow Cryptomatte Picking Between Windows

2023-10-13 18:08:55 +02:00

Germano Cavalcante approved these changes 2023-10-13 20:56:08 +02:00

Germano Cavalcante left a comment

On second thought, with or without the text, it's still better than the lack of support for multiple windows.

Drawing can be implemented later.

(It would just be nice to avoid taking too long, as this feature seems incomplete without it).

On second thought, with or without the text, it's still better than the lack of support for multiple windows. Drawing can be implemented later. (It would just be nice to avoid taking too long, as this feature seems incomplete without it).

Harley Acheson added 2 commits 2023-10-13 21:47:29 +02:00

219e17860e Merge branch 'main' of projects.blender.org:blender/blender into CryptoWin

c3c4d25b05 Adding a TODO comment.

Harley Acheson added 2 commits 2023-10-14 19:30:11 +02:00

58f8dd1274 Merge branch 'main' of projects.blender.org:blender/blender into CryptoWin

buildbot/vexp-code-patch-coordinator Build done. Details

41f6b5eb87 Properly showing the object name now on other windows.

Harley Acheson changed title from ~~WIP: Fix #101058: Allow Cryptomatte Picking Between Windows~~ to Fix #101058: Allow Cryptomatte Picking Between Windows

2023-10-14 19:36:03 +02:00

Harley Acheson commented

2023-10-14 19:37:52 +02:00

@mano-wii

Got it working with the object names!

@mano-wii Got it working with the object names!

Harley Acheson commented

2023-10-14 19:51:07 +02:00

@blender-bot build

Harley Acheson added 1 commit 2023-10-14 20:26:12 +02:00

15fa0ceab1 Unused parameter

Harley Acheson merged commit 9ee5de05c0 into main