EEVEE: Fix Fallback Shader Shadow Page Tile Store #113649

Merged

Jeroen Bakker merged 1 commits from Jeroen-Bakker/blender:eevee/fix-stage-interfaces into main

2023-10-13 10:42:35 +02:00

Jeroen Bakker commented

2023-10-13 10:22:17 +02:00

Member

eevee_shadow_page_tile_store shader uses VIEWPORT_INDEX and LAYER.
Both use an optional extension in OpenGL and Vulkan. When the extension
isn't available a geometry shader is injected to emulate the
extension. The generated geometry shader requires instance_name to be
set. This wasn't the case for eevee_shadow_page_tile_store shader.

This PR also adds a detection for incompatible shader infos.

Shaders that use VIEWPORT_INDEX or LAYER cannot have a geometry stage.
This check is done in debug and release builds.
Shaders that use a fallback shader should have instance names set in
the stage interfaces. This check is only done in debug builds.

`eevee_shadow_page_tile_store` shader uses `VIEWPORT_INDEX` and `LAYER`. Both use an optional extension in OpenGL and Vulkan. When the extension isn't available a geometry shader is injected to emulate the extension. The generated geometry shader requires `instance_name` to be set. This wasn't the case for `eevee_shadow_page_tile_store` shader. This PR also adds a detection for incompatible shader infos. - Shaders that use `VIEWPORT_INDEX` or `LAYER` cannot have a geometry stage. This check is done in debug and release builds. - Shaders that use a fallback shader should have instance names set in the stage interfaces. This check is only done in debug builds.

Jeroen Bakker added this to the 4.1 milestone 2023-10-13 10:22:17 +02:00

Jeroen Bakker added the

EEVEE & Viewport

labels 2023-10-13 10:22:18 +02:00

Jeroen Bakker self-assigned this 2023-10-13 10:22:18 +02:00

Jeroen Bakker added 1 commit 2023-10-13 10:22:31 +02:00

0129ea2dcf EEVEE: Fix Fallback Shader Shadow Page Tile Store

The eevee_shadow_page_tile_store shader uses VIEWPORT_INDEX and LAYER.
Both use an optional extension in OpenGL and Vulkan. When the extension
isn't available a fallback geometry shader is injected to emulate the
extension. The generated geometry shader requires instance_name to be
set. This wasn't the case for eevee_shadow_page_tile_store shader.

This PR also adds a detection for incompatible shader infos.
- Shaders that use VIEWPORT_INDEX or LAYER cannot have a geometry stage.
  This check is done always.
- Shaders that use a fallback shader should have instance names set in
  the stage interfaces. This check is only done in debug builds.

Jeroen Bakker requested review from Clément Foucault 2023-10-13 10:22:42 +02:00

Jeroen Bakker added this to the EEVEE & Viewport project 2023-10-13 10:22:46 +02:00

Clément Foucault approved these changes 2023-10-13 10:36:04 +02:00

Jeroen Bakker merged commit 28c4abe57c into main

2023-10-13 10:42:35 +02:00

Jeroen Bakker referenced this issue from a commit

2023-10-13 10:42:35 +02:00

EEVEE: Fix Fallback Shader Shadow Page Tile Store

Jeroen Bakker deleted branch eevee/fix-stage-interfaces

2023-10-13 14:33:17 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113649

No description provided.